From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <palves@redhat.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] vec: Silence -Wunused-function warnings on clang
Date: Mon, 26 Jun 2017 12:52:00 -0000 [thread overview]
Message-ID: <f246185f5c9057bf1bcdf3dc21ac6ea2@polymtl.ca> (raw)
In-Reply-To: <31ac014f-ea44-020f-d999-5bee4dd8293f@redhat.com>
On 2017-06-26 14:47, Pedro Alves wrote:
> On 06/26/2017 01:28 PM, Simon Marchi wrote:
>
>> I wanted to keep it simple and easy to understand, so I didn't want to
>> add to many layers of definitions. I thought that even if we ignored
>> -Wunused-function in the vector macro expansions when compiling with
>> GCC, it wasn't a big deal.
>
> That's another option (and I think it should be fine, with a comment),
> but it wasn't what the patch was doing, so you'd be leaving deciding
> whether that's fine to whoever comes next and wants to make
> DIAGNOSTICS_IGNORE_UNUSED_FUNCTION on gcc. IMO, that's a form of
> technical dept that we should avoid.
You are right, and it was due to technical laziness :P.
next prev parent reply other threads:[~2017-06-26 12:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-25 17:45 [PATCH 0/3] Third series towards a warning-less clang build Simon Marchi
2017-06-25 17:45 ` [PATCH 3/3] record-full: Remove unused function netorder16 Simon Marchi
2017-06-26 10:43 ` Yao Qi
2017-06-26 14:54 ` Simon Marchi
2017-06-25 17:45 ` [PATCH 1/3] ada-lex: Ignore warnings about register keyword Simon Marchi
2017-06-26 13:13 ` Pedro Alves
2017-06-26 13:39 ` Simon Marchi
2017-06-26 14:54 ` [pushed] " Simon Marchi
2017-06-25 17:45 ` [PATCH 2/3] vec: Silence -Wunused-function warnings on clang Simon Marchi
2017-06-26 9:28 ` Pedro Alves
2017-06-26 12:28 ` Simon Marchi
2017-06-26 12:47 ` Pedro Alves
2017-06-26 12:52 ` Simon Marchi [this message]
[not found] ` <1498481156-10705-1-git-send-email-simon.marchi@ericsson.com>
2017-06-26 13:03 ` [PATCH 2/3 v2] " Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f246185f5c9057bf1bcdf3dc21ac6ea2@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox