Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdbserver: Suffix generated C files with -generated
Date: Fri, 31 Mar 2017 12:24:00 -0000	[thread overview]
Message-ID: <f2389355-1418-eed4-5a82-248448cad755@redhat.com> (raw)
In-Reply-To: <871c88f7fe38d2dbe72900a0561a38af@polymtl.ca>

Hi Simon,

On 03/30/2017 04:31 AM, Simon Marchi wrote:

>> @@ -8252,7 +8252,7 @@ $as_echo "#define USE_LIBTHREAD_DB_DIRECTLY 1"
>> >>confdefs.h
>>  fi
>>
>>  if test "$srv_xmlfiles" != ""; then
>> -  srv_xmlbuiltin="xml-builtin.o"
>> +  srv_xmlbuiltin="xml-builtin-generated.o"
> 
> Hmm actually we don't need to rename this, the other .o files are not
> named -generated.  You can forget changes to configure/configure.ac (I
> removed them locally).

I'm confused on what the result will be.  The patch had this in Makefile.in,
for example:

-	version.o \
+	version-generated.o \

Can you post the updated patch?

Thanks,
Pedro Alves


  reply	other threads:[~2017-03-31 12:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-30  3:14 Simon Marchi
2017-03-30  3:31 ` Simon Marchi
2017-03-31 12:24   ` Pedro Alves [this message]
2017-03-31 13:35     ` Simon Marchi
2017-03-31 14:56     ` [PATCH v2] " Simon Marchi
2017-03-31 15:13       ` Pedro Alves
     [not found]         ` <3038cd35b397eeafa1f8f0447630fa8e@polymtl.ca>
2017-03-31 18:46           ` Simon Marchi
2017-03-31 19:39             ` Simon Marchi
2017-04-04 10:44               ` Pedro Alves
2017-04-04 14:52                 ` [PATCH pushed] gdbserver: Clear .deps on clean Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2389355-1418-eed4-5a82-248448cad755@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox