From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 97D8B3858D35 for ; Mon, 3 Aug 2020 12:18:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 97D8B3858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 24F681E554; Mon, 3 Aug 2020 08:18:20 -0400 (EDT) Subject: Re: [PATCHv3 2/3] gdb/testsuite: Detect and warn about duplicate test names To: Andrew Burgess Cc: gdb-patches@sourceware.org References: <69e3904db9020da1941ec91e4b4b9c1ea2a6493d.1588245462.git.andrew.burgess@embecosm.com> <685b3981-8a03-ff1b-ce22-a7fd101c6fef@simark.ca> <20200803100215.GT853475@embecosm.com> From: Simon Marchi Message-ID: Date: Mon, 3 Aug 2020 08:18:13 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200803100215.GT853475@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Aug 2020 12:18:22 -0000 On 2020-08-03 6:02 a.m., Andrew Burgess wrote: > `all_test_names` is local to gdb/testsuite/lib/check-test-names.exp, > so shouldn't depend on the version of dejagnu being run. > > I tried installing version 1.5.1 of dejagnu, and as expected that > works fine. > > My guess is that this is either a problem with an older version of > tcl, or maybe expect (?) > > Or else, there's something specific about exactly what test you're > running, with the particular settings you're using that's triggering > this issue. > > Can you include the output of `runtest --version` so we can see which > tcl/expect are being used, and provide the full `make check` command > you're running. Ah apologies for reaching a wrong conclusion, I sent this quite in a hurry. Here it is: [simark@gcc135 gdb]$ runtest --version WARNING: Couldn't find the global config file. Expect version is 5.45 Tcl version is 8.5 Framework version is 1.5.1 I'm simply running "make check". Simon