From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56379 invoked by alias); 12 Feb 2020 04:57:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56362 invoked by uid 89); 12 Feb 2020 04:57:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Feb 2020 04:57:21 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A18BE1E602; Tue, 11 Feb 2020 23:57:19 -0500 (EST) Subject: Re: [PATCH] Fix kill of processes created by win32_create_inferior From: Simon Marchi To: Luis Machado , Hannes Domani , gdb-patches@sourceware.org References: <20200208182539.5775-1-ssbssa.ref@yahoo.de> <20200208182539.5775-1-ssbssa@yahoo.de> <7c602a71-ea74-4720-0def-9f60cc0bd7c2@simark.ca> Message-ID: Date: Wed, 12 Feb 2020 04:57:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <7c602a71-ea74-4720-0def-9f60cc0bd7c2@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg00442.txt.bz2 On 2020-02-11 11:18 p.m., Simon Marchi wrote: > On 2020-02-10 5:33 p.m., Luis Machado wrote: >> On 2/8/20 3:25 PM, Hannes Domani via gdb-patches wrote: >>> handle_v_kill uses signal_pid because win32 doesn't support multi-process. >>> >>> gdbserver/ChangeLog: >>> >>> 2020-02-08 Hannes Domani >>> >>> * win32-low.c (win32_create_inferior): Set signal_pid. >>> --- >>> gdbserver/win32-low.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/gdbserver/win32-low.c b/gdbserver/win32-low.c >>> index 9d0343788f..557c90d97c 100644 >>> --- a/gdbserver/win32-low.c >>> +++ b/gdbserver/win32-low.c >>> @@ -709,6 +709,9 @@ win32_create_inferior (const char *program, >>> (assuming success). */ >>> cs.last_ptid = win32_wait (ptid_t (current_process_id), &cs.last_status, 0); >>> >>> + /* Necessary for handle_v_kill. */ >>> + signal_pid = current_process_id; >>> + >>> return current_process_id; >>> } >>> >>> >> >> Thanks. This one looks OK to me. >> >> It would be nice to augment the description with what situation this >> fixes. I suppose it doesn't kill the process properly? > > Agreed. The patch looks ok, as far as I understand, but it would be good to > explain in the commit message what's the bug, how you provoke it, how the new > behavior differs from the previous behavior. > > Simon > Sorry, I just saw that you have already posted a v2, I'll at it now. Simon