From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129596 invoked by alias); 16 Aug 2017 19:14:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129553 invoked by uid 89); 16 Aug 2017 19:13:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Aug 2017 19:13:57 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D616480E72; Wed, 16 Aug 2017 19:13:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D616480E72 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3873A61F32; Wed, 16 Aug 2017 19:13:55 +0000 (UTC) Subject: Re: [PUSHED] Add shortcuts for "nexti" and "stepi" commands in Single-Key mode To: Ruslan Kabatsayev , gdb-patches@sourceware.org References: <1502909374-20367-1-git-send-email-b7.10110111@gmail.com> From: Pedro Alves Message-ID: Date: Wed, 16 Aug 2017 19:14:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1502909374-20367-1-git-send-email-b7.10110111@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-08/txt/msg00327.txt.bz2 IMO this warrants a gdb/NEWS entry. Thanks, Pedro Alves On 08/16/2017 07:49 PM, Ruslan Kabatsayev wrote: > Currently, "layout asm" is not so useful as "layout src" with Single-Key mode: > you have to use multi-key commands like "ni" and "si" to do single-stepping. > This patch adds, in addition to "next" and "step" commands, corresponding > assembly-level ones - "nexti" and "stepi" - to Single-Key mode, with the > shortcuts of "o" (from "step Over") and "i" (from "Step Into") respectively. > > gdb/ChangeLog: > > * tui/tui.c (tui_commands): Add "nexti" and "stepi" to the Single-Key > mode command list. > > gdb/doc/ChangeLog: > > * gdb.texinfo (TUI Single Key Mode): Document the new shortcuts in > Single-Key mode. > --- > gdb/ChangeLog | 5 +++++ > gdb/doc/ChangeLog | 5 +++++ > gdb/doc/gdb.texinfo | 8 ++++++++ > gdb/tui/tui.c | 2 ++ > 4 files changed, 20 insertions(+) > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index ea5dd32..dc184c5 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,3 +1,8 @@ > +2017-08-16 Ruslan Kabatsayev > + > + * tui/tui.c (tui_commands): Add "nexti" and "stepi" to the Single-Key > + mode command list. > + > 2017-08-15 Stafford Horne > > * MAINTAINERS (Write After Approval): Add Stafford Horne. > diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog > index 4b40698..8e3e5ce 100644 > --- a/gdb/doc/ChangeLog > +++ b/gdb/doc/ChangeLog > @@ -1,3 +1,8 @@ > +2017-08-16 Ruslan Kabatsayev > + > + * gdb.texinfo (TUI Single Key Mode): Document the new shortcuts in > + Single-Key mode. > + > 2017-08-12 Sergio Durigan Junior > > PR gdb/21925 > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 7528183..0d39a55 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -25415,6 +25415,10 @@ finish > @item n > next > > +@kindex o @r{(SingleKey TUI key)} > +@item o > +nexti. The shortcut letter @samp{o} stands for ``step Over''. > + > @kindex q @r{(SingleKey TUI key)} > @item q > exit the SingleKey mode. > @@ -25427,6 +25431,10 @@ run > @item s > step > > +@kindex i @r{(SingleKey TUI key)} > +@item i > +stepi. The shortcut letter @samp{i} stands for ``step Into''. > + > @kindex u @r{(SingleKey TUI key)} > @item u > up > diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c > index c918f3e..b77a885 100644 > --- a/gdb/tui/tui.c > +++ b/gdb/tui/tui.c > @@ -75,8 +75,10 @@ static const struct tui_char_command tui_commands[] = { > { 'd', "down" }, > { 'f', "finish" }, > { 'n', "next" }, > + { 'o', "nexti" }, > { 'r', "run" }, > { 's', "step" }, > + { 'i', "stepi" }, > { 'u', "up" }, > { 'v', "info locals" }, > { 'w', "where" }, >