From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52607 invoked by alias); 8 Jul 2018 16:05:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52598 invoked by uid 89); 8 Jul 2018 16:05:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:907 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 08 Jul 2018 16:05:26 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 0EA001E059; Sun, 8 Jul 2018 12:05:23 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531065924; bh=Ct8JxUaY6aLO/SELS+rsTTqs329NaiYa8X13qwIerME=; h=Subject:To:References:From:Date:In-Reply-To:From; b=KORdFcQs2ZQOiyQbRe0lcrMVQuQEmH0XSzVkJ886Lcu3+wlV1/cuvCqIGHlCVkOvX wogQafDH17R8hhcNndS4uHjMff5kteeDnXx8284XD8UmxMpwqcbUiCTKmc9I3/+Gvg SLWYwIaqNtrY7jbThJ88CPJhEfusm31rHOeK51Mw= Subject: Re: [RFA 06/42] Move have_line_numbers to buildsym_compunit To: Keith Seitz , Tom Tromey , gdb-patches@sourceware.org References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-7-tom@tromey.com> <62ee17d0-af6d-5fde-855f-52b9a8d87189@redhat.com> From: Simon Marchi Message-ID: Date: Sun, 08 Jul 2018 16:05:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <62ee17d0-af6d-5fde-855f-52b9a8d87189@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00180.txt.bz2 On 2018-07-05 03:01 PM, Keith Seitz wrote: > Hi, > > I have just one trivial request: > > On 05/22/2018 09:58 PM, Tom Tromey wrote: >> diff --git a/gdb/buildsym.c b/gdb/buildsym.c >> index c3961254da..d0dfa4cd02 100644 >> --- a/gdb/buildsym.c >> +++ b/gdb/buildsym.c >> @@ -1288,7 +1286,7 @@ end_symtab_get_static_block (CORE_ADDR end_addr, int expandable, int required) >> && pending_blocks == NULL >> && file_symbols == NULL >> && global_symbols == NULL >> - && have_line_numbers == 0 >> + && buildsym_compunit->m_have_line_numbers == 0 >> && buildsym_compunit->m_pending_macros == NULL >> && global_using_directives == NULL) >> { > > Since m_have_line_numbers was declared bool, I prefer (and I think most do?) that the comparison use `false' instead. > > Keith Right, or even !buildsym_compunit->m_have_line_numbers. LGTM either way. Simon