Re: [PATCH v2 1/2] Display ExceptionRecord for $_siginfo

[Simon Marchi <simark@simark.ca>]

On 2020-02-08 11:26 a.m., Hannes Domani via gdb-patches wrote:
> Uses the $_siginfo convenience variable to show the last exception.
> 
> The type looks like this:
> 
> (gdb) pt $_siginfo
> type = struct EXCEPTION_RECORD {
>     DWORD ExceptionCode;
>     DWORD ExceptionFlags;
>     struct EXCEPTION_RECORD *ExceptionRecord;
>     PVOID ExceptionAddress;
>     DWORD NumberParameters;
>     ULONG_PTR ExceptionInformation[15];
> }
> 
> EXCEPTION_RECORD is documented at [1].
> 
> Example:
> 
> Program received signal SIGSEGV, Segmentation fault.
> main () at crasher.c:4
> 4         *(int*)0x123 = 0;
> (gdb) p $_siginfo
> $1 = {
>   ExceptionCode = 3221225477,
>   ExceptionFlags = 0,
>   ExceptionRecord = 0x0,
>   ExceptionAddress = 0x401632 <main+18>,
>   NumberParameters = 2,
>   ExceptionInformation = {1, 291, 0 <repeats 13 times>}
> }
> (gdb) p/x $_siginfo.ExceptionCode
> $2 = 0xc0000005
> (gdb) p/x $_siginfo.ExceptionInformation[1]
> $3 = 0x123
> 
> And 0xc0000005 is the value of EXCEPTION_ACCESS_VIOLATION.
> 
> [1] https://docs.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-exception_record

Eli, could you please comment on this from a Windows user point of view, if this looks
correct to you?  Also, does this need a manual/NEWS update?

The patch otherwise looks ok to me.

Simon