From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123169 invoked by alias); 11 Jan 2017 20:50:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 123151 invoked by uid 89); 11 Jan 2017 20:50:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.2 required=5.0 tests=AWL,BAYES_50,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=sk:mep_gdb, print_insn_mep, UD:mep-tdep.c, mep-tdep.c X-Spam-User: qpsmtpd, 2 recipients X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Jan 2017 20:50:34 +0000 Received: by simark.ca (Postfix, from userid 33) id BA6D61E93F; Wed, 11 Jan 2017 15:50:32 -0500 (EST) To: Yao Qi Subject: Re: [PATCH 2/8] Call print_insn_mep in mep_gdb_print_insn X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 11 Jan 2017 20:50:00 -0000 From: Simon Marchi Cc: binutils@sourceware.org, gdb-patches@sourceware.org In-Reply-To: <1484051178-16013-3-git-send-email-yao.qi@linaro.org> References: <1484051178-16013-1-git-send-email-yao.qi@linaro.org> <1484051178-16013-3-git-send-email-yao.qi@linaro.org> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.3 X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00198.txt.bz2 On 2017-01-10 07:26, Yao Qi wrote: > diff --git a/gdb/mep-tdep.c b/gdb/mep-tdep.c > index 68b0c4b..7d04983 100644 > --- a/gdb/mep-tdep.c > +++ b/gdb/mep-tdep.c > @@ -1273,6 +1273,7 @@ mep_gdb_print_insn (bfd_vma pc, disassemble_info > * info) > { > struct obj_section * s = find_pc_section (pc); > > + info->arch = bfd_arch_mep; > if (s) > { > /* The libopcodes disassembly code uses the section to find the > @@ -1280,12 +1281,9 @@ mep_gdb_print_insn (bfd_vma pc, disassemble_info > * info) > the me_module index, and the me_module index to select the > right instructions to print. */ > info->section = s->the_bfd_section; > - info->arch = bfd_arch_mep; > - > - return print_insn_mep (pc, info); > } > - > - return 0; > + > + return print_insn_mep (pc, info); > } > > Does the comment above mep_gdb_print_insn need to be changed? /* The mep disassembler needs to know about the section in order to work correctly. */