From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id IXgsNg/gvmjsfDgAWB0awg (envelope-from ) for ; Mon, 08 Sep 2025 09:54:23 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=jZrI1R8/; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=TXDTtv8w; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=jZrI1R8/; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=TXDTtv8w; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D996D1E0BA; Mon, 08 Sep 2025 09:54:23 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B447C1E04C for ; Mon, 08 Sep 2025 09:54:22 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 599083858413 for ; Mon, 8 Sep 2025 13:54:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 599083858413 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=jZrI1R8/; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=TXDTtv8w; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=jZrI1R8/; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=TXDTtv8w Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 704F83858D39 for ; Mon, 8 Sep 2025 13:48:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 704F83858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 704F83858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757339293; cv=none; b=rGwrb5siz+gRAjMvcQcRyyjH8UgdXBCk2OhPITbnuhqNVcLfWuY958njmPt1XrQqaa+1nEOOWtGu7wBhtNJ6/F2hm0YoIyC0ueH6gCdf2W375Kuwce2ulus6odAjrP7CwW5mhMXW6W0As2XO5IVrNoOMT/GeCxchOLLlivVH8K4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757339293; c=relaxed/simple; bh=YDFe+rp2rFw/VajVvzqGnfzS5TwENnJyORpeZkYKMJw=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=ZdDBh4IGu0OE6Ms1gosRawY7OHUCCyGxb1Qwkq4cXbcE4OkQuNN/vFFXr+H+t082QYjkaIqNTABpC+z9sHaA222Pe3c1Q5IPEGGNSe7Lanw4yAx/s6IRcuHx0u2cp60z9Yn4mCqGNIpAGL3DlIRnBsacyIbPJCnzJoOwHc+b6BU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 704F83858D39 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 390A724712; Mon, 8 Sep 2025 13:48:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1757339291; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kWIMVhJ2ah24CWcrCtT6cn4HHl6m++kcjJqJdxpGzlc=; b=jZrI1R8/eSXx64Gw5gENYBQV/Mq6vfLkRVsz3gn0d0MgR/cTnS+7FkTv/cIxxCBk1uqZM6 F4EELS/dsF6hALksg11iKPh/dI0/gQUclC8djr47IJLJAaTvq1AChpBr9T9GZ712Lc9J5b 7gcCQRSsEJjdchmfPkxS9D5mRm38VGM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1757339291; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kWIMVhJ2ah24CWcrCtT6cn4HHl6m++kcjJqJdxpGzlc=; b=TXDTtv8w30vFHOZC2Wf5smYIWxCHOkxuL4FXYNm5Z9mN915XxMYL8LPCadbdguLcuL1b7O yfClMf60Pp3emIAA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="jZrI1R8/"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=TXDTtv8w DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1757339291; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kWIMVhJ2ah24CWcrCtT6cn4HHl6m++kcjJqJdxpGzlc=; b=jZrI1R8/eSXx64Gw5gENYBQV/Mq6vfLkRVsz3gn0d0MgR/cTnS+7FkTv/cIxxCBk1uqZM6 F4EELS/dsF6hALksg11iKPh/dI0/gQUclC8djr47IJLJAaTvq1AChpBr9T9GZ712Lc9J5b 7gcCQRSsEJjdchmfPkxS9D5mRm38VGM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1757339291; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kWIMVhJ2ah24CWcrCtT6cn4HHl6m++kcjJqJdxpGzlc=; b=TXDTtv8w30vFHOZC2Wf5smYIWxCHOkxuL4FXYNm5Z9mN915XxMYL8LPCadbdguLcuL1b7O yfClMf60Pp3emIAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0ACCE13869; Mon, 8 Sep 2025 13:48:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id g7oOAJvevmiqPgAAD6G6ig (envelope-from ); Mon, 08 Sep 2025 13:48:10 +0000 Message-ID: Date: Mon, 8 Sep 2025 15:48:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PUSHED] gdb/testsuite: small fix for amd64-extended-prologue-analysis.exp To: Andrew Burgess , gdb-patches@sourceware.org References: <8735dae5139ecf2d3a79508371c9c861fde12c44.1757323506.git.aburgess@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <8735dae5139ecf2d3a79508371c9c861fde12c44.1757323506.git.aburgess@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 390A724712 X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid]; URIBL_BLOCKED(0.00)[suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/8/25 11:25, Andrew Burgess wrote: > I noticed I was sometimes getting this failure: > > FAIL: gdb.arch/amd64-extended-prologue-analysis.exp: offset \ > initialization: ASM source: gdb_breakpoint: set breakpoint \ > at *0x0000000000401151 > > The problem was introduced in commit: > > commit f9aa48dc545ef511e19f4dfab88a196b820fd2da > Date: Thu Aug 28 11:50:13 2025 +0000 > > gdb, amd64: extend the amd64 prologue analyzer to skip register pushes > > A gdb_test_multiple exits early when processing the results of a > 'disassemble' command, without waiting for the prompt to be seen. > This can leave unhandled output in expect's input buffer, which will > then throw off the next test. > > Update the gdb_test_multiple to wait for the prompt before declaring > the test passed. > > After this I'm no longer seeing the above failure. > Hi Andrew, thanks for fixing this. I've managed to reproduce the problem reliably using check-read1, and verified that the patch fixes it. Thanks, - Tom > There should be no change in what is tested after this commit. > --- > .../gdb.arch/amd64-extended-prologue-analysis.exp | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/gdb/testsuite/gdb.arch/amd64-extended-prologue-analysis.exp b/gdb/testsuite/gdb.arch/amd64-extended-prologue-analysis.exp > index b2fcbe66034..356afc7e668 100644 > --- a/gdb/testsuite/gdb.arch/amd64-extended-prologue-analysis.exp > +++ b/gdb/testsuite/gdb.arch/amd64-extended-prologue-analysis.exp > @@ -59,9 +59,13 @@ proc offset_test_run {} { > > set addr_past_prologue "null" > gdb_test_multiple "disassemble" "Disassemble foo" -lbl { > - -re "($::hex) <\\+($::decimal)>:\\s*mov.*" { > + -re "\r\n\\s*($::hex) <\\+($::decimal)>:\\s*mov.*(?=\r\n)" { > set addr_past_prologue $expect_out(1,string) > - pass $gdb_test_name > + exp_continue > + } > + > + -re -wrap "" { > + gdb_assert { $addr_past_prologue ne "null" } $gdb_test_name > } > } > > > base-commit: 5d0ac9ee8fd007e90ba3fef3b95fd756cc191401