From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 71RxHjHH62K5lyAAWB0awg (envelope-from ) for ; Thu, 04 Aug 2022 09:18:41 -0400 Received: by simark.ca (Postfix, from userid 112) id 6AF7E1EA05; Thu, 4 Aug 2022 09:18:41 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=CsHGiBrV; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id ECCC31E9EB for ; Thu, 4 Aug 2022 09:18:40 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B939138582AE for ; Thu, 4 Aug 2022 13:18:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B939138582AE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1659619117; bh=7VhSWeiVHAxprNAsqFx+nZvxaFL2BKoVfeYEWwPQtsE=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=CsHGiBrV05JebQjhO9q09QZUyTERNa5qjGMaYz974SVoKwq6WFZRdZld4vm1kG7QC KVwR6rmkCnEYyTf68pW2HBCvkglMeRI8/iDy2HzETgDD371dkEoDH+IS5LPPMSXgZ+ 83y8LFcAUn6oueEQOXmW8Zn6JhfNuJA+AAG3HzQg= Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2056.outbound.protection.outlook.com [40.107.21.56]) by sourceware.org (Postfix) with ESMTPS id 087A63858407 for ; Thu, 4 Aug 2022 13:18:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 087A63858407 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=iELBsYlvhc5nEHwO5n8M4Ol2frL8TtlhMLRgYxi8Xa8So2TvwuoH6teGfn9urU07AdVJ+3NtcOT2XmY27I0liX74wZXt45oHktwOA67UBWwxpkj4jE5NW8+2SHXU+qdTWVWMi/iUxsKJ0B4PSHOEysX1I/i41skFsFYNAOij589qPRpS2ltSU/9oEOv8WvgcpfMajnI+jdiUXBCjRgojXF2ObVeqbf8hFKX2Cgw9K6Lko3Ae5GT3KN2YocRpGalVDtYGPN9OBpAvMv1YgK2jAhZZ016hMiW7Ua1Efpx91t1IOviRtZIh1Jepi4fwmpMSt/BFsQ0AXeFF+MDrcPDBOg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7VhSWeiVHAxprNAsqFx+nZvxaFL2BKoVfeYEWwPQtsE=; b=ln41lM0p8OMV7GxI1MX9S/LW04fG5J18wEU+d9UzHIxHy6n0eaxFEdwCJXTS1u7xnGjN/jSPdwEOoProCAofniZaAnHS0yRQd2KkUVR6yghixzMplXzDJqEfyaCw4xF7wDNk/UUhdmb+jS3RXx4tVfkIMkqLlxE4CFxHp1ckgRikbrT6pz13lzzPN1iEkroboIhSWz86JIcK0s/6M+IvH+gZ1CRyyG3oNMjsOsQ7rQqV3mX6nLZME8miXXKSntiltDBvt/pGSoAlYGrULGYmsKAe5npA2wVI96pac60CWYGrS4IZFPzZ+NetUbmbER/DQzR613EN3oTuCsQM4rjgIA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AS9PR04CA0104.eurprd04.prod.outlook.com (2603:10a6:20b:50e::17) by HE1PR0802MB2300.eurprd08.prod.outlook.com (2603:10a6:3:c5::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.15; Thu, 4 Aug 2022 13:18:13 +0000 Received: from VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:50e:cafe::ca) by AS9PR04CA0104.outlook.office365.com (2603:10a6:20b:50e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.15 via Frontend Transport; Thu, 4 Aug 2022 13:18:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT009.mail.protection.outlook.com (10.152.18.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14 via Frontend Transport; Thu, 4 Aug 2022 13:18:13 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Thu, 04 Aug 2022 13:18:12 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 61634e473020adf1 X-CR-MTA-TID: 64aa7808 Received: from 33703fb11bbf.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8C0E068D-AE05-4150-AC8D-9AAD7C304DC3.1; Thu, 04 Aug 2022 13:18:05 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 33703fb11bbf.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 04 Aug 2022 13:18:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h+nedfs0T9ZvtXgA8tfFFKwr+qmVLEzikODn5CgwECx+WYblevBj7P0/AqH6bl+yjkGV0ddFB1mBgWb+U6rGWfHPjmDP0GkC9qmBNBvGVb3h321ajSs36hcFIRQqmwTPZ2UZhTjIym48ZR+n/lO4MvfNhhrPJmQCFZ9snGRzL06y8ADVQCfrzx6uBMOJWHJiUqpLuzQAADL0+TpkIb4ldGV+RY9VtDwSq8hrKXuwy421xF2avV8CuOwNBOZun33uzZt5NUXpyoUA6bi/AIVSMLqk0t87Yak8D2wSLmVBqtgB7oS98fzI3fSZio9fc2/V7Bztd/YQjNHX/1wOVywJwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7VhSWeiVHAxprNAsqFx+nZvxaFL2BKoVfeYEWwPQtsE=; b=T4fLQyofkBWUYaJgcGidFzx85D8UAY4pK/NiMz4Vb2CzlODH2SbySC8FSgbeIc/X1HzrYxQisjXP3Id5i53+V/kR050PDS5+nTAti0efzMEC57QbW613VC8Diws0HsSE7G8OY2aBlu2Bbeld775jpgcMhm8tHutxGaqnHVtvfoL5mj04lexmL0dxRK8fsp7lYdetoWpOeApOIoTJXAWwNQDfzarCjr1ryUVhiDDHLyr8KZloiQrCl9yv3vlZ3eO1rJbpxqfzvOEPqqi73YmrhpAGcs8CaqhFP/7hyIZ3V7atxAh/9PIIOP0tcxhyT23rj39zMS5hNbKyawf1H+S+ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by DU0PR08MB8977.eurprd08.prod.outlook.com (2603:10a6:10:465::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.15; Thu, 4 Aug 2022 13:17:54 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::cc64:9170:b12d:de8]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::cc64:9170:b12d:de8%4]) with mapi id 15.20.5504.014; Thu, 4 Aug 2022 13:17:54 +0000 Message-ID: Date: Thu, 4 Aug 2022 14:17:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH][gdb/tdep] Fix gdb.base/large-frame.exp for aarch64 Content-Language: en-US To: Tom de Vries , gdb-patches@sourceware.org References: <20220804130419.GA25032@delia> In-Reply-To: <20220804130419.GA25032@delia> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN4PR0501CA0020.namprd05.prod.outlook.com (2603:10b6:803:40::33) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 90807ff3-048e-47e0-d657-08da761bc8e6 X-MS-TrafficTypeDiagnostic: DU0PR08MB8977:EE_|VE1EUR03FT009:EE_|HE1PR0802MB2300:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 4M1+yWUX9KKxRgFU+pOjs8aVMNxmlVjV7N2qgCCYIHgVZSDY9Y983EFRHtZ/edCx/nrZyRPKPthUUAPteE/4ftlKsENE+qYKD2XE3ZAHSDKovPca28wzC+TrdBbi38Y8b0IOp5oswlIATCRRR3aX5HM3covx1IcCZHFdzz68wjTXS08ezPpyfYkGpANiywz2g6kd9qMEZ9rz0yjNHQgM39CnfBVFyn5fG/X8CPrUVmI1jT9dy7nVKJWmYRrCyp/5lGZTpDDLJEMBjCB44f7q23XrTaFgQ1YPIH0ateTM9LHO/X5GVzQJQ8UxBMApHsNHysCzfXwNd0k1IOy/Zgtf1BibSS6998mSS50Dnt4ia9B4mw/Sq3+P4Kx58qLKtFQ+H/PrNzEl35d3YqKy74bY1zpNKouw96pPxEFDA6wK46sSkWDmlGQ03lqppAQxcZW2VG4y7mgrUhrudvKmRqLX/Y4pQ/I2qhxRf3mqUFtF4yemrFKzkbcoi3F0Ku+ciICn8iWgHL75ZbLmHUNu74vF33msgWGs+hrSXdhA+yLEZX4o6bLVVg3tYSAQfgyOsUyUwSNfH8C4wx9n4caREiE9zRDwrkKzZTp3lg+7PvlJH/avu3bO2gZfg4MW3gDEJVWw4v0Z786Aoe8gavgmFXg5QkC/dd8kMjGjIFWk4S7uKsa9QslyADQUz03va6CG0iKnflFNsPmoOjReZY2idgdnwoiLItPwZblBUVTbE7iO9MUv5mkllRjjss/8a3CARM9obxbJc0zzUWE1XvbB8rzbmgC562rVjnZTei8ZfoFXm0DjuZ4IL/MKAH12urEMgIadIcN/LTDHpWTKtxJ9mKdgcu9sIgg6CkLFUffZdV+hnyG9wv6URJswzeOpgs5B6UGzDKzqAqPUFpgT3ysYEM45aw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(376002)(366004)(396003)(136003)(39860400002)(346002)(966005)(6486002)(5660300002)(478600001)(44832011)(8936002)(316002)(66556008)(66946007)(66476007)(31686004)(36756003)(8676002)(41300700001)(6666004)(2906002)(84970400001)(2616005)(26005)(6512007)(186003)(53546011)(6506007)(83380400001)(38100700002)(31696002)(86362001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8977 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: be379791-db5c-4b00-d605-08da761bbdba X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PyEpL+uCihAY+oQSncdvaayKhupqVmWwJXb2WW/bL+HPpzAn16mIQRhMO5j2UbW/FDdld/ks/uWpTWkvFoVLdJtPlBTTUtBLpRvVE3a4O5T8XSuOxJDfMLd6aJIiu7KcaKupbVy2nO0SxFHxP9wF/OnkJeoB5y7sLk9FYGaVa7OkUdncWn7877YDNvglAdxXKI/XqOS7pAZerp9H6DscTyWqAdicH5XD5NNEeJcByrnhIMujVJfBW0BCYZtfb50OzhliE/NyGCl6c7xqrqQ9yudFm+Z/X5l+zACqPF3HeTCOKXQ+0NiITcwNLfRAlIkNyrRO1yzVnyybgKuHQ0KX8CjA+Ort4F6pQj46+Iqmgkv+M51snA15bdqVtY9vkdBD0QAwKXXstDmPe9/m6ERMHmeBcj0XrOGrYHrPAdAjo2GFGiCnp20qC0BzFTbyb7znh2AIcX0oKs4Ba0icvFE/RAN6pdYhJpivtMGQ7BS9hrogsdKrGHhVvdwmGKEjQEPi5rfYs6EPb9FCum6Ysz+dExY3u4JJuODBF21trPF/Fzk6n+bJZseqReo50M9qsdVt8ifBbqn4ncxrqjQ/Xnndp+iFK4Xjax4KQpee69YbM5Y/1L/1p6CiZx7diXdey90u6pq695baJ9ZQQRpOOTVBCsSGXYhb5F/8Ekaak5R+lOU4t8SJpWDfEofQZdnKyUedBlSJa3jBDmh1GOMeEQKzuigLkdrZ+AFB5dhRhgBIj7CuwC4VJRRkaGMArJ4uLr6Rw8t19Lm6KINjdKdhIIbXtPwy7wUlHC1xKF5m2U2KnsjUJH94tdASw2dHeEoT4lkemKv81upLV2+9kucsqCVHe5irrtSjeFZOaPL+9hXnQBaOY5hIKx1/nHIlByMl7TbpSJTWrEmlg/JgBrV0V6IIkg== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(396003)(39860400002)(376002)(136003)(346002)(36840700001)(40470700004)(46966006)(40460700003)(82740400003)(47076005)(336012)(186003)(2616005)(83380400001)(2906002)(84970400001)(36756003)(31686004)(5660300002)(44832011)(36860700001)(6486002)(966005)(478600001)(82310400005)(8936002)(40480700001)(356005)(316002)(86362001)(81166007)(6512007)(6506007)(53546011)(70586007)(26005)(41300700001)(6666004)(31696002)(8676002)(70206006)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2022 13:18:13.2018 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 90807ff3-048e-47e0-d657-08da761bc8e6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2300 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi, Thanks for the patch. I was giving this a try before replying. On 8/4/22 14:04, Tom de Vries wrote: > Hi, > > On aarch64, I run into: > ... > FAIL: gdb.base/large-frame.exp: optimize=-O0: backtrace > ... > > The problem is that the architecture-specific prologue analyzer fails to > handle the first two insns in the prologue properly: > ... > 0000000000400610 : > 400610: d2880210 mov x16, #0x4010 > 400614: cb3063ff sub sp, sp, x16 > 400618: a9007bfd stp x29, x30, [sp] > 40061c: 910003fd mov x29, sp > 400620: 910043a0 add x0, x29, #0x10 > 400624: 97fffff0 bl 4005e4 > ... > so we get: > ... > $ gdb -q -batch ./outputs/gdb.base/large-frame/large-frame-O0 -ex "b func" > Breakpoint 1 at 0x400614 > ... > > Fix this by: > - fixing the support for the first insn to extract the immediate operand, and > - adding support for the second insn, > such that we have: > ... > Breakpoint 1 at 0x400624 > ... > Note that we're overshooting by one insn (0x400620 is the first insn after the > prologue), but that's a pre-existing problem. > > Tested on aarch64-linux. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29408 > > Any comments? > > Thanks, > - Tom > > [gdb/tdep] Fix gdb.base/large-frame.exp for aarch64 > > --- > gdb/aarch64-tdep.c | 22 +++++++++++++++++++++- > 1 file changed, 21 insertions(+), 1 deletion(-) > > diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c > index 8670197a888..f747ebda1ab 100644 > --- a/gdb/aarch64-tdep.c > +++ b/gdb/aarch64-tdep.c > @@ -340,6 +340,20 @@ aarch64_analyze_prologue (struct gdbarch *gdbarch, > if (rn == AARCH64_SP_REGNUM && rd == AARCH64_FP_REGNUM) > seen_stack_set = true; > } > + else if (inst.opcode->iclass == addsub_ext > + && strcmp ("sub", inst.opcode->name) == 0) > + { > + unsigned rd = inst.operands[0].reg.regno; > + unsigned rn = inst.operands[1].reg.regno; > + unsigned rm = inst.operands[2].reg.regno; > + > + gdb_assert (aarch64_num_of_operands (inst.opcode) == 3); > + gdb_assert (inst.operands[0].type == AARCH64_OPND_Rd_SP); > + gdb_assert (inst.operands[1].type == AARCH64_OPND_Rn_SP); > + gdb_assert (inst.operands[2].type == AARCH64_OPND_Rm_EXT); > + > + regs[rd] = pv_subtract (regs[rn], regs[rm]); > + } > else if (inst.opcode->iclass == pcreladdr > && inst.operands[1].type == AARCH64_OPND_ADDR_ADRP) > { > @@ -370,14 +384,20 @@ aarch64_analyze_prologue (struct gdbarch *gdbarch, > } > else if (inst.opcode->op == OP_MOVZ) > { > + unsigned rd = inst.operands[0].reg.regno; > + > + gdb_assert (aarch64_num_of_operands (inst.opcode) == 2); > gdb_assert (inst.operands[0].type == AARCH64_OPND_Rd); > + gdb_assert (inst.operands[1].type == AARCH64_OPND_HALF); > + gdb_assert (inst.operands[1].shifter.kind == AARCH64_MOD_LSL); > > /* If this shows up before we set the stack, keep going. Otherwise > stop the analysis. */ > if (seen_stack_set) > break; > > - regs[inst.operands[0].reg.regno] = pv_unknown (); > + regs[rd] = pv_constant (inst.operands[1].imm.value > + << inst.operands[1].shifter.amount); > } > else if (inst.opcode->iclass == log_shift > && strcmp (inst.opcode->name, "orr") == 0) This looks good to me. Thanks for getting this fixed.