Re: [PATCH 2/3] [delete] Not-so-harmless spurious call to `wait4`

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

On 2021-04-08 3:14 p.m., Dominique Quatravaux via Gdb-patches wrote:
> As seen in https://sourceware.org/bugzilla/show_bug.cgi?id=24069

Hi Dominique,

We try to make the git commit messages somewhat self-contained, so that
it's possible to understand the change even if bugzilla becomes
inaccessible.  Can you please explain in the commit message what harm
that wait4 call does and why we want to remove it?

It's still a good idea to link to the Bugzilla entry, if people want to
dig more.

Thanks,

Simon

> ---
>  gdb/darwin-nat.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/gdb/darwin-nat.c b/gdb/darwin-nat.c
> index 3ec881d3a76..9c6423ceb02 100644
> --- a/gdb/darwin-nat.c
> +++ b/gdb/darwin-nat.c
> @@ -1106,9 +1106,6 @@ darwin_nat_target::decode_message (mach_msg_header_t *hdr,
>  	      inferior_debug (4, _("darwin_wait: pid=%d exit, status=0x%x\n"),
>  			      res_pid, wstatus);
>  
> -	      /* Looks necessary on Leopard and harmless...  */
> -	      wait4 (inf->pid, &wstatus, 0, NULL);
> -
>  	      return ptid_t (inf->pid);
>  	    }
>  	  else
>