From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id dURuFCSo4F/8VgAAWB0awg (envelope-from ) for ; Mon, 21 Dec 2020 08:50:28 -0500 Received: by simark.ca (Postfix, from userid 112) id 4837D1F0AA; Mon, 21 Dec 2020 08:50:28 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F19211E965 for ; Mon, 21 Dec 2020 08:50:25 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 83BDC384A02A; Mon, 21 Dec 2020 13:50:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 83BDC384A02A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1608558625; bh=/9JpddON9TLu0FxGGyNfCBWfLfFVg29saZGuKPrwlog=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=S8FAJRfJureTN1w3Q6kLZeXgPuZYnFfxj2DNmiXzxW+p+CtmBdx+LLu5dEE2COLBC r3oWQ3U1CQAFQsSUP4FpwY9bpKO8XJ2+WaWoGoRTuPC3XVzgsfhyQO0xEoDV0YmtlH WLS8fT2sWAv8PF56XTUJ4kPu3YRbm4emUSxEFzGg= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id C6B623857815 for ; Mon, 21 Dec 2020 13:50:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C6B623857815 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 0BLDo5kw007842 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 21 Dec 2020 08:50:10 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 0BLDo5kw007842 Received: from [10.0.0.213] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 524711E965; Mon, 21 Dec 2020 08:50:05 -0500 (EST) Subject: Re: [PATCH 3/4] testsuite, gdb.btrace: skip multi-inferior.exp on gdbserver targets To: "Metzger, Markus T" , "gdb-patches@sourceware.org" References: <20201217151212.1179058-1-markus.t.metzger@intel.com> <20201217151212.1179058-4-markus.t.metzger@intel.com> <285009da-86dc-2075-f7c8-61378948083b@polymtl.ca> Message-ID: Date: Mon, 21 Dec 2020 08:50:04 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 21 Dec 2020 13:50:05 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-12-21 2:27 a.m., Metzger, Markus T wrote: > Hello Simon, > > Thanks for your review. > >>> --- a/gdb/testsuite/gdb.btrace/multi-inferior.exp >>> +++ b/gdb/testsuite/gdb.btrace/multi-inferior.exp >>> @@ -27,6 +27,13 @@ if { [skip_btrace_tests] } { >>> return -1 >>> } >>> >>> +# This test creates multiple inferiors. This won't work with all >>> +# gdbserver board files. >> >> The comment sounds a bit confusing. It may be interpreted as "this test >> doesn't work with any gdbserver board files", but you mean "this test works >> with some gdbserver board files but not all". >> >> I think just saying "Test test creates multiple inferiors." is enough to >> explain the [use_gdb_stub] check. Stub configurations can't spawn inferiors. > > I removed the comment altogether given that it now merely duplicates the code. > > >> Although I think it wouldn't hurt to improve the documentation of the >> use_gdb_stub procedure to explain what it means, as it's a pretty opaque >> concept if you don't already know it. > > How about this [1]? I'll send a separate patch for it. > > Regards, > Markus. > > [1] > --- > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index e812237d67a..21c822f26a6 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -3589,6 +3589,9 @@ proc gdb_is_target_native { } { > # This is the preferred way of checking use_gdb_stub, since it allows to check > # the value before the gdb has been spawned and it will return the correct value > # even when it was overriden by the test. > +# > +# Note that stub targets are not able to spawn new inferiors. Use this > +# check for skipping respective tests. That's good, thanks. Simon