From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 1HH8OBXCWGB+IAAAWB0awg (envelope-from ) for ; Mon, 22 Mar 2021 12:13:09 -0400 Received: by simark.ca (Postfix, from userid 112) id DD3901EF78; Mon, 22 Mar 2021 12:13:09 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2E2DF1E789 for ; Mon, 22 Mar 2021 12:13:09 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 48132385E445; Mon, 22 Mar 2021 16:13:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 48132385E445 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1616429588; bh=t7bS6GhDsDcLflAe9zG3oUshYE32oJceUYnc5d4Neso=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=kq2bEW/hyx+ml35r8trlDmbjUdpn9BlE+088ayyX8HnRCA3uQfO7DQewAvcVGOg6w stK3GZkh8SyPRooG1lLp69EfGx9YhmPfgeRgOaridVWeb8W0m7ETjkVp85ZsSH6PM+ GQtuWPHqbOm2iPdiSkAduFqkvW42GNKQM2XDXz4Y= Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) by sourceware.org (Postfix) with ESMTPS id 168883858004 for ; Mon, 22 Mar 2021 16:13:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 168883858004 Received: by mail-qv1-xf34.google.com with SMTP id o19so8958905qvu.0 for ; Mon, 22 Mar 2021 09:13:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=t7bS6GhDsDcLflAe9zG3oUshYE32oJceUYnc5d4Neso=; b=P5rsjdtZjjUt0Lou1pDqrEB6Dlf239fdX2pwjpvdPQta3o1DoWXKs0d97IKJaIn7Nd e2sltIka4iiWuH1xpKIryLBZmD5jTcxvsTYOPdxz1ugVA4JteLhbrxqYfuJT8/kI8T/r zU6a2YfFzYsF4GXy72K7Gl9XSRejx6OjzWHcE3zjqm2CYDMYeg8WPaOtuJjf8hIGvF/e neGalXon6H9D32hGNF5s2GrAG9v6sftZeOcIDMyNDWgR9W7FyOMvg5/wlLeSVZDoMmpB cqW0cA5uEVRSyQXCY9m+61J3SVG+/CS3bgbZH0TxtxfQ30RWf87KMUBMo3MPNUgOKFcI 9CTA== X-Gm-Message-State: AOAM531peXkXJCM+xJERYlyDbj0rmFzsUIdlK9vcFElB+UYc2Qvz6r/x eGgcy+IsA2SePNThWdkAnwSMY+cwWkk54w== X-Google-Smtp-Source: ABdhPJwDLu0CvTwDY4T4NV2XRMag6vQwA4j6XDLBS4BZUs2RSEgNtz+hCbFqNoTz4foo3k+Ap33LIA== X-Received: by 2002:a0c:bdaf:: with SMTP id n47mr350417qvg.48.1616429584078; Mon, 22 Mar 2021 09:13:04 -0700 (PDT) Received: from ?IPv6:2804:7f0:4841:2841:2c21:ec8a:30f3:55a6? ([2804:7f0:4841:2841:2c21:ec8a:30f3:55a6]) by smtp.gmail.com with ESMTPSA id f8sm11231048qkk.23.2021.03.22.09.13.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Mar 2021 09:13:03 -0700 (PDT) Subject: Re: [PATCH] Add startswith function and use it instead of CONST_STRNEQ. To: Alan Modra , Tom Tromey , Mike Frysinger References: <4d8880dd-4a83-f0fc-dafd-2079493d4093@suse.cz> <20210319063759.GM6791@bubble.grove.modra.org> <20210320070037.GR6791@bubble.grove.modra.org> <87wnu1k5z1.fsf@tromey.com> <20210321131254.GS6791@bubble.grove.modra.org> <87k0q0j5ql.fsf@tromey.com> <20210322120652.GV6791@bubble.grove.modra.org> Message-ID: Date: Mon, 22 Mar 2021 13:13:00 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210322120652.GV6791@bubble.grove.modra.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Cc: Alan Modra via Binutils , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 3/22/21 9:06 AM, Alan Modra via Gdb-patches wrote: > On Sun, Mar 21, 2021 at 08:13:06PM -0600, Tom Tromey wrote: >> Alan> Yes, the following compiles. Fortunately all gdb files that include >> Alan> gdbsupport/common-utils.h also include bfd.h by one means or another. >> >> Sorry, I misunderstood. I thought the proposal was to put the >> function in ansidecl.h. >> >> gdbserver can't generally include bfd. Maybe it works sometimes, but I >> imagine if you do a gdbserver-only build, bfd.h won't even be created. >> (At least, it shouldn't be, because gdbserver doesn't require bfd.) >> >> So I think some other approach is needed. Either ansidecl.h, or a new >> header; or rename either the BFD or GDB function and go from there. > > A new header would be best, I think. > >> I'm happy to implement it if you like. > > Yes, that way you'll get it done properly. :) Sorry for the breakage. > Just FTR, I'm seeing breakage in sim/aarch64 and sim/arm. Both are complaining about "-Werror=implicit-function-declaration" regarding strncmp and strlen. Is this the breakage you're talking about? Just so I know what to expect when it gets fixed.