From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69947 invoked by alias); 12 Apr 2017 14:07:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69478 invoked by uid 89); 12 Apr 2017 14:07:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy= X-HELO: mail-wr0-f173.google.com Received: from mail-wr0-f173.google.com (HELO mail-wr0-f173.google.com) (209.85.128.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Apr 2017 14:07:05 +0000 Received: by mail-wr0-f173.google.com with SMTP id c55so18231351wrc.3 for ; Wed, 12 Apr 2017 07:07:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=1cCzXGyYspNlNsReZjdyaneGQxshFTl02juDOYlRwL4=; b=CBYrO8XXSZsmF2s4LE0oykqUcYwnQHdErKcj4v7JBIev8aPyp6vfUyY0q2a/NfYDQ4 x3PoI7ab/kvS0XgigqHyaKmkkCOjuPiJAyBfOhnj5Jg9lzhbaM1JrnOouR+ywjkZjzxN Atb+ycGHFTYgHfi/oTT6ANAVDms2f1SJGxyVqWCBI9+glJgwSBwOSYCV7N/gnSJGTufv kbIWF8K/QcFIw12XGhfIvNpJPitOVG+9XFYesE8bUnad2NJxYcF2XJtVWRFqWwAC44Mm +yoGU8j9uCiN6yHiEObgEVFhlnZ0MCTqre8oKk8LeVVuyegT9JEgZQhRHJQLuG+E6SBK 1Ttw== X-Gm-Message-State: AN3rC/4BssqHm3OLg2u4luvvFApDEaQbGm6uBXWtB/7wqPRbg1mqQy68nIII33f+/3ZTQjDJ X-Received: by 10.223.175.211 with SMTP id y19mr3210471wrd.77.1492006024482; Wed, 12 Apr 2017 07:07:04 -0700 (PDT) Received: from [192.168.0.101] ([37.189.166.198]) by smtp.gmail.com with ESMTPSA id g11sm10880516wrd.11.2017.04.12.07.07.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Apr 2017 07:07:03 -0700 (PDT) Subject: Re: [PATCH] gdb: Move DJGPP/go32 bits to their own tdep file To: Eli Zaretskii References: <1492003875-25394-1-git-send-email-palves@redhat.com> <83bms1ka9s.fsf@gnu.org> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Wed, 12 Apr 2017 14:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <83bms1ka9s.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00332.txt.bz2 On 04/12/2017 02:47 PM, Eli Zaretskii wrote: >> From: Pedro Alves >> Cc: Eli Zaretskii >> Date: Wed, 12 Apr 2017 14:31:15 +0100 >> >> I posit that this makes them easier to find. >> >> The other day while working on the wchar_t patch, I had a bit of >> trouble finding the DJGPP/go32 tdep bits. My initial reaction was >> looking for a go32-specific tdep file, but there's none. > > Thanks, but why single out go32? Because incremental progress. > The comment in i386-tdep.c says: > > /* There are a few i386 architecture variants that differ only > slightly from the generic i386 target. For now, we don't give them > their own source file, but include them here. As a consequence, > they'll always be included. */ > > If we are going to have a separate tdep file for such architectures, > let's do it for SVR4 as well. That can be done, but I don't see why it has to be in the same patch? > P.S. How come functions and other symbols are looked for via file > names, and not via TAGS? > I don't know. Thanks, Pedro Alves