From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12351 invoked by alias); 23 May 2014 09:47:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12254 invoked by uid 89); 23 May 2014 09:46:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: na01-bl2-obe.outbound.protection.outlook.com Received: from mail-bl2lp0210.outbound.protection.outlook.com (HELO na01-bl2-obe.outbound.protection.outlook.com) (207.46.163.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 23 May 2014 09:46:56 +0000 Received: from BL2FFO11FD051.protection.gbl (10.173.160.32) by BL2FFO11HUB048.protection.gbl (10.173.161.124) with Microsoft SMTP Server (TLS) id 15.0.949.9; Fri, 23 May 2014 09:46:40 +0000 Received: from xsj-gw1 (149.199.60.83) by BL2FFO11FD051.mail.protection.outlook.com (10.173.161.213) with Microsoft SMTP Server id 15.0.949.9 via Frontend Transport; Fri, 23 May 2014 09:46:40 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-smtp1) by xsj-gw1 with esmtp (Exim 4.63) (envelope-from ) id 1Wnm3j-0000jH-P5; Fri, 23 May 2014 02:46:39 -0700 From: Ajit Kumar Agarwal To: Michael Eager , "gdb-patches@sourceware.org" CC: Joel Brobecker , Vinod Kathail , Vidhumouli Hunsigida , Nagaraju Mekala Subject: RE: [Patch, microblaze]: Add slr and shr regs Date: Fri, 23 May 2014 09:47:00 -0000 References: <537EFA08.1060309@eagercon.com> In-Reply-To: <537EFA08.1060309@eagercon.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-RCIS-Action: ALLOW Message-ID: X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(6009001)(438001)(189002)(199002)(24454002)(377424004)(479174003)(2656002)(20776003)(54356999)(76176999)(50986999)(79102001)(77982001)(76482001)(23676002)(50466002)(74662001)(21056001)(74502001)(64706001)(81342001)(31966008)(81542001)(46102001)(4396001)(19580395003)(70736001)(53416003)(19580405001)(83322001)(80022001)(44976005)(83072002)(85852003)(86362001)(92566001)(74316001)(33646001)(31696002)(92726001)(87936001)(23106003);DIR:OUT;SFP:;SCL:1;SRVR:BL2FFO11HUB048;H:xsj-gw1;FPR:;MLV:sfv;PTR:unknown-60-83.xilinx.com;MX:1;A:1;LANG:en; X-OriginatorOrg: xilinx.onmicrosoft.com X-Forefront-PRVS: 0220D4B98D Received-SPF: Pass (: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=; client-ip=149.199.60.83; helo=xsj-gw1; Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=ajit.kumar.agarwal@xilinx.com; X-SW-Source: 2014-05/txt/msg00585.txt.bz2 DQoNCk9uIDA1LzIyLzE0IDIzOjUzLCBBaml0IEt1bWFyIEFnYXJ3YWwgd3Jv dGU6DQo+ICAgIEhlbGxvIE1pY2hhZWw6DQo+DQo+ICAgIEJhc2VkIG9uIHRo ZSBmZWVkYmFjaywgcmVzdWJtaXR0aW5nIHRoZSBwYXRjaCBvbmNlIGFnYWlu IHdpdGggYWxsIHlvdXIgcmVwbGllcyBhbmQgc3VnZ2VzdGlvbnMuDQo+DQo+ ICAgICAgW1BhdGNoLCBtaWNyb2JsYXplXTogQWRkIHNsciBhbmQgc2hyIHJl Z3MNCj4NCj4gICAgICBUaGlzIHBhdGNoIGFkZCB0aGUgc3VwcG9ydCBvZiBz bHIgYW5kIHNociByZWdzIGFuZCBhbHNvIHNvbHZlcyB0aGUgcHJvYmxlbQ0K PiAgICAgIHJlbGF0ZWQgdG8gcHJvY2Vzc19nX3BhY2tldCB3aGVyZSB0aGUg YnVmX2xlbiA+IDIgKiByc2EtPnNpemVvZl9nX3BhY2tldA0KPiAgICAgIGFu ZCB0aHJvd2luZyB0aGUgRXJyb3IgdGhhdCAnZycgcGFja2V0IG1lc3NhZ2Ug cmVwbHkgaXMgdG9vIGxvbmcuIFRoaXMgaXMNCj4gICAgICBiZWNhdXNlIHRo ZSBidWZfbGVuIGNhbGN1bGF0ZWQgaW4gdGhlIGluaXRfcmVtb3RlX3N0YXRl IGZ1bmN0aW9uIGZvcg0KPiAgICAgIG1pY3JvYmxhemUgdGFyZ2V0IGlzIGJh c2VkIE9uIHRoZSBzaXplb2ZfZ19wYWNrZXQgYW5kIHJlbW90ZV9wYWNrZXRf c2l6ZQ0KPiAgICAgIGFuZCB0aGUgbWVtb3J5X3BhY2tldF9jb25maWctPnNp emUuIFRoZSBzaXplb2ZfZ19wYWNrZXQgaXMgMjM2IGJlY2F1c2UgdGhlDQo+ ICAgICAgbnVtYmVyIG9mIHJlZyBudW0gaXMgNTkgYW5kIDIqIHNpemVvZl9n X3BhY2tldCBjb21lcyB0byA0NzIgLldpdGggc2hyIGFuZA0KPiAgICAgIHNo bCBlbnRyeSBhbmQgdGhlIGJ1Zl9sZW4gaXMgNDcyLiBUaGlzIGRvZXMgbm90 IG1hdGNoIHRoZSBncmVhdGVyIHRoYW4NCj4gICAgICBjb25kaXRpb25hbCBz dGF0ZW1lbnQgIGFuZCB3b3JrcyBmaW5lLiBXaXRob3V0IHNociBhbmQgc2hs IGVudHJ5LHRoZQ0KPiAgICAgIHNpemVvZl9nX3BhY2tldHMgY29tZXMgdG8g NTcqNCAqMiA9IDQ1Ni4gIFRoaXMgZG9lc24ndCBtYXRjaCB0aGUgY3JpdGVy aWENCj4gICAgICBpbiB0aGUgcHJvY2Vzc19nX3BhY2tldCBmdW5jdGlvbiAg bGVhZGluZyB0byB0aHJvd2luZyBvZiBlcnJvciBtZXNzYWdlIGFzDQo+ICAg ICAgIiAnZycgcGFja2V0IG1lc3NhZ2UgcmVwbHkgaXMgdG9vIGxvbmciLg0K Pg0KPiAgICAgIENoYW5nZUxvZzoNCj4gICAgICAyMDE0LTA1LTIwIEFqaXQg QWdhcndhbCA8YWppdGt1bUB4aWxpbnguY29tPg0KPg0KPiAgICAgICAgICAq IGdkYi9nZGJzZXJ2ZXIvTWFrZWZpbGUuaW4gKG1pY3JvYmxhemUtbGludXgu Yyk6IE5ldyBydWxlLg0KPg0KPiAgICAgICAgICAqIGdkYi9taWNyb2JsYXpl LXRkZXAuYyAobWljcm9ibGF6ZV9yZWdpc3Rlcl9uYW1lcyk6IEFkZGVkDQo+ ICAgICAgICAgIHRoZSByc2hyIGFuZCByc2xyIHJlZ2lzdGVyIG5hbWVzLg0K Pg0KPiAgICAgICAgICAqIGdkYi9taWNyb2JsYXplLXRkZXAuaCAobWljcm9i bGF6ZV9yZWdfbnVtKTogQWRkaXRpb24gb2YNCj4gICAgICAgICAgZmllbGQg TUlDUk9CTEFaRV9TTFJfUkVHTlVNIGFuZCBNSUNST0JMQVpFX1NIUl9SRUdO VU0uDQo+ICAgICAgICAgIChtaWNyb2JsYXplX2ZyYW1lX2NhY2hlKTogQ2hh bmdlIGluIHRoZSBpbmRleCBvZg0KPiAgICAgICAgICByZWdpc3Rlcl9vZmZz ZXRzLg0KPg0KPiAgICAgICAgICAqIGdkYi9yZWdmb3JtYXRzL3JlZy1taWNy b2JsYXplLmRhdDogTmV3IFJlZ2lzdGVyIGRhdGEgZmlsZS4NCj4NCj4gICAg ICBTaWduZWQtb2ZmLWJ5OkFqaXQgQWdhcndhbCBhaml0a3VtQHhpbGlueC5j b20NCj4NCj4gSSBhbSBjb25mdXNlZCB3aXRoIHlvdXIgY29tbWVudHMgd2hl cmVhcyBpdCBzZWVtcyBJIGhhdmUgYW5zd2VyZWQgYWxsIHF1ZXJpZXMoaW5j bHVkaW5nIHlvdXJzKSBhbmQgaW5jb3Jwb3JhdGVkIHlvdXIgcmV2aWV3IGNv bW1lbnRzLg0KPiBKdXN0IHRvIG1ha2Ugc3VyZSBJIHJlcGVhdCwgc2VlIGJl bG93IGFuc3dlcnMgdG8geW91ciBxdWVyaWVzLg0KPg0KPj4+IE1ha2Ugc3Vy ZSB5b3UgYWRkcmVzcyBteSBjb21tZW50cyBhbmQgaW5jb3Jwb3JhdGUgbXkg c3VnZ2VzdGlvbnMgYXMgd2VsbC4NCj4NCj4gSSBtYWRlIHN1cmUgdGhhdCB0 aGUgZGVzY3JpcHRpb24gaXMgbm90IHRvbyBsb25nIGF0IHRoZSBzYW1lIHRp bWUgaXQgZ2l2ZXMgdGhlIGNvbXBsZXRlIHBpY3R1cmUuIEhvcGUgdGhpcyBh ZGRyZXNzZXMgeW91ciBjb21tZW50cy4NCj4NCj4+Pj4gSSBhc2tlZCB3aGF0 IGlzIHJ1bm5pbmcgb24gdGhlIHRhcmdldCB3aGljaCBpcyByZXR1cm5pbmcg YSBkaWZmZXJlbnQgc2l6ZWQgRyBwYWNrZXQuDQo+DQo+IEl0IGlzICB0aGUg Z2Ric2VydmVyIHdoaWNoIGlzIGNoZWNraW5nIGZvciB0aGUgYnVmX2xlbiBh bmQgMiogDQo+IHNpemVfb2ZfZ19wYWNrZXQgIGluIHByb2Nlc3NfZ19wYWNr ZXQgZnVuY3Rpb24gd2hpY2ggaXMgbm90IG1hdGNoaW5nIA0KPiBhbmQgcmV0 dXJuaW5nIHdpdGggZXJyb3IgbWVudGlvbmluZyB0aGF0ICdnJyBwYWNrZXQg aXMgdG9vIGxvbmcuIFRoZSBHIFBhY2tldCBpbml0aWFsaXphdGlvbiBpcyBk b25lIGluIGluaXRfcmVtb3RlX3N0YXRlIGZ1bmN0aW9uIHdoaWNoIGlzIGFs bCBoYXBwZW5pbmcgd2hlbiB0YXIgcmVtb3RlIG1hY2hpbmU6MTIzNCBjb21t YW5kIGlzIHVzZWQuDQoNCkknbSBxdWl0ZSBmYW1pbGlhciB3aXRoIGhvdyBH IHBhY2tldHMgYXJlIGhhbmRsZWQuICBBbiBleHBsYW5hdGlvbiBvZiB0aGlz IGlzIG5vdCBhbnN3ZXJpbmcgbXkgcXVlc3Rpb25zLg0KDQo+IEhvcGUgdGhp cyBjbGFyaWZpZXMgYXMgdGhpcyBlcnJvciBpcyBub3RoaW5nIHRvIGRvIHdp dGggd2hhdCBpcyBydW5uaW5nIG9uIHRhcmdldC4gT24gdGFyZ2V0IHRoZSBY TUQgaXMgcnVubmluZy4NCg0KSSBhc2tlZCB5b3UgdG8gc3RhcnQgb3ZlciBh bmQgcmVzdWJtaXQgYSBwYXRjaCwgaW5jbHVkaW5nIENoYW5nZWxvZywgd2l0 aG91dCB0aGUgcmVwbGllcy4gIEF0IHRoaXMgcG9pbnQsIEkgZG9uJ3Qga25v dyB3aGF0IENoYW5nZWxvZyBjb3JyZXNwb25kcyB0byB0aGUgcGF0Y2guDQoN CkkgYXNrZWQgaWYgWE1EIHdhcyBjb25uZWN0ZWQgdG8gdGhlIHRhcmdldC4g IFlvdSBzYWlkIGl0IHdhc24ndC4gIE5vdyB5b3Ugc2F5IHRoYXQgaXQgaXMs IGFuZCB0aGF0IGdkYnNlcnZlciBpcyBydW5uaW5nLiAgVGhpcyBkb2Vzbid0 IG1ha2Ugc2Vuc2UgdG8gbWUsIHNpbmNlIGlmIHlvdSBhcmUgcnVubmluZyBn ZGJzZXJ2ZXIgb24gdGhlIHRhcmdldCwgYW5kIGl0IGlzIGJ1aWx0IGZyb20g dGhlIHNhbWUgc291cmNlcywgeW91IHdpbGwgbmV2ZXIgZ2V0IGEgRyBwYWNr ZXQgbWlzbWF0Y2guDQoNCj4+TGV0J3MgdHJ5IHRoaXMgb25lIG1vcmUgdGlt ZTogIEdEQiBpcyBjb25uZWN0ZWQgdG8gc29tZXRoaW5nIHdoZW4geW91IHRl bGwgaXQgdG8gY29ubmVjdCB0byB0aGUgdGFyZ2V0IHdpdGggdGhlICJ0YXJn ZXQgcmVtb3RlIiBjb21tYW5kLg0KPj5UaGlzIGlzIHJldHVybmluZyBhIGRp ZmZlcmVudCBzaXplZCBHIHBhY2tldC4gIFdoYXQgaXMgaXQgdGhhdCB5b3Ug YXJlIGNvbm5lY3RpbmcgdG8/DQoNCkhlcmUgaXMgdGhlIGZsb3cgZnJvbSBH QkQgQ2xpZW50IHRvIFhNRCB0aGF0J3Mgd2hhdCBpcyBoYXBwZW5pbmc6DQoN CjEuIFhNRCBjb25uZWN0cyB0byB0aGUgaGFyZHdhcmUgdGFyZ2V0IHRocm91 Z2ggSlRBRy4NCjIuIFhNRCBPcGVucyBhIEdEQiBTZXJ2ZXIgb24gdGhlIGxv Y2FsIGhvc3QgMTIzNC4NCjMuIEdEQiBDbGllbnQgd2lsbCBjb25uZWN0IHRv ICB0aGUgaG9zdDoxMjM0IHRocm91Z2ggVENQLCB3aGVuIHRoZSBjb21tYW5k ICJ0YXIgcmVtb3RlIGxvY2FsaG9zdDoxMjM0IiBpcyBnaXZlbi4NCg0KVGhh bmtzICYgUmVnYXJkcw0KQWppdCANCg0KDQotLSANCk1pY2hhZWwgRWFnZXIJ IGVhZ2VyQGVhZ2VyY29uLmNvbQ0KMTk2MCBQYXJrIEJsdmQuLCBQYWxvIEFs dG8sIENBIDk0MzA2ICA2NTAtMzI1LTgwNzcNCg== >From gdb-patches-return-112748-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri May 23 12:18:00 2014 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 19569 invoked by alias); 23 May 2014 12:17:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 19557 invoked by uid 89); 23 May 2014 12:17:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: service87.mimecast.com Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 May 2014 12:17:56 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Fri, 23 May 2014 13:17:53 +0100 Received: from [10.1.208.33] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 23 May 2014 13:17:52 +0100 Message-ID: <537F3C6F.7030603@arm.com> Date: Fri, 23 May 2014 12:17:00 -0000 From: Richard Earnshaw User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:15.0) Gecko/20120907 Thunderbird/15.0.1 MIME-Version: 1.0 To: Ramana Radhakrishnan CC: Joel Brobecker , "gdb-patches@sourceware.org" , Marcus Shawcroft Subject: Re: [Patch AArch64] Include asm/ptrace.h in aarch64-linux-nat.c References: <537DBDF3.1080907@arm.com> <20140522124927.GR22822@adacore.com> <537F00EB.5090601@arm.com> In-Reply-To: <537F00EB.5090601@arm.com> X-MC-Unique: 114052313175321201 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00586.txt.bz2 Content-length: 2453 On 23/05/14 09:03, Ramana Radhakrishnan wrote: > On 05/22/14 13:49, Joel Brobecker wrote: >>> A recent change to glibc removed asm/ptrace.h from user.h for >>> AArch64. This meant that cross-native builds of gdb using trunk >>> glibc broke because aarch64-linux-nat.c because user_hwdebug_state >>> couldn't be found. >>> >>> Fixed by including asm/ptrace.h like other ports. >> >> Thanks for the explanation. Can you make sure you include that >> in the revision history of your commit? >> >>> 2014-05-22 Ramana Radhakrishnan >>> >>> * aarch64-linux-nat.c (asm/ptrace.h): Include. >>> >> >> OK to push. Thank you. >> >> >=20 > Thanks - I've got a similar one in gdbserver which I somehow managed to=20 > miss yesterday. >=20 > Ok to push ? >=20 I'd be inclined to consider this as obvious after yesterday's approval. R. > regards > Ramana >=20 >=20 >=20 > p1.txt >=20 >=20 > commit e9dae05e9c32efda9724330c6d5ade3ca848591d > Author: Ramana Radhakrishnan > Date: Fri May 23 09:01:14 2014 +0100 >=20 > Include asm/ptrace.h for linux-aarch64-low.c >=20=20=20=20=20 > A recent change to glibc removed asm/ptrace.h from user.h for AArch64. > This meant that cross-native builds of gdbserver using trunk glibc br= oke > because linux-aarch64-low.c because user_hwdebug_state couldn't be fo= und. >=20=20=20=20=20 > This is like commit #036cd38182bde32d8297b630cd5c861d53b8949e >=20=20=20=20=20 > 2014-05-23 Ramana Radhakrishnan >=20=20=20=20=20 > * linux-aarch64-low.c (asm/ptrace.h): Include. >=20 > diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog > index 81bd30e..e591108 100644 > --- a/gdb/gdbserver/ChangeLog > +++ b/gdb/gdbserver/ChangeLog > @@ -1,3 +1,7 @@ > +2014-05-23 Ramana Radhakrishnan > + > + * linux-aarch64-low.c (asm/ptrace.h): Include. > + > 2014-05-21 Jan Kratochvil >=20=20 > Fix TLS access for -static -pthread. > diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarc= h64-low.c > index 033e79e..6066e15 100644 > --- a/gdb/gdbserver/linux-aarch64-low.c > +++ b/gdb/gdbserver/linux-aarch64-low.c > @@ -26,6 +26,7 @@ > #include > #include > #include > +#include > #include >=20=20 > #include "gdb_proc_service.h" >=20