From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qFo3KMVzMWmE0BgAWB0awg (envelope-from ) for ; Thu, 04 Dec 2025 06:43:01 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=iRRXQxjQ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=4dYgcaBD; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=V9GS1Aru; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=4L4xolar; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 946491E08D; Thu, 04 Dec 2025 06:43:01 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B65791E08D for ; Thu, 04 Dec 2025 06:43:00 -0500 (EST) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3E80F4BC8947 for ; Thu, 4 Dec 2025 11:43:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3E80F4BC8947 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=iRRXQxjQ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=4dYgcaBD; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=V9GS1Aru; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=4L4xolar Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id D5F1C4BB3BB8 for ; Thu, 4 Dec 2025 11:42:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D5F1C4BB3BB8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D5F1C4BB3BB8 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764848542; cv=none; b=LgiHjPMW74swGGeddX6SuHuLZbzpluprlFLueIqu7mmJOtZn9FiG7La0zCaeLCP9aCCWACW96NeP1shTCea8uWDYRPr2BbZAmHxoQEk4ZfXUqYFRwmHTn25SOG7skf0BXKOLy+T8qIU7UyAA1UGvAILtivSIXHJShqCcoNCm48k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764848542; c=relaxed/simple; bh=GLbSmlUlLvbyHo71pieC+LLHyQFnHbCruYaUa14TEhY=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=IvMj3lDT9eAffG3GeFaktsGFK+76t7jD9rvFg6e3kQ7PJMDwx0/KnBNrJrWBtopzRLTv8igBKED7CVjhe6ZdpwpwzKp3oTZYLPNDUBxqSPT+1RTgU6hPvZmsyAFTOYPBjIzybhJGOZp7YVA1V/ZkbF5MwbqWVgPI997rcSziqvU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D5F1C4BB3BB8 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4251C338DE; Thu, 4 Dec 2025 11:42:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1764848539; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DaN8+j3Em/ilGw/ykj3aUROUXoQTPc1IpEjFj/FvBYk=; b=iRRXQxjQBafSQYlUOpHMq6Ef5XZ0lyQ3XSwUhjn6zoT7KZRGpcXaZg1MPDBhbeDi0hB8bV lix36UMQLqnKzOf5X39NIEfMUy9p/IYler6DfgA8ZVIIgScVrkrQWd/7OI99wlo9goJEn1 2OoGmz+5ASvEgy2kLf5C09kIXgLSziM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1764848539; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DaN8+j3Em/ilGw/ykj3aUROUXoQTPc1IpEjFj/FvBYk=; b=4dYgcaBDK0PeKhj4YT1WtBocwGk5TPmdcYGqWCQSfx0QI3qN/BfZ/B7h2daJNhXSEIHjAK X/1CoNo7rKTZ/bAg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=V9GS1Aru; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=4L4xolar DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1764848538; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DaN8+j3Em/ilGw/ykj3aUROUXoQTPc1IpEjFj/FvBYk=; b=V9GS1ArukE/7NK3AVwtJJYVXTOKJ373aOOxk0g//Drjc18Yf1+ixkIBMysk1j2Ot3E+i54 Lnwpatg+82Br8EckrodYLB9FSIg3nHLHqMxZmicnOZPoRO0yzhNnjGBOgL/8Lg7clBTeaA xIJXLQFxPUzF8KVV9Zunj4Cfo/8/M9k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1764848538; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DaN8+j3Em/ilGw/ykj3aUROUXoQTPc1IpEjFj/FvBYk=; b=4L4xolarntE0LdLRFmNCHMXEyZuYNaSh0uHi0MLBtjq+Xmqagqa/7WHDsv/jgl2Pht4HjP PD+LhDL2SKLbUBDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 216DA3EA63; Thu, 4 Dec 2025 11:42:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ZuzrBppzMWn/SAAAD6G6ig (envelope-from ); Thu, 04 Dec 2025 11:42:18 +0000 Message-ID: Date: Thu, 4 Dec 2025 12:42:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [pushed] gdb: change blockvector::contains() to handle blockvectors with "holes" To: =?UTF-8?Q?Jan_Vran=C3=BD?= , "tom@tromey.com" Cc: "gdb-patches@sourceware.org" , "simon.marchi@efficios.com" References: <20251128134950.1763596-1-jan.vrany@labware.com> <20251128134950.1763596-2-jan.vrany@labware.com> <87ecpc93xk.fsf@tromey.com> <87sedr73yv.fsf@tromey.com> <84386110e9037b89a33f6c00a276d025fed7fb67.camel@labware.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <84386110e9037b89a33f6c00a276d025fed7fb67.camel@labware.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4251C338DE X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,labware.com:email,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,sourceware.org:url]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Action: no action X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 12/3/25 10:31 PM, Jan Vraný wrote: > On Wed, 2025-12-03 at 12:36 -0700, Tom Tromey wrote: >>>>>>> "Jan" == Jan Vraný writes: >> >>>> FWIW it seems to me that the blockvector should just have a single >>>> lookup function, and it should be used to find precisely the code block >>>> containing the given address.  That is, it should never return the >>>> static or global block, since those aren't really "code" but instead >>>> just containing scopes.  This is the direction I was trying to head by >>>> removing calls to map(); the one remaining call is one of these weird >>>> ones... >> >> Jan> I agree, I just do not really understand why there was the >> Jan> difference in first place. >> >> I don't really, either.  That code is pretty old, though, and some of >> the older code is pretty questionable.  Like sometimes problems with >> debug readers were worked around in core code rather than being solved >> in the reader, abstractions were very leaky (or in this case >> nonexistent), etc. >> >> Jan> In fact, it seems that it matters - I've got a report that this >> Jan> commit caused regression on arm (still investigating, I do not have >> Jan> armhf system at hand, so need to set it up first). >> >> My current attempt at cleanups here also run into some regressions that >> I wasn't really expecting :( >> >> Anyway I'd find it interesting to learn what the ARM regression is >> about. > > Yeah, it's weird. The report is here: > > https://linaro.atlassian.net/browse/GNU-1767 > > I did not yet managed to reproduce it. It does not seem to manifest Debian > armhf running on QEMU. I'm not familiar with ARM ecosystem myself and > I do not know yet how to arrive at working "armv8l" system. I'll let you > know when I learn more but just now I'm running out of ideas on how to > debug this :( > I bisected this PR ( https://sourceware.org/bugzilla/show_bug.cgi?id=33679 ) to this commit. Are the regressions you mention the same issue? Thanks, - Tom > Jan > >> >> Tom >