From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mUsCBYxtBmfXVgcAWB0awg (envelope-from ) for ; Wed, 09 Oct 2024 07:48:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1728474507; bh=M3jrNrYglW9KgrxnT+x0Mh0Y7NB8aRf0v61VhdsVVIs=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=wR3YfMaR4hym5wgq1zTA8lR7GdXsWduk3AdhwArpU7PXiokUxDLa35A7dCyvGfOti MQQnBHm0sNKoLLxPryukVjIgUKTXzgoly6p+8nalirze/eYhl4GkUqIoyZbWjANwAI YudVXcs/JwPDR+f8MUGiJd1K08u2qbM3FfRD/uHo= Received: by simark.ca (Postfix, from userid 112) id EE2161E356; Wed, 9 Oct 2024 07:48:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,URIBL_BLOCKED,URIBL_DBL_BLOCKED_OPENDNS autolearn=unavailable autolearn_force=no version=4.0.0 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=aYym//5v; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=ISq6DoXv; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D127B1E354 for ; Wed, 9 Oct 2024 07:48:26 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 62635384F00E for ; Wed, 9 Oct 2024 11:48:26 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id BB9CE385DC1E for ; Wed, 9 Oct 2024 11:48:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BB9CE385DC1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BB9CE385DC1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728474490; cv=none; b=FhGTGSVPGoTI4kMgZMxn2YO0hO/GNRgFT2Gg0Vd8Iek0AX8qcgkZSjz/9qwMKAgFG62BmNrevqcewNKCyOC2/JaenDeYd1PPKcydNSkammoVRJggmkhCGb8kc0uwKHdE4m0zn7IC9r4cADuOBhgLX6cOXN0t4MuMPnh4+fJ2GV4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728474490; c=relaxed/simple; bh=M3jrNrYglW9KgrxnT+x0Mh0Y7NB8aRf0v61VhdsVVIs=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=ETwr+u7lbFiKqCV78vpNWCjs1v5s1a1zqpJ9/ws2QNp/AWlLPU/MgBnczn6Ir9/OA0I41uMH4/U8p2aYZ6s1bdUe3qCZyng08/1bgd6OnU/rUcERwt/sre2vinRwwDrvuCiRXacksnM9aQRJ7sMDkkCK30Jox+O+YuzVVNWKFFg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1728474488; bh=M3jrNrYglW9KgrxnT+x0Mh0Y7NB8aRf0v61VhdsVVIs=; h=Date:Subject:To:References:From:In-Reply-To:From; b=aYym//5vhUjiOjz6e7TkpOXNa2V/5nGVX74SYfsbJBccM1UNRFx8mWvvUkfeguvNs wXDW+i9sH3s4a8icjJSIHnG8D0p2b32LjlsHc+Usc62X6ca3bFEpuHeJ+Qa2AzhANn +xI34Cj+B3MldyAxjFLkVeIT/dRLVxBzWAvM+nvE= Received: by simark.ca (Postfix, from userid 112) id 02CD31E357; Wed, 9 Oct 2024 07:48:08 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1728474486; bh=M3jrNrYglW9KgrxnT+x0Mh0Y7NB8aRf0v61VhdsVVIs=; h=Date:Subject:To:References:From:In-Reply-To:From; b=ISq6DoXvr8ds5Kl+qant7KrU9cI+hL7N44141eIBsNZJz3kWb1iBH4wZ5kEb1g7yA kh51izwzJFWQgNarhDFy5nuodHTyA62N7blC9vqBcAEJU8T6UZ6lK2soKY4F5qKUVJ Kn14ezmARLYwP8dRXLI61XBIszgs3mFlggzQktxs= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id BE6631E354; Wed, 9 Oct 2024 07:48:06 -0400 (EDT) Message-ID: Date: Wed, 9 Oct 2024 07:48:06 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] gdb: make use of set_tdesc_osabi overload in features/ files To: Andrew Burgess , gdb-patches@sourceware.org References: <805ec50236bae86f1e7e1d77ceff99763ec00ba4.1728239729.git.aburgess@redhat.com> <87jzehbkk0.fsf@redhat.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <87jzehbkk0.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2024-10-09 07:08, Andrew Burgess wrote: > Simon Marchi writes: > >> On 2024-10-06 14:37, Andrew Burgess wrote: >>> There are two versions of the set_tdesc_osabi function in GDB: >>> >>> void >>> set_tdesc_osabi (struct target_desc *target_desc, const char *name) >>> { >>> set_tdesc_osabi (target_desc, osabi_from_tdesc_string (name)); >>> } >>> >>> void >>> set_tdesc_osabi (struct target_desc *target_desc, enum gdb_osabi osabi) >>> { >>> target_desc->osabi = osabi; >>> } >>> >>> In the gdb/features/ files we call the second of these functions, like >>> this: >>> >>> set_tdesc_osabi (result.get (), osabi_from_tdesc_string ("GNU/Linux")); >>> >>> This can be replaced with a call to the first set_tdesc_osabi >>> function, so lets do that. I think that this makes the features/ code >>> slightly simpler and easier to understand. >>> >>> There should be no user visible changes after this commit. >> >> Just a nit but... while at it, couldn't we change them to use the >> enumerator directly, to save lookups at runtime? >> >> set_tdesc_osabi (result.get (), GDB_OSABI_LINUX); >> >> I guess we would need a enum -> string (GDB_OSABI_LINUX -> >> "GDB_OSABI_LINUX") function, which we have for other enums. We just >> don't have it for this enum yet. Another case for adding a "magic enum" >> library :). > > This was Luis' request. See v2 my attempt at this. Oh, sorry, I did not see v2 yesterday. Simon