From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-146789-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12823 invoked by alias); 24 Apr 2018 16:44:05 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 12796 invoked by uid 89); 24 Apr 2018 16:44:04 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-12.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:632
X-HELO: mx1.redhat.com
Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 24 Apr 2018 16:44:03 +0000
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 14AFE81A88A2;	Tue, 24 Apr 2018 16:44:02 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id 952DD7C58;	Tue, 24 Apr 2018 16:44:01 +0000 (UTC)
Subject: Re: [RFA 8/8] Let gdb.execute handle multi-line commands
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
References: <20180419191539.661-1-tom@tromey.com> <20180419191539.661-9-tom@tromey.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <f056379f-13e8-bc2e-2685-781b64ff4632@redhat.com>
Date: Tue, 24 Apr 2018 16:44:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20180419191539.661-9-tom@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-04/txt/msg00481.txt.bz2

On 04/19/2018 08:15 PM, Tom Tromey wrote:

> --- a/gdb/python/python.c
> +++ b/gdb/python/python.c
> @@ -581,6 +581,20 @@ execute_gdb_command (PyObject *self, PyObject *args, PyObject *kw)
>      {
>        struct interp *interp;
>  
> +      std::string arg_copy = arg;
> +      bool first = true;
> +      char *save_ptr = nullptr;
> +      gdb::function_view<const char * ()> reader
> +	= [&] ()

"auto reader"

Looks good to me otherwise.

> +	  {
> +	    const char *result = strtok_r (first ? &arg_copy[0] : nullptr,
> +					   "\n", &save_ptr);
> +	    first = false;
> +	    return result;
> +	  };
> +
Thanks,
Pedro Alves