From: Chet Ramey <chet.ramey@case.edu>
To: Tom de Vries <tdevries@suse.de>, bug-readline@gnu.org
Cc: chet.ramey@case.edu, gdb-patches@sourceware.org,
Pedro Alves <palves@redhat.com>
Subject: Re: [Bug-readline] heap-buffer-overflow in update_line
Date: Thu, 23 May 2019 12:38:00 -0000 [thread overview]
Message-ID: <f0529a5e-adb8-b451-3a89-e903172a2438@case.edu> (raw)
In-Reply-To: <e6c37118-a277-d14f-d38b-0a0c06d921eb@suse.de>
On 5/23/19 3:33 AM, Tom de Vries wrote:
> Using this additional bit:
> ...
> @@ -528,6 +533,8 @@ rl_redisplay ()
> init_line_structures (0);
> rl_on_new_line ();
> }
> + else if (line_size <= _rl_screenwidth)
> + init_line_structures (_rl_screenwidth + 1);
>
> /* Draw the line into the buffer. */
> cpos_buffer_position = -1;
> ...
> I managed to fix the assert also in this scenario, and managed to run
> the entire gdb testsuite without triggering the assert.
>
> Is that a good code change?
It looks like it will solve that problem, and perhaps more. Thanks for the
patch.
Chet
--
``The lyf so short, the craft so long to lerne.'' - Chaucer
``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU chet@case.edu http://tiswww.cwru.edu/~chet/
next prev parent reply other threads:[~2019-05-23 12:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <52f237e9-83e8-2a97-4766-e60b867ab914@suse.de>
[not found] ` <d29fbf1f-d33e-77f6-90ed-0eb3779a027c@case.edu>
2019-05-17 14:59 ` Tom de Vries
2019-05-17 15:34 ` Chet Ramey
2019-05-20 20:14 ` Chet Ramey
2019-05-23 7:33 ` Tom de Vries
2019-05-23 12:38 ` Chet Ramey [this message]
2019-05-23 19:28 ` Tom de Vries
2019-05-24 13:08 ` Chet Ramey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0529a5e-adb8-b451-3a89-e903172a2438@case.edu \
--to=chet.ramey@case.edu \
--cc=bug-readline@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox