From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id BDA60385DC0A for ; Wed, 29 Apr 2020 15:04:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BDA60385DC0A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.193] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E77301F068; Wed, 29 Apr 2020 11:04:41 -0400 (EDT) Subject: Re: [PATCHv2 0/3] Automatic detection of test name problems To: Andrew Burgess , Keith Seitz Cc: gdb-patches@sourceware.org References: <290d0de3-264b-9a60-487f-ff6b484c35f1@redhat.com> <20200429090216.GI3522@embecosm.com> From: Simon Marchi Message-ID: Date: Wed, 29 Apr 2020 11:04:40 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200429090216.GI3522@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2020 15:04:53 -0000 On 2020-04-29 5:02 a.m., Andrew Burgess wrote: > * Keith Seitz [2020-04-28 12:08:25 -0700]: > >> On 4/27/20 3:01 PM, Andrew Burgess wrote: >>> Changes since v1: >>> >>> 1. Original patch #1 is now merged. >>> >>> 2. Functionality is now placed inside a namespace. >>> >>> 3. Better counting for multi-variant test runs, this is inline with >>> how Dejagnu's muti-variant result counting works. >>> >>> 4. Use 'string first' instead of 'regexp'. >>> >>> 5. Reworded commit message on what is now patch #2. >>> >>> Further feedback welcome. >> >> Wow, that's almost a complete rewrite! While not what I was really >> suggesting, I have to admit, a /big/ smile came to my face while >> reading this. It is so nicely done! >> >> Thank you! >> >> Keith >> >> PS. As you know, IANAM, but you are, so I encourage you to approve >> your patch. ;-) > > Thanks for your feedback, especially your TCL suggestions. > > I'll let the patch sit for a while to see if anyone else has any > input. > > Thanks, > Andrew > Hi Andrew, Thanks for doing this, it's nice. And by testing this patchset, I've found an offender and sent a patch for it :) https://sourceware.org/pipermail/gdb-patches/2020-April/168052.html When you detect an offender, do you think you could print something? A bit like a "FAIL" is printed when a test fails. For example: DUPLICATE: gdb.base/break.exp: set convenience variable $foo to 81.5 That would make it easier to spot the problematic test(s). But even without that, your patchset looks good and useful to me. Simon