From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7618 invoked by alias); 18 Dec 2006 07:28:47 -0000 Received: (qmail 7610 invoked by uid 22791); 18 Dec 2006 07:28:46 -0000 X-Spam-Check-By: sourceware.org Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 18 Dec 2006 07:28:36 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1GwCvB-0000Gf-C3 for gdb-patches@sources.redhat.com; Mon, 18 Dec 2006 08:28:25 +0100 Received: from 73-198.umostel.ru ([82.179.73.198]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 18 Dec 2006 08:28:25 +0100 Received: from ghost by 73-198.umostel.ru with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 18 Dec 2006 08:28:25 +0100 To: gdb-patches@sources.redhat.com From: Vladimir Prus Subject: Re: Cleanup varobj children handling Date: Mon, 18 Dec 2006 07:28:00 -0000 Message-ID: References: <200612082300.06688.ghost@cs.msu.su> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit User-Agent: KNode/0.10.2 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00231.txt.bz2 Vladimir Prus wrote: > Vladimir Prus wrote: > >> >> This patch changes varobj.c to use VEC for hodling children, thereby >> making three functions unnecessary. No regressions in MI tests. OK? > > I forgot to remove some more dead code -- struct varobj_child is no longer > needed. This patch removes it too. > > - Volodya > > gdb/ > * varobj.c: Include "vec.h". > (varobj_p): New typedef, declare vector of those. > (struct varobj): Use vector for the 'children' member. > (child_exists): Remove. > (save_child_in_parent): Remove. > (remove_child_from_parent): Remove. > (struct varobj_child): Remove. > (varobj_list_children): Adjust to work work vector. > (varobj_update): Likewise. > (delete_variable_1): Likewise. > * Makefile.in (varobj.o): Update dependencies. > > testsuite/ > * gdb.mi/mi-var-child.exp: Adjust to the change in order > of varobjs reported by -var-update. > * gdb.mi/mi2-var-child.exp: Likewise. PING? The above was posted 10 days ago. - Volodya