Re: New ARI warning Fri May 18 01:56:48 UTC 2018

[Simon Marchi <simark@simark.ca>]

On 2018-05-18 15:03, Joel Brobecker wrote:
> Right, which is why I formulated this as a question. I don't really
> know what style we want there. But since it was easy to patch the
> script, I thought I'd send that right away, to show one of the options.
> But I'd be OK with deciding that unittests/ should follow the GDB
> coding standards.

I think we can just add the /* ARI: ... */ comments, I'll try it later.  
I don't see any reason why it would be harder in general to follow our 
code conventions in unit tests than anywhere else.  This case is just a 
bit of a special one.

>> Is is possible to exclude unittests/* instead of listing all the
>> files?  We'll surely add new files in there, and don't want to have to
>> update that script every time.
> 
> This is exactly what the patch I sent does. The above was just
> the diff of output between before and after patch (sorry for
> the cryptic message).
> 
>      find "$@" \
>          -name testsuite -prune -o \
>     +    -name unittests -prune -o \
>          -name gdbserver -prune -o \
>          -name gdbtk -prune -o \
>          -name gnulib -prune -o \

Ahh ok, I missed the patch in attachment.  I indeed thought that the 
output you pasted was the actual patch in a cryptic format (like diff's 
default format).

Simon