From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64071 invoked by alias); 13 Jan 2020 22:04:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 64057 invoked by uid 89); 13 Jan 2020 22:04:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (207.211.31.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Jan 2020 22:04:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578953063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MM7FEll6gikhEW/gj7eIkhBM1Uh9OqgNDwkUSCm6SUE=; b=TCN1wYFeFzvotNBcGmVq/j/aHuy30WxNt/v8KdIoUY5zKrvmM15CMnyNvXtj9NYoL6mbxl ibx93gScJHWBrDetMDzOBYyAYV5+XKvFF/TrQTXcNeLCC76XCfgudBniirTNj2Fk/Wi7rX jBey9v5DeVK6xq2ZLub+jJrwMaIlFQs= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-261-qTxTuZBANMGOcdEDphvVHg-1; Mon, 13 Jan 2020 17:04:22 -0500 Received: by mail-wm1-f69.google.com with SMTP id t16so2857449wmt.4 for ; Mon, 13 Jan 2020 14:04:22 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id z124sm17242477wmc.20.2020.01.13.14.04.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2020 14:04:20 -0800 (PST) Subject: Re: [PATCH] gdb: use std::vector instead of alloca in core_target::get_core_register_section To: Simon Marchi , gdb-patches@sourceware.org References: <20200112201729.489317-1-simon.marchi@polymtl.ca> From: Pedro Alves Message-ID: Date: Mon, 13 Jan 2020 23:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-01/txt/msg00358.txt.bz2 On 1/13/20 8:02 PM, Simon Marchi wrote: > On 2020-01-13 2:40 p.m., Pedro Alves wrote: >> On 1/12/20 8:17 PM, Simon Marchi wrote: >>> - contents = (char *) alloca (size); >>> - if (! bfd_get_section_contents (core_bfd, section, contents, >>> + std::vector contents (size); >>> + if (! bfd_get_section_contents (core_bfd, section, contents.data (), >>> (file_ptr) 0, size)) >>> { >> >> gdb::byte_vector > > I used std::vector because the original code also used char, and > m_core_vec->core_read_registers also accepts a char * (although I > could/should have used gdb::char_vector anyway). However, gdb_byte > probably makes more sense here. I would push the patch below as a fixup > if it looks good to you. It does LGTM, thanks! Pedro Alves