From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id zsI5LkAju2hCtBgAWB0awg (envelope-from ) for ; Fri, 05 Sep 2025 13:52:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1757094720; bh=XQvFMLmIsFWndjdasSotXcsLPoXYWJ8rs+K96NCStpY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=IDgHeiBh1eIDHQ8p5o6KBNoGH292J0sIYmxFGQg3O0dW4sHk86VmJSVjhPsnKdJvM PlMnKzk/QoDLCu1+rb806TQwAWRImUGxg9V3/iIBCaLKxolGbKfosQUvYc62G9ne6t yOs90PU2GBRkXGPPLOgfgdlSWhzfexZolPR5o0T4= Received: by simark.ca (Postfix, from userid 112) id A80F71E047; Fri, 05 Sep 2025 13:52:00 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Y72b9/50; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E571C1E047 for ; Fri, 05 Sep 2025 13:51:59 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 811C33857820 for ; Fri, 5 Sep 2025 17:51:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 811C33857820 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Y72b9/50 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 124D93858D37 for ; Fri, 5 Sep 2025 17:51:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 124D93858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 124D93858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757094689; cv=none; b=BZ+jIZ6kau91Xw2J2qEi7EjlaM3sxI4klhDYizd6V4nlGVwGzm1MG6nLsEs3WlOtDiLfbGpnGZJ7lRmxna2A4EDEmCrFl38SZTYYRUXwInJn4AfpHn5DC2hpZ2vW6TsZsfQmrY+CPHM0bY+xTXsRuCFiyyWo6fZ9EHIjngrhuDo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757094689; c=relaxed/simple; bh=XQvFMLmIsFWndjdasSotXcsLPoXYWJ8rs+K96NCStpY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=wbfSsfDNk6VMUM/Uy82NHZfkxTbj2iygec/zQ/ja/yTPY7CxE5thcq55j0LEaGvE1894HPzZk1YLSead8rffxL+suxH3eppTTv/MquuSf0kVL0f6ZUN8pROgrsuueHDb0FIkVAOo9WFM3IR7J+WpgRN5tweXiH+vwpGlBJsm1o8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 124D93858D37 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1757094688; bh=XQvFMLmIsFWndjdasSotXcsLPoXYWJ8rs+K96NCStpY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Y72b9/50V/GrtZFVRf4d9tpzVPt5GV4RXebiVe7CmTCoWDfdsDfeUG4/J8jPlhuWx S/vOpK2E2ENgEJcuzTg/H41qY7MLrmRTUD749fyb9bULUI31//1goSUfKlWxKGL13J cw3laRYRQI/pfMjmP4TT00jHFiCiLQ0fEwGnASmc= Received: by simark.ca (Postfix) id 4F7E51E047; Fri, 05 Sep 2025 13:51:28 -0400 (EDT) Message-ID: Date: Fri, 5 Sep 2025 13:51:27 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Allow conversion of 128-bit integers to Python To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20250905132926.460147-1-tom@tromey.com> <84ce5145-0c06-487b-81f5-c6c232f5949e@simark.ca> <87ms78izdz.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87ms78izdz.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/5/25 1:26 PM, Tom Tromey wrote: > Simon> If we are forced to use kwargs, I think we might as well just use kwargs > Simon> for all the args. > > I don't see that this provides a benefit, but I went ahead and did it > anyway. Note that PyObject_Call requires a tuple argument, so we end up > creating an empty one. > > Simon> Can you add some comments above the Python API calls, just to explain at > Simon> a high level what this is doing, so that someone who doesn't know the > Simon> Python API by heart can follow what is happening? > > I did this. I'll check it in shortly. > > Tom I thought that we could avoid creating the tuple. If we can't then it doesn't matter much. Although the kwargs has the advantage that the arguments are named, so it's perhaps a bit more readable. Simon