From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id T9FrKiYS+l/PWwAAWB0awg (envelope-from ) for ; Sat, 09 Jan 2021 15:29:26 -0500 Received: by simark.ca (Postfix, from userid 112) id 9BCF41EE11; Sat, 9 Jan 2021 15:29:26 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5F9651E940 for ; Sat, 9 Jan 2021 15:29:25 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E793D386103F; Sat, 9 Jan 2021 20:29:24 +0000 (GMT) Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by sourceware.org (Postfix) with ESMTPS id AA6893861038 for ; Sat, 9 Jan 2021 20:29:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AA6893861038 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wm1-f41.google.com with SMTP id n16so8710533wmc.0 for ; Sat, 09 Jan 2021 12:29:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=edrRZr/veoq+tkXLw0t8qPdPOp5QoyEwYZ8jOJRtr0k=; b=Lac4m+21+3XLPfnZyDSsWfp6ctvvAg/IglLX2EwG85EcHZM4gp7ENX6TLLj8lfwxmO /dFqsiGs9Vjush7iLXbneHvmyxz05oA9WkzWSDEapoQGudJse32EzYl0QnF5244e5YJo y4yZSMbqcpv6eldOXoDBjzBqrjQVzA4BUTKWOE8FNTUZEL3sEhZ9jaHxyLQaO2c5d4ie 5M3c9dFAeRm/Fwk92U88RjwXAK8cBFYbQioElGktPYfJYSE4QPugX29beaDnu+Vv8Iyz /py0vI+yxJkcekwp15PN1k55igbaqy2M5paI/blVfRlW5nGHq+Nv6KxBcbHy8LnFUE+H R6kw== X-Gm-Message-State: AOAM533nHoO+C9F7dUNH/xuD0WcLo+bSMZRHuYHV/OhmT//8ymE+SQ+U mdJ9gSdkPhoYTUR2hhVPSqk= X-Google-Smtp-Source: ABdhPJwrdrlCv5mleaaVfFLURdXxKf6UNy/nngrq/U7lLCPouigG42w8DrXNuGcCfNvypipLdqSasQ== X-Received: by 2002:a1c:1d1:: with SMTP id 200mr8536418wmb.98.1610224161679; Sat, 09 Jan 2021 12:29:21 -0800 (PST) Received: from ?IPv6:2001:8a0:f91f:e900:1d90:d745:3c32:c159? ([2001:8a0:f91f:e900:1d90:d745:3c32:c159]) by smtp.gmail.com with ESMTPSA id a65sm17086167wmc.35.2021.01.09.12.29.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 Jan 2021 12:29:20 -0800 (PST) Subject: Re: [PATCH v3 3/5] gdb: move commit_resume to process_stratum_target From: Pedro Alves To: Simon Marchi , gdb-patches@sourceware.org References: <20210108041734.3873826-1-simon.marchi@polymtl.ca> <20210108041734.3873826-4-simon.marchi@polymtl.ca> Message-ID: Date: Sat, 9 Jan 2021 20:29:19 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210108041734.3873826-4-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 08/01/21 04:17, Simon Marchi wrote: > From: Simon Marchi > > The following patch will change the commit_resume target method to > something stateful. Because it would be difficult to track a state > replicated in the various targets of a target stack, and since for the > foreseeable future, only process stratum targets are going to use this > concept, this patch makes the commit resume concept specific to process > stratum targets. > > So, move the method to process_stratum_target, and move helper functions > to process-stratum-target.h. > > gdb/ChangeLog: > > * target.h (struct target_ops) : New. > (target_commit_resume): Remove. > (make_scoped_defer_target_commit_resume): Remove. > * target.c (defer_target_commit_resume): Remove. > (target_commit_resume): Remove. > (make_scoped_defer_target_commit_resume): Remove. > * process-stratum-target.h (class process_stratum_target) > : New. > (maybe_commit_resume_all_process_targets): New. > (make_scoped_defer_process_target_commit_resume): New. > * process-stratum-target.c (defer_process_target_commit_resume): > New. > (maybe_commit_resume_process_target): New. > (make_scoped_defer_process_target_commit_resume): New. > * infrun.c (do_target_resume): Adjust. > (commit_resume_all_targets): Rename into... > (maybe_commit_resume_all_process_targets): ... this, adjust. > (proceed): Adjust. > * record-full.c (record_full_wait_1): Adjust. > * target-delegates.c: Re-generate. > OK.