From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5620 invoked by alias); 17 Feb 2020 20:52:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5610 invoked by uid 89); 17 Feb 2020 20:52:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=UD:ca X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Feb 2020 20:52:05 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 01HKpvLS031494 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 Feb 2020 15:52:02 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 01HKpvLS031494 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1581972723; bh=LmcFk0ahVNjl4Cf9dCCCDrOWoOQBBvB+pycUgmKtM6Y=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=MezW+aphnPLg6865MShg7TDRfg14/hai21OjoQ1Mx0lxyQHlQpaPWIZEH6vP4a3C6 3PTqtYm08NKe6R6yRDAlT3k9sG0HbtH7dUjTMB8pEVop1+w7BQfVrcwigdNElxTa3u OJ11/4m4DTc/h+buWmQ2QCp4KE6Ti1cqFWD/8WgU= Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 113851E05A; Mon, 17 Feb 2020 15:51:57 -0500 (EST) Subject: Re: [PATCH][gdb/testsuite] Ignore pass/fail/unsupported in gdb-caching-proc.exp To: Tom de Vries , Tom Tromey Cc: gdb-patches@sourceware.org References: <20200213105754.GA22520@delia> <87imkapngd.fsf@tromey.com> <2319b744-2902-9c09-2448-450e40347c04@suse.de> From: Simon Marchi Message-ID: Date: Mon, 17 Feb 2020 20:52:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <2319b744-2902-9c09-2448-450e40347c04@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00692.txt.bz2 On 2020-02-13 10:02 a.m., Tom de Vries wrote: > On 13-02-2020 15:32, Tom Tromey wrote: >>>>>>> "Tom" == Tom de Vries writes: >> >> Tom> 2020-02-13 Tom de Vries >> >> Tom> * gdb.base/gdb-caching-proc.exp (ignore_pass, ignore_fail) >> Tom> (ignore_unsupported): New proc. >> Tom> (test_proc): Temporarily rename pass/fail/ignore to >> Tom> ignore_{pass,fail,ignore} in order to ignore PASS/FAIL/IGNORE messages >> Tom> from the tested procs. >> >> Can we just require that caching proc bodies not invoke tests? >> > > We could, I don't have preference one way or the other. > > If I remove all the fail calls from gnat_runtime_has_debug_info, we > still get these PASSes from gdb_compile_ada: > ... > PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb > PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb > PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb > PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb > PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb > PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb > PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb > PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb > PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb > PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb > PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb > PASS: gdb.base/gdb-caching-proc.exp: gnat_runtime_has_debug_info consistency > ... > > But we can factor that out, I've already done that once here ( > https://sourceware.org/ml/gdb-patches/2019-10/msg01109.html ). > > Simon, WDYT? > > Thanks, > - Tom > If you can indeed do that, I think it would be best. Simon