From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Fix regression in "commands"
Date: Mon, 04 Dec 2017 15:55:00 -0000 [thread overview]
Message-ID: <ef0d7e9b-afbc-c43a-2ebf-33fad504b01e@redhat.com> (raw)
In-Reply-To: <87r2se5qv0.fsf@tromey.com>
On 12/01/2017 04:56 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> I wonder whether gdb.base/commands.exp is a better home for this.
>
> That file has some tests of "commands" but also is a grab-bag of testing
> random commands. I don't think the name specifically has to do with the
> "commands" command; so unless you feel strongly about it, I'll just
> leave it in break.exp.
Right, I wasn't thinking about the "commands" command specifically --
I think that testcase is more about the support for user-defined
commands / scripting than about random commands, and there are
some tests in there about breakpoint commands.
But really I don't feel strongly about it at all. break.exp is fine.
Thanks,
Pedro Alves
prev parent reply other threads:[~2017-12-04 15:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 19:07 Tom Tromey
[not found] ` <3a860acf-6e64-b2ba-e3fd-560406077259@redhat.com>
2017-12-01 16:45 ` Tom Tromey
2017-12-04 15:50 ` Pedro Alves
2017-12-07 18:13 ` Tom Tromey
2017-12-07 18:27 ` Pedro Alves
2017-12-01 16:56 ` Tom Tromey
2017-12-04 15:55 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef0d7e9b-afbc-c43a-2ebf-33fad504b01e@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox