From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109441 invoked by alias); 16 Jan 2019 11:11:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109420 invoked by uid 89); 16 Jan 2019 11:11:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=inherited, relating, coo, H*r:106 X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr130058.outbound.protection.outlook.com (HELO EUR01-HE1-obe.outbound.protection.outlook.com) (40.107.13.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Jan 2019 11:11:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MLH6GmAf5tDEAsnKdQ+uPp8IlqXEOB/LUQ8Y6/HdfFg=; b=GGWLHK+JkRmmmS1n5v99EFxue3b96NwaNT6JGqDFHkH3SJm9Aarm89ctL5Qu+XSJQ9He7bXqtiEQw5qHAyHqi5t9skskdvjwq2u+IfAta3nYlVakUfwEX4stn4suJDdLpPmUGS0E+eCzrL0H50mb46SBJnwQnrfMTQ6x/qnTIgw= Received: from VI1PR08MB3200.eurprd08.prod.outlook.com (52.133.15.152) by VI1PR08MB3040.eurprd08.prod.outlook.com (52.133.14.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1516.19; Wed, 16 Jan 2019 11:10:56 +0000 Received: from VI1PR08MB3200.eurprd08.prod.outlook.com ([fe80::1018:106:3294:4220]) by VI1PR08MB3200.eurprd08.prod.outlook.com ([fe80::1018:106:3294:4220%4]) with mapi id 15.20.1516.019; Wed, 16 Jan 2019 11:10:56 +0000 From: Richard Bunt To: =?iso-8859-2?Q?Pawe=B3_W=F3dkowski?= , "gdb-patches@sourceware.org" CC: nd Subject: Re: [PATCH v2 3/7] Fortran: Accessing fields of inherited types via fully qualified name. Date: Wed, 16 Jan 2019 11:11:00 -0000 Message-ID: References: <1542663530-140490-1-git-send-email-pwodkowski@pl.sii.eu> <1542663530-140490-3-git-send-email-pwodkowski@pl.sii.eu> <88ec6786-8834-7da2-207a-7392fd657e41@arm.com> <53cac622aea64147b2c1cd25feb16bdd@pl.sii.eu> <687ae24a-511f-1d32-025d-3c1e996a8e28@arm.com> <6a36a05571e94d01aafa6735e9f194ef@pl.sii.eu> In-Reply-To: <6a36a05571e94d01aafa6735e9f194ef@pl.sii.eu> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Richard.Bunt@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) Content-Type: text/plain; charset="iso-8859-2" Content-ID: <37B65B1E60EF8946ADFE4AD3438CE452@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00369.txt.bz2 I have no further comments on v2 and look forward to v3. Many thanks, Rich. On 12/9/18 8:40 PM, Pawe=B3 W=F3dkowski wrote: > On 06.12.2018 16:02, Richard Bunt wrote: >> Hi Pawe=B3, >> >> I was testing with gfortran 7.3.0 and ifort 18.2. On the latter I observe >> 2 kfails relating to the missing extends in the ptype output. However, t= his >> is because I do not have patch 4 applied. I will take a closer look at t= his >> patch with ifort 18.2 since I can analyze the implementation in action. >> >=20 > Ok, will wait (perhaps Wednesday) with v3. Pls, let know if there is=20 > something more to change. >=20 > btw, I have ifort 19.0.1.144 20181018 >=20 >=20 >> On 12/4/18 9:05 PM, Pawe=B3 W=F3dkowski wrote: >> >>>>> +gdb_test "whatis wp_vla" "type =3D " >> >> A small nit while I'm here: >> GDB tests needs to be uniquely identifiable, see https://sourceware.org/= gdb/wiki/GDBTestcaseCookbook#Make_sure_test_messages_are_unique >> >> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: continue to breakp= oint: ! After value assignment >> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: continue to breakp= oint: ! Before vla allocation >> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: ptype wp%point%coo >> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: ptype wp_vla(1)%po= int%coo >> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp >> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp%point >> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp%point%coo >> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp_vla(1) >> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp_vla(1)%point >> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp_vla(1)%point%= coo >> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: whatis wp >> 2 (gdb) PASS: gdb.fortran/oop-extend-type.exp: whatis wp_vla >> >> >=20 > Thx for the link. I will fix this. >=20 > Pawel >=20 >> Many thanks, >> >> Rich. >> >=20