From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id hC0FM7tosWoj3S0AWB0awg (envelope-from ) for ; Mon, 21 Sep 2026 13:26:19 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=q/vkFRev; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=q/vkFRev; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A07B61E01F; Mon, 21 Sep 2026 13:26:19 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EB4831E01F for ; Mon, 21 Sep 2026 13:26:18 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 566074BA9034 for ; Mon, 21 Sep 2026 17:26:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 566074BA9034 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=q/vkFRev; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=q/vkFRev Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazlp170130007.outbound.protection.outlook.com [IPv6:2a01:111:f403:c20a::7]) by sourceware.org (Postfix) with ESMTPS id 88E784B9DB61 for ; Mon, 21 Sep 2026 17:20:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 88E784B9DB61 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 88E784B9DB61 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c20a::7 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1790011216; cv=pass; b=QypCFpUBNcn64rAVhJZs1BBDgpLW3eg41Z55PNTH2CDkMtNSYenzq6SXm1ZsCN1w95rOgehwTHcOJLKEScWO59bPReoU532RzWsWqQcITfjZAHKW4h+sH1FlVqksllTX+eZVGx53Q3SawZp4mB+WLvEvkBwnWUrOmlfhuj/Sf1A= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1790011216; c=relaxed/simple; bh=cj+BxJHuzyYUMWB5xByxvdKVG12r0ZIP0jlH2UBgg6s=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=QubObtUC/wwdqJntoZcLsgI7qwFTNpVjs7iQw8pfAIPzdA7uwMMd8vlRx/75BUc6RcjjPxbKU9ZIWGWFVrEKToaPZg5W5MBY8SdNp0xjD4QyBSko0Nwjq1RrlLCjs0jYBGP6ZJuHbxGylH6OUtQaPL69r8poHe6pEVT+wjExhhA= ARC-Authentication-Results: i=3; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=q/vkFRev; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=q/vkFRev DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 88E784B9DB61 ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=SPw1275GZT4RE4h/ziPBPN4SZBtChDDDMALf4E8uy/GP5ydf52JfRBk+XnFLRBtN8pY/QoaFr8qAmDxwmjjfyyPBHVK2aILcuAWg9o+lilToFuSaRG8bRFupOq6Bqshrcnp51+HndDB0Nob+nee30isessMGDt1TOWu1xq9Hl+aGxl6/mPNXBazSY3yu6wgomgKBRB4SU9rQrPxIsHAdnbbX8ssYJ3UWWZ1LaX/IofXpr0ShTkBDuD/5FNkE4SCJDnVUTvKomUb8PwfSp2dNOF27UKjkwPq/VLIzk0FDE9/9GZZ2ECCsK52wxIIgycqxttF5ZimrougSj4fs3NL2KQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=51yKVbaNb/s4Wcct1qWLuOcluMb9tYAXBzU9Z3HvVqM=; b=kIM0mu7otPVH9W0UD+O5W24iqyOP7QFb4cf4pF8uL5+PUorUjYizSiVA7KnelyZ7Vi1eJrx1yJhlA+8vfGqOtwQRVhgzhVnRf2ZCku6g9LKR/tHzImjYbE77OBC3PrN9C+bpzjJ5b4OJrsp3fHP7+ss3dPBSBboETvh7Gleb7mlXk1CR4LJ41zRck6dDXsTEZmZIkPnMxS49/aSkp7i8SnwwcUOKtIaMG4Jx3coCxPNCQGdvXCYPkIl6EunFDqkQQV6oPPUAc9PYXOUfrWz/t1isRkJfAUJCWWWXZaR8DlvPiC413cFN8ZJ0ividSswQsx9pAar34HJu30uuQ0h1wQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=redhat.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=51yKVbaNb/s4Wcct1qWLuOcluMb9tYAXBzU9Z3HvVqM=; b=q/vkFRev7kK3R7Q7kx1gnDgt6GBNheL+IdeYJD6BmPTKtagW4XePXwF1Ef+CDVvxRLxoudEWZcpvRpYhW+s30Te8hhw51i8B4a+d2Bpou45TzNCqokvT7xVgxfZjAhFOJZHfcAo/L2QSXBuBu8XZrZ3SeMSKxAbodrGmjxJxg0Y= Received: from DU6P191CA0003.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:540::29) by AS2PR08MB8999.eurprd08.prod.outlook.com (2603:10a6:20b:5fb::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.13; Mon, 21 Sep 2026 17:20:07 +0000 Received: from MAD0EPF000008B0.eurprd04.prod.outlook.com (2603:10a6:10:540:cafe::94) by DU6P191CA0003.outlook.office365.com (2603:10a6:10:540::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.16 via Frontend Transport; Mon, 21 Sep 2026 17:20:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by MAD0EPF000008B0.mail.protection.outlook.com (10.167.241.132) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.451.8 via Frontend Transport; Mon, 21 Sep 2026 17:20:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Xt8Ufq2trIE2m4CbmKVpZ0pC7w8XdkZ6G7v2Fazg3EI7b3Ip1YfRLaM927qG9lFNe3n05P8Xh8nhSA0xs28DcrDPSvTa8UpnKz97LAXmw6b2BxBSh9UClJthVXUy6MZeeGJqqoK0YhRxAvBB+e5y6Pq0hkd+SBu3nBnYNYtqf44QIquaQHPYtiqaIIW3eEREm63qgzytWWfjJta9h+Ae0zw+f3N3hlGfD7IjU/pbVrCUXbqYDo1wa7X15qG0p2mSQJs34vHz2/sT7M6QERn+WK454mKyJRXi+MoTbpoC6xjnGVNU0HJH9P2Tu8T/2elVwRn6pdRAZrUNzn7J/HgcJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=51yKVbaNb/s4Wcct1qWLuOcluMb9tYAXBzU9Z3HvVqM=; b=A0A4TRsKCDPrY8MbwD6nxX000QvYHZvHN/b84ruX6lSDEF0zqyuXi7CbqSZuGuPTn7Dl0hXKA8sqbps0908wDKT9Urr06ROjemMppuC74PH/Uom/RAd0Hx6BeX2hFk/BS9IaNhYvFwaqeWUseykZPJN0rhV+4RryZruuUQ+xdmYZxcrxLxMhkA6C0mk3j0FPB+tQxS83UKTyUsmk0jt+c9ppUvhQXrRgDaj+pKy8Ufc6NziJYJT23R5IXgd2U9DA1vPrDG+ftZaE3Cl+2IHbJdkjPaepHDDRVGgPHTQWbqrxHaAeXa3l38MESbUxVSj1kIwc7+GECaaJQPpFQgmQgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=51yKVbaNb/s4Wcct1qWLuOcluMb9tYAXBzU9Z3HvVqM=; b=q/vkFRev7kK3R7Q7kx1gnDgt6GBNheL+IdeYJD6BmPTKtagW4XePXwF1Ef+CDVvxRLxoudEWZcpvRpYhW+s30Te8hhw51i8B4a+d2Bpou45TzNCqokvT7xVgxfZjAhFOJZHfcAo/L2QSXBuBu8XZrZ3SeMSKxAbodrGmjxJxg0Y= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB8659.eurprd08.prod.outlook.com (2603:10a6:20b:563::10) by DB9PR08MB7865.eurprd08.prod.outlook.com (2603:10a6:10:39c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.13; Mon, 21 Sep 2026 17:19:33 +0000 Received: from AS8PR08MB8659.eurprd08.prod.outlook.com ([fe80::96bf:2de3:5eab:70ae]) by AS8PR08MB8659.eurprd08.prod.outlook.com ([fe80::96bf:2de3:5eab:70ae%5]) with mapi id 15.21.0451.012; Mon, 21 Sep 2026 17:19:33 +0000 Message-ID: Date: Mon, 21 Sep 2026 18:19:32 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/6] gdb/linux-tdep: migrate linux_find_memory_regions_full to file_reader_t To: Andrew Burgess , gdb-patches@sourceware.org Cc: Simon Marchi , Thiago Jung Bauermann , Luis Machado , Luis Machado , Christina Joos , Kevin Buettner References: <20260825100912.514232-1-matthieu.longo@arm.com> <20260825100912.514232-6-matthieu.longo@arm.com> <875x0cdw4n.fsf@redhat.com> Content-Language: en-US From: Matthieu Longo In-Reply-To: <875x0cdw4n.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0410.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:189::19) To AS8PR08MB8659.eurprd08.prod.outlook.com (2603:10a6:20b:563::10) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB8659:EE_|DB9PR08MB7865:EE_|MAD0EPF000008B0:EE_|AS2PR08MB8999:EE_ X-MS-Office365-Filtering-Correlation-Id: 1c0e181b-024e-401d-9f41-08df18049529 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; ARA:13230040|376014|23010399003|366016|1800799024|4143699003|56012099006|11063799006|10067099003|22082099003|18002099003|6133799003; X-Microsoft-Antispam-Message-Info-Original: DPGxrYzr3E/iXVrS/S0GJY+15icDt06Rk4efEoXrgz9X2u/4GTmBNNrl5zX0JrtM/K/3M2784mEHcQ5n+yPwfaCL78NtTp1gRjdkoq6aDn16teBJYJdGZ0ch0V7/pS5UaUHaOBeNkyZtIXpiqtIOw8U4/DKWHqeqOhW1ZddIR2klyWAx3lnVO6P0gjnMGUZM+74mZsUatyig+PDEKHBco9NfNJXkEgMfcV/eZ6PcUWRmoJK7+KmcoVT144MoDcfyZgFzFhQIyzeM1+py2zKOdR8QrF6Kdz234zM17sAdJYioEMU/UWSxcyXy5/gnUci9IQWHpIpn7uwjGzQk/OQvzdHfzp6ttYxd5+oQ4OQcUmnWC+5mR2z/mx0Ch/Hk7itEmPDM7E5LQmj7TPNwcN/nx4zhAs+0q7YZkX9+c5FPwrNp4cOLWgCRARZ4MMQCOyIHXdJG0GbkzDvpUlUfFV4w3XR+1DlQS4lukRp2dDMFTMT2nxHUL2cn3FfBSkULrbttkyQZA4EaAdSEWvfBX631OkqsiujtvMzTwo+9lSqJeZNWqqMnqXMVEnhd1xkMlxZVFFmYX+W2kCKsCYpkLsOFqupInEQuDW6FG3OyIKvCGHa14vr7KdkjPMntE3D/majw X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR08MB8659.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(23010399003)(366016)(1800799024)(4143699003)(56012099006)(11063799006)(10067099003)(22082099003)(18002099003)(6133799003); DIR:OUT; SFP:1101; X-Exchange-RoutingPolicyChecked: P02vd07ynVVT0GzuIZktkq1xI0UI8wtaX8zwhgkDX69d89V80SCMenRPZpqHgBIxSdYAEySDqd7JAyClQV1TSI+whJhFZ8wPxMn0eKJYV7wrneGWs8YgX5nGyIR0b95cgl9sVXHoCTWjWAleYCMQsKmobkd0mxz9dmhAFXZ0Sb07gNQqYp3HGW9E+AL6JPwyRXolp+Dv84mBaSkYXsLsl1lcdljHxKSNdVyi7v2WgY4xVhWGORxvXdwgs+gyGJlYbyrleZWzlTe1r8s9OBki+t02z3CeY617x/QMaOyDYJMxaQSTJYiH2MH1gbAQaExxmAO8/4YW5ymlRO+GfnYIpQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7865 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: MAD0EPF000008B0.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: eb128846-0b02-4345-5607-08df180480b9 X-Microsoft-Antispam: BCL:0; ARA:13230040|30052699003|23010399003|35042699022|36860700016|82310400026|1800799024|376014|14060799003|11063799006|56012099006|4143699003|10067099003|6133799003|13003099007|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: liQw0thCceQGyETMuReopcmi1W8nSKwDq9nwsjTAwkJ2qCnCpbKX9K9Ye1XqFkulxkdVJS7m+MTW15ZQgCM7M4J3dse07FZqrz8JmmpwQPvnz22hhJoOpecndnC/bRgz+ueoAWj+Y6DmfO6Kqrz+FW5YVCj0JnXP6kmZdW09cUvXwuoi94OuyCTcFfovp0DCa2Ht8daGO4BQD2+cgfLpmLGQxgms17xdlqY+2lYLcQxvSf44Yw+PrQ57OlkihnOZkbdk5H6hQV3k5CvS8cSrp3LmMYnU71hEHj59PucbY1LwQMONZjjkby2SMY+43UhtMcvcmoaoWqQI64riDttW7djgYSCPOWXZxH5St2Z4jZ/Ux4ilMHT60GhjDxgakKmwvBjrLhm0Ad/g7HaRyt8pB1CuKTJsvqC+0i6if2p8tabDkd3B6GUyTsrUW/b8lEL/cMM3NXaREIEodLpUMDE69Y+Pxv6XqlGdssC/qmMXxL0VmPYm0IKNhygrPO2o2+hb+GzXAipam7hjGcus6BVKeBvx7O7XRkjgHc40rje+6c66hb87IiqPl23toIlQXxmjHQM/ZMdmQIlFkjSinGezdPIL6xuZo1l5bY7eag2R2l/k01fbEvZmEkOuXTwSwpMH6S950VXTcjkja0yUd03VaM7+IAf5TD9HHlABqglfpGQ= X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(30052699003)(23010399003)(35042699022)(36860700016)(82310400026)(1800799024)(376014)(14060799003)(11063799006)(56012099006)(4143699003)(10067099003)(6133799003)(13003099007)(22082099003)(18002099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: HEQiqWTW9bpAIltSCvImH7lYVSTU9FggneVTT2y4YpA0gaUzyVmzhbsC+GH4KqD0r/2NwRyshTYNqGqcnIZO1JHl4VrW7mApUDTKwxv+g6fyf2ediEArxMxVPDo2pVbH8wzmCA/Wj6jGzLAhJC/8tSDcTuJqaQOO7PTPLraUQIfI+f+kX0hAAkNX7sdDAoA87fgJQizLsddRruMpXbsPQftz23rH+bHpBFi0YZfgs81xMEnlj0cNw/ySCd6Lje52TNlEgiHZ94OY+wRZyQTR9xLQmsnfDDZVl4l3+lOh+2RG/bm7yI8gWG3l0M+WOWKrLmBJQxmeB9XFIyjCUbOsaURiqPeAGTA3FF8sHGETSRyh2G0s5P0Z8ZP63lSmdAqQMauZ2cOdbo3UtIi66hTMVtr4e/y7rMSdjVt5VJxqfTrbqoc3xTyLWWP0L6VEk6sp X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2026 17:20:06.9750 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1c0e181b-024e-401d-9f41-08df18049529 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: MAD0EPF000008B0.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8999 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 11/09/2026 09:34, Andrew Burgess wrote: > Matthieu Longo writes: > >> The previous implementation of linux_find_memory_regions_full could >> still return success even when none of the /proc/PID/[s]maps files >> existed, or all reads returned 0 bytes (this last case can happen on >> Linux when the thread-group leader has exited). >> As a result, the function could incorrectly succeed, allowing core >> dump generation via the gcore command. >> This logical defect was allowing, by chance, the function to return >> success and hence, allowing fortuitously the coredump generation via >> gcore command (see gcore-stale-thread test for more details). >> >> A previous patch in this patch series fixed this issue by using the >> first LWP ID of the current inferior instead of relying on the PID. >> This patch adapts the code to use file_reader_t and makes the function >> return an error if reading any of the procfs files fails. > > This commit message seems out of date. As far as I can tell the issue > you are describing here isn't fixed yet. > > Further, I took a look at gdb.threads/gcore-stale-thread.exp and > couldn't find any text talking about this issue, so saying "see > gcore-stale-thread test for more details" isn't super helpful. > > It doesn't sound like this patch was actually aiming to fix the bug you > described anyway, just to convert to the file_reader_t class, so > honestly, I'd just drop all discussion of the previously fixed bug. > > But if this patch is fixing the bug then I'd expect either a new test to > be added, or if gcore-stale-thread.exp does hit this bug, I would have > expected the test to be updated now that the bug is fixed. > > Thanks, > Andrew Sorry, I missed that. This commit can actually be squashed with the previous one. Fixed in the next revision. Matthieu