From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Z2/7KiIONWAHegAAWB0awg (envelope-from ) for ; Tue, 23 Feb 2021 09:16:02 -0500 Received: by simark.ca (Postfix, from userid 112) id A2CB41EF78; Tue, 23 Feb 2021 09:16:02 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9CFEB1E54D for ; Tue, 23 Feb 2021 09:16:00 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D6EFC388A838; Tue, 23 Feb 2021 14:15:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D6EFC388A838 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1614089759; bh=BHSiubWZBW9RCiA60HL4qizbJG818WgO0Jifmz05Gwk=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=ndbyXa+8EObVYdEmCqc+xuF4u28P1lat+1ildTYqJOc04vihEyfjXiskcVRO0yM1R /ISdaEnpC0Ljfh77quLxmj4FkSIv04oEof5sRkfmerzgaGOaf5XjqvRhtXZjUJbbMp s+MuV1zApDiez3A4tGTjuuUaewKksMUaqj0+ZTlc= Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2084.outbound.protection.outlook.com [40.107.223.84]) by sourceware.org (Postfix) with ESMTPS id 8817D3870851 for ; Tue, 23 Feb 2021 14:15:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8817D3870851 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e6VNIGlxiEnewGHoTNxN1xYZRc2xzlIJ5a8lBEeJhV+syXlUh0NIdjQs/1/b1jD4B2DyhkcXV/k/9WxTBlpBmXnK2tZq6FHPMpdOggi/Uzd6BNl5/PULPsu8PCpAxPwKbZ8c5vRfBNXBg0/N2PbLLAXeDn1orHSmrfBUIkuOfcQNMQDGaplizzTVH7BJ086fOyVKIh6s3BqHeW9/F19Dp6n36GZcoP5Gzxu8jkjmxnaSKk66OiTZbHM94c/rFQDF43UpuxQc/tdZntbcwIfabcfimCC7vmj5Tzbi4wJn1HG+5KH6eS5z4Evmx69I8LcH2vF6s9+sldRSLdbL0zN03A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BHSiubWZBW9RCiA60HL4qizbJG818WgO0Jifmz05Gwk=; b=bfIAyND7m1k3otSqXmeOvZHQSoL02RNBVf4h3lzgYl438BZwbZqqNBxBpbDg0abIaLUdkdYl8fZcaRIjNjVnXM6+McRkCY6UdJoRuPjlLFnyCxfqhT9ynx/hZ7SL/FkemrE5Nw3Rb273im79HYYi9VThnbYXIMbVE72tFKggiZcLFLD2sJIne6lpjEoAn4htnn2+hotvGbpsw8498r5Pe5EO/+iyzu/a/0fGIj16h0VymmBNf4ul1azMMTtayb09JHzigHQj6VsKiQwcyAVPg/f+tHtVV2ztG2yb+Rnb2PX9OMLbwxrg+pU603qtnOicCFe4wcFR/MXmKA+FpuCJDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) by DM6PR12MB3292.namprd12.prod.outlook.com (2603:10b6:5:18c::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.27; Tue, 23 Feb 2021 14:15:55 +0000 Received: from DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44]) by DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44%3]) with mapi id 15.20.3868.033; Tue, 23 Feb 2021 14:15:55 +0000 Subject: Re: [PATCH 01/30] Replace the symbol needs evaluator with a parser To: Tom Tromey , Zoran Zaric via Gdb-patches References: <20201207190031.13341-1-Zoran.Zaric@amd.com> <20201207190031.13341-2-Zoran.Zaric@amd.com> <87bldirnwm.fsf@tromey.com> Message-ID: Date: Tue, 23 Feb 2021 14:15:50 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <87bldirnwm.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [2a00:23c7:5a85:6801:3c68:1988:3c97:9289] X-ClientProxiedBy: LO2P265CA0311.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::35) To DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2a00:23c7:5a85:6801:3c68:1988:3c97:9289] (2a00:23c7:5a85:6801:3c68:1988:3c97:9289) by LO2P265CA0311.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.32 via Frontend Transport; Tue, 23 Feb 2021 14:15:54 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 5520bc65-06b0-4268-9120-08d8d80588b0 X-MS-TrafficTypeDiagnostic: DM6PR12MB3292: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LGj/UwNmNEIvEsxnpFTGRuKH7oL3lvuniAc0FsqhbgohlCgcvsZ8Y4dAJLE6sS8FTKtIUC1PSsO+9orvuhoP/HZ5/TqRo3T/rMDFs3rsZhhUQp2pWcNup4NWbhODx0HrjEGwpM1ihETH/SHALlzfsC8ggjB+HS3uQvC8i6pPgcWGFv94KE+UD7l4sqnjk4T/EEOZFGBRkO+EPq509y0m0zEMZ43hWcX7HhQr5odb2Broj8UFfpGunXKBcul3XdD+oskvVrDK2LS6ZFGJ53+SSY7wfdu7ucKTgnY6ksf4nhyhEURKr9sVhhqPbGNaOeSIMSGJ6KPVxnkwrVU3ev4zfL43nYDdTELKRM0DoL5aKymQJdtdKzvjmAc9on31B7+rulKcrh0NE6HOSUg60F2oD8f04Qr4YOk1OcK4OHlz3VuFmpGPHu0swF1uciOWWBNDAbAQtwgHtmn767pljQqm4iSiT0xaWkPmfo0ZsIHI2YFMHAKZ5l1hDo2FMag7O0qHYQaiOEoZJLK6Y2kXWmHHW5xQO7udqeRiGxN89ruXGIhXrMnm4FJ5gqA7S+1XXJNUq8GW9uIQxcBPra6N6gYuoIvY6OomWLfaxE1m9RGN0Tk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2762.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(376002)(346002)(366004)(39860400002)(396003)(66476007)(86362001)(316002)(83380400001)(66556008)(8936002)(6666004)(2616005)(52116002)(31696002)(16526019)(6486002)(110136005)(4744005)(8676002)(5660300002)(31686004)(66946007)(2906002)(478600001)(36756003)(186003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?OWVic3lRNldTM0x6dWplUHlCWGloZmZRQ0JmaEREd20zNkI0UDZ0T0JVVy8z?= =?utf-8?B?U2FZVkpNTGgvTFNMYmFSQW1nLy9FblJoZGZmeUxrY1psNi9pQThkQ3NqVTdw?= =?utf-8?B?V1c1VXZGSU9uRFExQldnWk0vcjZmSmpGUVIrZ2Vua1ZqRTkyWDFadmhleWJZ?= =?utf-8?B?YTFXeWFFdVdEUGQ5T3VOYkl5VllRamkvQ3VjZXBTa0NrS1lMbGx6Z2doYjRs?= =?utf-8?B?bEh6WEhUTWRNcjlLUWk2alJDbWRpcjVyc2hQaFFMUG1INWF5U3RnZUFmVFR4?= =?utf-8?B?SVBndGNGQzhFWXhZQ2lYRUp3NXlXcWttUXBXeUNpMjBaSVdMT1prZEt1a1k1?= =?utf-8?B?ck9WVG9WbHM2T3VJeThwY3NyTFJLa0lscXNWZTBnSUpyTiszUkJ4MEVJRitX?= =?utf-8?B?L1hRL29tV3JqcEIxRFhiYXV5L0lDcTFZbzZsZ0ZOK1ZibFVrRlRaZkFOcmJH?= =?utf-8?B?YzdwWFlxclJFcmc5RHpYNHFCcXhqdjdlelhZVzFQb2tuTTRnSHFITUVXbWxE?= =?utf-8?B?SWtMSWJkL2RvdE5zQUlqenVnaGhORkFQeDFueTZxTFByenkxV3ZnOVFRVUsw?= =?utf-8?B?NEthWkZncjBhTEtuaG9kS216M0QwK1VjQUE2VWQyRFNNZGtCM0lxT094Ylc5?= =?utf-8?B?a29lYXVCUGNrYmYyVlVvaUpVcUoxUHRLN1RwSGNuNVpTc2lDdmJtbVZraHVm?= =?utf-8?B?VWh5WS92dWhqYStiNHkxNHZTektkb25EWUhObnM1MGdrSFd1eFJQWlVuVHhm?= =?utf-8?B?ZlZXRHpldlFzQW5GWVJ3RkppV1FNeXY1dCs4RzNzWnVxU0R1U2tWTnY3aTY3?= =?utf-8?B?NkJ1aEsxNDRMbDJHU0JVVk1NYlZsR0pKYmJ6K09HRElxclF6NjRqbE5zaGcy?= =?utf-8?B?OXNGT0VTU1hpeDVRM2JmeUFRMVlYYVRySlg2cTRZVmJzRFJsV1hHemI5S1Yz?= =?utf-8?B?a2JSOUY5R05RK0drU2F2cGVZaXdIa3VWT1p0ZGVWQ2pYbFJaaVRhL0ZaMkNH?= =?utf-8?B?c2NYQWRQRXRNeDJSQzVWZG83bzV0dVRuaGtwY21DeW5ITXZSNExkZjk5Vm02?= =?utf-8?B?cWFMQWlxVFg2aHpWWjgvTW1tbjRQUlVPZXpIOXFveTUwalFOSXh3M0JWZ1hH?= =?utf-8?B?Uml4SXJlQkFRU1V2VkFBdFBucXczTXp5M3hBaE4wcG1CclBEMEwxcHhLNVgw?= =?utf-8?B?SEdScm9YT2ZTSXBJL3FIV3h5blVjeEN0ajYrVWtDMUxhOGJHdTB3UnZ5bDcx?= =?utf-8?B?WDRqVlN4WHFQQkhIWTZJalJKRWZHVHkzRTYvRXcvM09QcG9hUDFadndMa2s1?= =?utf-8?B?MWxhblZTZVozWkZoanRhcmtocmZ4Q2RrZi96aGd5TUpzSDNqZkJRNG5XbDFY?= =?utf-8?B?L25yUnptRkVNS2RGMWFNMHd4SzBTUHZGMmpkcHQwV2VydjhyeDFFWDhFZXI3?= =?utf-8?B?LzhOQ1RnQjNrL1FyQWZQVklKa093YnJ3RXhxUHFEWTdBSlBHOTljL0Y4TTBq?= =?utf-8?B?eVNsOUNqaUd3Mlc3dDdDNGozWUFGSkxMcDBXRmRpd1o1MG54dG00UVY5VHRv?= =?utf-8?B?SlN3VG9lT2l6WktFWmNZZGpzSjVXc0ZDeGJkM3lvc0JldG1RVFUyc1hoRHVB?= =?utf-8?B?U2EreWk1TnR4d0Q2Ym9sbWxwQy9PWmVodW41ZDdsb2o2b1BJb1FTZ200SVpo?= =?utf-8?B?OU4wV0E1cHVRUldWT1p0aVNxNkVlNTY2aTAzQmxjUXVTOHZ6aU91VXlWdmpQ?= =?utf-8?B?dytlMmJOS3dXSmUvWHZGakdMcG1LQWZGa2swa0diaWM0TkZzelQ3R0E1RGRn?= =?utf-8?B?ZTFVcGE2WGdoNmMvUUVRV2lDWExFc2dCSks2NG9lcWdVaU1hSmkwaUdyclVz?= =?utf-8?Q?N7ioudDYq6qXS?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5520bc65-06b0-4268-9120-08d8d80588b0 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2762.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2021 14:15:55.6332 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qbeM8HLsNfJLjUhW68VwKWKZ2R273ly8e4hqBkfs0HskOYFl7MszyiZMhp7hbwRIV9SPbcmk/PqFx9G5MSrrCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3292 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Zoran Zaric via Gdb-patches Reply-To: Zoran Zaric Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>>> "Zoran" == Zoran Zaric via Gdb-patches writes: > > Zoran> This patch addresses a design problem with the symbol_needs_eval_context > Zoran> class. It exposes the problem by introducing two new testsuite test > Zoran> cases. > > Zoran> + while (op_ptr < expr_end) > Zoran> + { > Zoran> + enum dwarf_location_atom op > Zoran> + = (enum dwarf_location_atom) *op_ptr++; > Zoran> + uint64_t uoffset; > Zoran> + int64_t offset; > > IIUC this is the same as the earlier patch, that marches through the > bytecode linearly. I think I sent comments on the earlier submission. Hi Tom, I am doing a bit of a rework on my patch set and now in one of the later patches (when I the evaluator redesign is complete) the symbol needs parser is removed and a new evaluator is used instead. This should address the concerns you have about the linear scan. Zoran