From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67051 invoked by alias); 1 Jul 2019 19:29:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67035 invoked by uid 89); 1 Jul 2019 19:29:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: mail-wm1-f51.google.com Received: from mail-wm1-f51.google.com (HELO mail-wm1-f51.google.com) (209.85.128.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 01 Jul 2019 19:29:21 +0000 Received: by mail-wm1-f51.google.com with SMTP id u8so728269wmm.1 for ; Mon, 01 Jul 2019 12:29:20 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id z25sm703693wmf.38.2019.07.01.12.29.18 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 01 Jul 2019 12:29:18 -0700 (PDT) Subject: [users/palves/format_strings] Make printf_filtered support the gdb-specific formatters too To: Tom Tromey References: <20190605020116.1550-1-tom@tromey.com> <1ee4bd6b-4cdf-f3a9-74af-0843bf123a8b@redhat.com> <87lfygi1x0.fsf@tromey.com> <32872d6a-15d6-9718-59ae-957694e114c9@redhat.com> <87imtjhj6b.fsf@tromey.com> <625cd0ba-058d-d4bf-8ba3-8676f335b0f3@redhat.com> <87blzbep47.fsf@tromey.com> <2180f72f-da10-5333-90a1-666ba3bd145e@redhat.com> <87imtjbrmx.fsf@tromey.com> <871s056yjw.fsf@tromey.com> <87wohx5hir.fsf@tromey.com> <87a7dxps66.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Mon, 01 Jul 2019 19:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <87a7dxps66.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-07/txt/msg00030.txt.bz2 On 7/1/19 6:42 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> Well, you used printf_filtered the new patches, but that doesn't work > Pedro> with the new format specifiers, yet. :-) > > Oops. I meant not to do that, but of course made a mistake. > > Pedro> If we want the new new formatters to work with printf_(un)filtered, > Pedro> the patch below fixes it by making printf_(un)filtered defer to > Pedro> cli_ui_out::message for format processing, instead of to > Pedro> string_printf (and thus to vsnprintf). It's maybe a bit roundabout, but > Pedro> I couldn't think of a better/easier way. > > We should probably do this, just to avoid future mistakes along these > same lines. > I merged this one to the branch as well. Thanks, Pedro Alves