From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54947 invoked by alias); 14 Oct 2019 15:18:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54934 invoked by uid 89); 14 Oct 2019 15:18:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1434, emails, our X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 Oct 2019 15:18:45 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x9EFIcVT010573 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 14 Oct 2019 11:18:43 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca x9EFIcVT010573 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1571066324; bh=RCtkhzDQsc+0NHNDYd7E1l4L3Ahc4Fxs9OONoqX9KYI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Q3FCst3sh+KoARd74843yHf6RwnlupxFVnB+MN92wrQx/tdSor8cJcXYhd9bt6Fhe sl9RvGfMouH2ZMZdW0v0llTz1o7uSaeU9xKkRwMMN2VXB/X457hF4QxumxV69cg1Hp aDN7qBONr/gpEth66JhKwPON9cq2sHj9GA8l10Hc= Received: by simark.ca (Postfix, from userid 112) id 645E91E79E; Mon, 14 Oct 2019 11:18:38 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 027A51E059; Mon, 14 Oct 2019 11:18:37 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 14 Oct 2019 15:18:00 -0000 From: Simon Marchi To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: remove unused includes from dwarf2read.c In-Reply-To: <83r23fie80.fsf@gnu.org> References: <20191013045218.3261363-1-simon.marchi@polymtl.ca> <1c1f820fa507243fd7a2096ec3eb2454@polymtl.ca> <83r23fie80.fsf@gnu.org> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.10 X-IsSubscribed: yes X-SW-Source: 2019-10/txt/msg00342.txt.bz2 On 2019-10-14 10:38, Eli Zaretskii wrote: >> Date: Mon, 14 Oct 2019 10:21:50 -0400 >> From: Simon Marchi >> >> I pushed it after Tom de Vries reviewed it on Gerrit: >> >> https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/24 > > Does this mean that now we need to look for patches in two places? > Can Gerrit be set up to forward the review comments to the list? > > Also, if some of us decides to do the review on Gerrit, does it mean > all the others need to do that as well? Hi Eli, Yes, Gerrit can be set to send notifications to an arbitrary email, so we can set it to send them to gdb-patches. We have talked about that earlier, it's just not done yet. I'll look into it right now. As long as we use Gerrit and mail patches in parallel, people are free to send patches using the system they prefer. I think it's simpler if reviewers use the system that was chosen by the patch author (reply on Gerrit if the patch is on Gerrit, reply by email if the patch is by email). In theory, it is possible to reply to some of Gerrit's email notifications: https://gerrit-review.googlesource.com/Documentation/intro-user.html#reply-by-email But our server isn't configured to receive emails for the moment, so that won't work. Reading this page, I'm not sure if responding to a "New change" notification would work, we'd have to try it. Simon