From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40785 invoked by alias); 21 Dec 2018 18:06:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40773 invoked by uid 89); 21 Dec 2018 18:06:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,MIME_BASE64_BLANKS autolearn=no version=3.3.2 spammy= X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Dec 2018 18:06:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/relaxed; q=dns/txt; i=@ericsson.com; t=1545415595; x=1548007595; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=mxWT4lBXwD0kZJR5H+o5l9gG6xPHP902l5FX9Ph8Pts=; b=DqD6EKmX4h8WNDse6JHm88Lx05Q5zSuYgmRZzCE8kbiy8mmbh87DwKJMfOvSQzpP Qx7C/lk8+QoLpdmfI4VPkc0ce0zkutagb8k4txT/yQ4rjJWkjvOT2qhI8Apkl/tu mgWHUWUsAvswK0GVdOoTxLdr0P/JHXCVUZP5jBbNoFo=; Received: from ESESSMB505.ericsson.se (Unknown_Domain [153.88.183.123]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id D0.B7.01583.BAB2D1C5; Fri, 21 Dec 2018 19:06:35 +0100 (CET) Received: from ESESBMR501.ericsson.se (153.88.183.129) by ESESSMB505.ericsson.se (153.88.183.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Fri, 21 Dec 2018 19:06:34 +0100 Received: from ESESSMB505.ericsson.se (153.88.183.166) by ESESBMR501.ericsson.se (153.88.183.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Fri, 21 Dec 2018 19:06:34 +0100 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB505.ericsson.se (153.88.183.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Fri, 21 Dec 2018 19:06:34 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mxWT4lBXwD0kZJR5H+o5l9gG6xPHP902l5FX9Ph8Pts=; b=g3L1sPBt6rG5b3vTWWA49ZIlyar2QD4fp9rjc2fQf2m5+S1QVEIdEt9U7CRmcSHG0Kz/Tn9+uscwa8hSsAaKgXnbdSDkVBx3hDs+l1Zajlz0TdZ058IKYe+pKdjp5cLcGDxMYM+E0NzrK4EqAEswdN4IlDyTDhHmomXeUjux7ZU= Received: from BYAPR15MB2390.namprd15.prod.outlook.com (52.135.198.30) by BYAPR15MB3432.namprd15.prod.outlook.com (20.179.59.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1446.17; Fri, 21 Dec 2018 18:06:31 +0000 Received: from BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::a143:f30c:dd42:3af9]) by BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::a143:f30c:dd42:3af9%4]) with mapi id 15.20.1425.025; Fri, 21 Dec 2018 18:06:31 +0000 From: Simon Marchi To: Tom Tromey , Paul Marechal CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH] gdb: Fix "info os " command Date: Fri, 21 Dec 2018 18:06:00 -0000 Message-ID: References: <20181217221253.13314-1-paul.marechal@ericsson.com> <877eg2ss5u.fsf@tromey.com> In-Reply-To: <877eg2ss5u.fsf@tromey.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 Return-Path: simon.marchi@ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00256.txt.bz2 T24gMjAxOC0xMi0yMSAxMjozMSBwLm0uLCBUb20gVHJvbWV5IHdyb3RlOg0K Pj4+Pj4+ICJQYXVsIiA9PSBQYXVsIE1hcmVjaGFsIDxwYXVsLm1hcmVjaGFs QGVyaWNzc29uLmNvbT4gd3JpdGVzOg0KPiANCj4gUGF1bD4gUnVubmluZyBg aW5mbyBvcyBzb21lVW5rbm93bk9zVHlwZWAgaXMgY3Jhc2hpbmcgd2hlbiBn ZGIgaXMgYnVpbHQgd2l0aA0KPiBQYXVsPiAtRF9HTElCQ1hYX0RFQlVHOg0K PiANCj4gUGF1bD4gCS91c3IvaW5jbHVkZS9jKysvNS9kZWJ1Zy92ZWN0b3I6 NDM5OmVycm9yOiBhdHRlbXB0IHRvDQo+IFBhdWw+IAlhY2Nlc3MgYW4gZWxl bWVudCBpbg0KPiBQYXVsPiAJICAgIGFuIGVtcHR5IGNvbnRhaW5lci4NCj4g DQo+IFRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLg0KPiBTb21lZGF5IEkgaG9w ZSB0byBzZW5kIGEgcGF0Y2ggdG8gZW5hYmxlIC1EX0dMSUJDWFhfREVCVUcg YnkgZGVmYXVsdA0KPiB3aGVuIGJ1aWxkaW5nIGdkYiBpbiBub3QtcmVsZWFz ZSBtb2RlLg0KDQpZZXAsIHRoYXQgd291bGQgYmUgbmljZSENCg0KPiBQYXVs PiBUaGlzIGlzIGEgcmVncmVzc2lvbiBpbiBnZGIgOC4yIGFuZCB0aGlzIHBh dGNoIHJlc3RvcmVzIHRoZSBiZWhhdmlvciBvZg0KPiBQYXVsPiBwcmV2aW91 cyB2ZXJzaW9ucy4NCj4gDQo+IFBlcmhhcHMgaXQgaXNuJ3QgdG9vIGxhdGUg dG8gcHV0IHRoaXMgb24gdGhlIDguMiBicmFuY2gsIGFzIGl0IHNlZW1zDQo+ IHNpbXBsZSBlbm91Z2guDQoNClllcywgaXQncyBvbiB0aGUgOC4yLjEgbGlz dDoNCg0KaHR0cHM6Ly9zb3VyY2V3YXJlLm9yZy9tbC9nZGItcGF0Y2hlcy8y MDE4LTEyL21zZzAwMTY3Lmh0bWwNCg0KPiBQYXVsPiAJUFIgZ2RiLzIzOTc0 DQo+IFBhdWw+IAkqIHRhcmdldC5jICh0YXJnZXRfcmVhZF9zdHJhbGxvYyk6 IENoZWNrIGZvciBlbXB0eSB2ZWN0b3IuDQo+IA0KPiBQYXVsPiBnZGIvdGVz dHN1aXRlL0NoYW5nZUxvZzoNCj4gDQo+IFBhdWw+IAlQUiBnZGIvMjM5NzQN Cj4gUGF1bD4gCSogZ2RiLmJhc2UvaW5mby1vcy5leHA6IENoZWNrIHJldHVy biBmb3IgdW5rbm93biAiaW5mbyBvcyIgdHlwZS4NCj4gDQo+IFRoaXMgaXMg b2suDQoNClRoYW5rcyBmb3IgbG9va2luZyBhdCBpdCwgSSdsbCBwdXNoIGl0 IHJpZ2h0IG5vdyAob24gbWFzdGVyIGFuZCA4LjIpIG9uIFBhdWwncyBiZWhh bGYuDQoNClNpbW9uDQo= >From gdb-patches-return-152915-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri Dec 21 18:17:03 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 64313 invoked by alias); 21 Dec 2018 18:17:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 64297 invoked by uid 89); 21 Dec 2018 18:17:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=mach, HContent-Transfer-Encoding:8bit X-HELO: mail.baldwin.cx Received: from bigwig.baldwin.cx (HELO mail.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Dec 2018 18:16:59 +0000 Received: from John-Baldwins-MacBook-Pro-2.local (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id 265B810A87D; Fri, 21 Dec 2018 13:16:56 -0500 (EST) Subject: Re: [PATCH] Please define thread_info as struct thread_info (and other stuff) To: Svante Signell Cc: Tom Tromey , Andreas Schwab , Simon Marchi , gdb-patches@sourceware.org References: <000db1d81a0c415190b6648222ed29db7f927df9.camel@gmail.com> <87d0q13w6b.fsf@tromey.com> <878t0j4ykk.fsf@tromey.com> From: John Baldwin Openpgp: preference=signencrypt Message-ID: <46460e96-bdc9-02b5-77a8-769ad4a2e9f9@FreeBSD.org> Date: Fri, 21 Dec 2018 18:17:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 MIME-Version: 1.0 In-Reply-To: <878t0j4ykk.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00257.txt.bz2 Content-length: 1810 On 12/20/18 2:34 PM, Tom Tromey wrote: >>>>>> "Svante" == Svante Signell writes: > > Svante> Seems like nothing is happening so far. Did you expect me to > Svante> take action on this issue? Or is this a low-prio problem for > Svante> you, Hurd being a second class citizen? > > It's not so much second-class as that the usual way gdb development > works is that ports need maintainers, and the current contributors are > pretty busy and/or have other interests. > > I took a quick look at it and one question I have is whether > nm-i386gnu.h really needs to include any of the headers it does. defs.h > already includes unistd.h, and regcache.h should probably not be needed; > and removing the mach includes would at least reduce the number of spots > needing the "struct". Could you try removing these lines? > > Also I happened to notice that file declares gnu_target_pid_to_str -- > but I didn't see a definition. So perhaps that could be removed as > well. I think this entire file can probably be removed. The only useful content it has that I can see are the THREAD_STATE_* macros, and those are only used in one file: gnu-nat.c. You could just move those there. If in your pending out-of-tree patches you need them in multiple files, you could move the macros to gnu-nat.h. If you have different versions (64-bit vs 32-bit), then I think it would be fine to use #ifdef's to define the appropriate version in whatever file you move the macros to. That is probably the simplest and quickest solution as moving everything into a gdb namespace is probably a fairly large (and tedious) patch. -- John Baldwin                                                                            Â