From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4601 invoked by alias); 25 Sep 2017 17:09:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4591 invoked by uid 89); 25 Sep 2017 17:09:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=inappropriate, risk X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Sep 2017 17:09:27 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0E75E81DE5; Mon, 25 Sep 2017 17:09:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0E75E81DE5 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id F1B7E6F430; Mon, 25 Sep 2017 17:09:24 +0000 (UTC) Subject: Re: [pushed] microblaze-tdep: Add ATTRIBUTE_PRINTF to microblaze_debug To: Michael Eager , Simon Marchi , gdb-patches@sourceware.org References: <1505995878-10687-1-git-send-email-simon.marchi@ericsson.com> <078ea0b6-71aa-f74d-33fc-859322d4668a@eagerm.com> <441bab33-67b9-be36-e4b7-c22e6936a7bf@redhat.com> From: Pedro Alves Message-ID: Date: Mon, 25 Sep 2017 17:09:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00759.txt.bz2 On 09/25/2017 05:43 PM, Michael Eager wrote: > On 09/25/2017 09:06 AM, Pedro Alves wrote: >>> but the better fix >>> seems to me to >>> be to turn off the obviously inappropriate -Wformat-nonliteral option in >>> microblaze_debug() using >>> #pragma GCC diagnostic ignored "-Wformat-nonliteral" >> That doesn't make sense to me. > > The argument passed to vprintf_unformatted in microblaze_debug is not a > string > literal. The diagnostic message is correct. If you don't want the > diagnostic, > turning it off seems correct. The diagnostic hasn't gone away. Instead, a warning is now emitted one level up, at the microblaze_debug call sites, iff someone passes a non-literal string as format string by mistake. That makes total sense, because microblaze_debug is just a wrapper around *printf_unfiltered. > This is somewhat moot. All uses of microblaze_debug use literal string > formats, > so adding ATTRIBUTE_PRINTF is OK. And if someone passes a non-literal format, we'll get a warning then. If we suppressed the warning inside microblaze_debug as you were suggesting, then we'd risk passing a non-literal as format string to vprintf_unfiltered. That's the whole point. Thanks, Pedro Alves