From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33879 invoked by alias); 19 Jun 2017 20:22:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 33861 invoked by uid 89); 19 Jun 2017 20:22:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-21.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_SOFTFAIL,UNWANTED_LANGUAGE_BODY autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 Jun 2017 20:22:26 +0000 Received: by simark.ca (Postfix, from userid 33) id D35E01E5F4; Mon, 19 Jun 2017 16:22:27 -0400 (EDT) To: Yao Qi Subject: Re: [PATCH 02/25] Adjust the order of 32bit-linux.xml and 32bit-sse.xml in i386/i386-linux.xml X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 19 Jun 2017 20:22:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org In-Reply-To: <1497256916-4958-3-git-send-email-yao.qi@linaro.org> References: <1497256916-4958-1-git-send-email-yao.qi@linaro.org> <1497256916-4958-3-git-send-email-yao.qi@linaro.org> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.5 X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00539.txt.bz2 On 2017-06-12 10:41, Yao Qi wrote: > Exchange the order of 32bit-linux.xml and 32bit-sse.xml in > i386/i386-linux.xml, to align with other i386 linux .xml files. > > gdb: > > 2017-04-27 Yao Qi > > * features/i386/i386-linux.xml: Exchange the order of including > 32bit-linux.xml and 32bit-sse.xml. > * features/i386/i386-linux.c: Regenerated. > --- > gdb/features/i386/i386-linux.c | 6 +++--- > gdb/features/i386/i386-linux.xml | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/gdb/features/i386/i386-linux.c > b/gdb/features/i386/i386-linux.c > index 42c406b..c7796c3 100644 > --- a/gdb/features/i386/i386-linux.c > +++ b/gdb/features/i386/i386-linux.c > @@ -71,9 +71,6 @@ initialize_tdesc_i386_linux (void) > tdesc_create_reg (feature, "fooff", 30, 1, "float", 32, "int"); > tdesc_create_reg (feature, "fop", 31, 1, "float", 32, "int"); > > - feature = tdesc_create_feature (result, "org.gnu.gdb.i386.linux"); > - tdesc_create_reg (feature, "orig_eax", 41, 1, NULL, 32, "int"); > - > feature = tdesc_create_feature (result, "org.gnu.gdb.i386.sse"); > field_type = tdesc_named_type (feature, "ieee_single"); > tdesc_create_vector (feature, "v4f", field_type, 4); > @@ -135,5 +132,8 @@ initialize_tdesc_i386_linux (void) > tdesc_create_reg (feature, "xmm7", 39, 1, NULL, 128, "vec128"); > tdesc_create_reg (feature, "mxcsr", 40, 1, "vector", 32, > "i386_mxcsr"); > > + feature = tdesc_create_feature (result, "org.gnu.gdb.i386.linux"); > + tdesc_create_reg (feature, "orig_eax", 41, 1, NULL, 32, "int"); > + > tdesc_i386_linux = result; > } > diff --git a/gdb/features/i386/i386-linux.xml > b/gdb/features/i386/i386-linux.xml > index f9aa311..17f9a1a 100644 > --- a/gdb/features/i386/i386-linux.xml > +++ b/gdb/features/i386/i386-linux.xml > @@ -12,6 +12,6 @@ > i386 > GNU/Linux > > - > > + > I think you can push this one right away as a cosmetic cleanup. Simon