From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130190 invoked by alias); 12 Mar 2019 02:31:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 130182 invoked by uid 89); 12 Mar 2019 02:31:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=recorded, H*UA:Roundcube, H*u:Webmail, H*u:Roundcube X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Mar 2019 02:31:31 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x2C2VOwG030413 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 11 Mar 2019 22:31:29 -0400 Received: by simark.ca (Postfix, from userid 112) id EA0761E660; Mon, 11 Mar 2019 22:31:23 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 54A551E4F4; Mon, 11 Mar 2019 22:31:17 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 12 Mar 2019 02:31:00 -0000 From: Simon Marchi To: Eli Zaretskii Cc: gdb-patches@sourceware.org, Pedro Alves Subject: Re: MinGW build failure for GDB 8.2.90 with source-highlight In-Reply-To: <83ef7d5wak.fsf@gnu.org> References: <83r2bibvlv.fsf@gnu.org> <83ef7d5wak.fsf@gnu.org> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00233.txt.bz2 On 2019-03-11 10:18, Eli Zaretskii wrote: > Ping! This discussion seems to have stalled. I'd like to have it > solved before GDB 8.3 is released. Agreed, this is definitely a blocker for the release. I recorded it here: https://www.sourceware.org/gdb/wiki/GDB_8.3_Release > If no better ideas come up, I'd like to commit the change described > here: > >> Perhaps we should simply #undef these two symbols before including >> ? > > TIA If the change is localized in one or a handful of files, I think it would be acceptable for the 8.3 release, since the alternative solution would be (1) a lot of work and (2) risky. Can you post a patch that fixes the build for you? Pedro, did you have a branch where you put all of gdb in the gdb namespace? I only found this branch, but it's using the gnulib:: namespace, which is not the same. https://github.com/palves/gdb/commits/palves/cxx-gnulib-namespace I just started to try to do it to get a feel of what's needed. I guess we need to put pretty much everything except includes (and maybe some other rare exceptions) between namespace gdb { ... }? And of course define GNULIB_NAMESPACE to gdb. Simon