From: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
To: "akamath996@gmail.com" <akamath996@gmail.com>,
"tom@tromey.com" <tom@tromey.com>,
Aditya Kamath <Aditya.Kamath1@ibm.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
SANGAMESH MALLAYYA <sangamesh.swamy@in.ibm.com>,
PRAJWAL B MEHENDARKAR <PRAJWAL.B.MEHENDARKAR@ibm.com>,
"simon.marchi@polymtl.ca" <simon.marchi@polymtl.ca>
Subject: Re: [PATCH v5] Fix crash in AIX when current working directory is NULL
Date: Tue, 28 Jul 2026 10:09:28 +0000 [thread overview]
Message-ID: <ed6ce193b4dc6d038cf28562788935d56fdfe42c.camel@de.ibm.com> (raw)
In-Reply-To: <LV8PR15MB6488982D6759F86186D8BF7BD6CB2@LV8PR15MB6488.namprd15.prod.outlook.com>
Aditya Kamath <Aditya.Kamath1@ibm.com> wrote:
>>require isnative
>>require ![is_remote target]
>>require {istarget *-*-aix*}
>
>>The last line may be too strict if we also want to test on Linux
>>or other Unix hosts; but we need to ensure the host is at least
>>Unixy enough to support fork. Maybe something like
>
>require allow_fork_tests
>
>
>Thanks for this idea. Yes, I have implemented the same in v6 of this
>patch.
Just to be clear: if you already require linux or aix targets (as v6
does), then there is no need to *also* require allow_fork_tests -
this will always be true on those platforms.
>But I am still thinking about Tom’s concern about GDB cross platform
>for this test.
The point of those "require" statement is exactly that the test will
simply not be run in any GDB cross-platform environment, only with
native tests. That should address this concern?
Bye,
Ulrich
next prev parent reply other threads:[~2026-07-28 10:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 7:21 Aditya Vidyadhar Kamath
2026-07-24 13:25 ` Tom Tromey
2026-07-27 6:48 ` Aditya Kamath
2026-07-27 12:02 ` Ulrich Weigand
2026-07-28 7:00 ` Aditya Kamath
2026-07-28 10:09 ` Ulrich Weigand [this message]
2026-07-28 12:35 ` Aditya Kamath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed6ce193b4dc6d038cf28562788935d56fdfe42c.camel@de.ibm.com \
--to=ulrich.weigand@de.ibm.com \
--cc=Aditya.Kamath1@ibm.com \
--cc=PRAJWAL.B.MEHENDARKAR@ibm.com \
--cc=akamath996@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=sangamesh.swamy@in.ibm.com \
--cc=simon.marchi@polymtl.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox