From: John Baldwin <jhb@FreeBSD.org>
To: Shawn Landden <shawn@git.icu>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix slow and non-deterministic behavior of isspace() and tolower()
Date: Mon, 10 Jun 2019 21:14:00 -0000 [thread overview]
Message-ID: <ed427569-4f1d-d6a2-fc92-825f00532bbd@FreeBSD.org> (raw)
In-Reply-To: <20190609151704.16061-1-shawn@git.icu>
On 6/9/19 8:17 AM, Shawn Landden wrote:
> I was getting 8% and 6% cpu usage in tolower() and isspace(),
> respectively, waiting for a breakpoint on ppc64el.
>
> Also, gdb doesn't want non-deterministic behavior here.
These routines are not always macros. For example, FreeBSD's ctype.h
exposes these as functions for C++ and only as macros for pure C.
Perhaps it would be better to define custom functions that don't use
the POSIX names to avoid clashing with whatever libc provides if we
want something with very specific behavior.
--
John Baldwin
next prev parent reply other threads:[~2019-06-10 21:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-09 15:17 Shawn Landden
2019-06-09 15:42 ` Eli Zaretskii
2019-06-09 15:51 ` Shawn Landden
2019-06-10 21:14 ` John Baldwin [this message]
2019-06-10 21:30 ` [PATCH v2] " Shawn Landden
2019-06-21 17:35 ` Pedro Alves
2019-06-21 17:59 ` Shawn Landden
2019-06-21 18:08 ` Pedro Alves
2019-06-21 19:20 ` [PATCH] " Shawn Landden
2019-06-21 20:12 ` Pedro Alves
2019-06-21 20:30 ` Shawn Landden
2019-06-21 21:14 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed427569-4f1d-d6a2-fc92-825f00532bbd@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
--cc=shawn@git.icu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox