From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SGTCIqkZBWDVEQAAWB0awg (envelope-from ) for ; Mon, 18 Jan 2021 00:16:25 -0500 Received: by simark.ca (Postfix, from userid 112) id 8C69D1EF80; Mon, 18 Jan 2021 00:16:25 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 693731E945 for ; Mon, 18 Jan 2021 00:16:24 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AEA723AA7CA6; Mon, 18 Jan 2021 05:16:23 +0000 (GMT) Received: from dedi548.your-server.de (dedi548.your-server.de [85.10.215.148]) by sourceware.org (Postfix) with ESMTPS id C857C3857C67 for ; Mon, 18 Jan 2021 05:16:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C857C3857C67 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embedded-brains.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sebastian.huber@embedded-brains.de Received: from sslproxy06.your-server.de ([78.46.172.3]) by dedi548.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1l1Mtm-000Ggc-26; Mon, 18 Jan 2021 06:16:18 +0100 Received: from [82.100.198.138] (helo=mail.embedded-brains.de) by sslproxy06.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1l1Mtl-000ApE-V6; Mon, 18 Jan 2021 06:16:18 +0100 Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id A3F422A1610; Mon, 18 Jan 2021 06:16:17 +0100 (CET) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id aYya3CmR8gHj; Mon, 18 Jan 2021 06:16:17 +0100 (CET) Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 405B32A165B; Mon, 18 Jan 2021 06:16:17 +0100 (CET) X-Virus-Scanned: amavisd-new at zimbra.eb.localhost Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 54HkFZRpelEs; Mon, 18 Jan 2021 06:16:17 +0100 (CET) Received: from shuber-nb-linux.eb.localhost (unknown [10.10.171.18]) by mail.embedded-brains.de (Postfix) with ESMTPSA id 0ECC72A1610; Mon, 18 Jan 2021 06:16:17 +0100 (CET) Subject: Re: [PATCH v3 1/5] gdb: make the remote target track its own thread resume state To: Simon Marchi , gdb-patches@sourceware.org References: <20210108041734.3873826-1-simon.marchi@polymtl.ca> <20210108041734.3873826-2-simon.marchi@polymtl.ca> From: Sebastian Huber Message-ID: Date: Mon, 18 Jan 2021 06:16:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210108041734.3873826-2-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Authenticated-Sender: smtp-embedded@poldinet.de X-Virus-Scanned: Clear (ClamAV 0.102.4/26052/Sun Jan 17 13:33:01 2021) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hello Simon, On 08/01/2021 05:17, Simon Marchi via Gdb-patches wrote: > +/* From the remote target's point of view, each thread is in one of th= ese three > + states. */ > +enum class resume_state > +{ > + /* Not resumed - we haven't been asked to resume this thread. */ > + NOT_RESUMED, > + > + /* We have been asked to resume this thread, but haven't sent a vCon= t action > + for it yet. We'll need to consider it next time commit_resume is > + called. */ > + RESUMED_PENDING_VCONT, > + > + /* We have been asked to resume this thread, and we have sent a vCon= t action > + for it. */ > + RESUMED, > +}; there could be a problem with this "enum class" on CentOS 7.9: ../../sourceware-mirror-binutils-gdb-edf0f28/gdb/remote.c:1157:38: error:= 'resume_state' is not a class, namespace, or enumeration enum resume_state m_resume_state =3D resume_state::NOT_RESUMED; ^ ../../sourceware-mirror-binutils-gdb-edf0f28/gdb/remote.c: In member func= tion 'void remote_thread_info::set_not_resumed()': ../../sourceware-mirror-binutils-gdb-edf0f28/gdb/remote.c:1115:22: error:= 'resume_state' is not a class, namespace, or enumeration m_resume_state =3D resume_state::NOT_RESUMED; ^ ../../sourceware-mirror-binutils-gdb-edf0f28/gdb/remote.c: In member func= tion 'void remote_thread_info::set_resumed_pending_vcont(bool, gdb_signal= )': ../../sourceware-mirror-binutils-gdb-edf0f28/gdb/remote.c:1121:22: error:= 'resume_state' is not a class, namespace, or enumeration m_resume_state =3D resume_state::RESUMED_PENDING_VCONT; ^ In file included from ../../sourceware-mirror-binutils-gdb-edf0f28/gdb/..= /gdbsupport/gdb_string_view.h:49:0, from ../../sourceware-mirror-binutils-gdb-edf0f28/gdb/.= ./gdbsupport/common-utils.h:46, from ../../sourceware-mirror-binutils-gdb-edf0f28/gdb/.= ./gdbsupport/common-defs.h:125, from ../../sourceware-mirror-binutils-gdb-edf0f28/gdb/d= efs.h:28, from ../../sourceware-mirror-binutils-gdb-edf0f28/gdb/r= emote.c:22: ../../sourceware-mirror-binutils-gdb-edf0f28/gdb/remote.c: In member func= tion 'const resumed_pending_vcont_info& remote_thread_info::resumed_pendi= ng_vcont_info() const': ../../sourceware-mirror-binutils-gdb-edf0f28/gdb/remote.c:1132:35: error:= 'resume_state' is not a class, namespace, or enumeration gdb_assert (m_resume_state =3D=3D resume_state::RESUMED_PENDING_VCO= NT); ^ ../../sourceware-mirror-binutils-gdb-edf0f28/gdb/../gdbsupport/gdb_assert= .h:35:13: note: in definition of macro 'gdb_assert' ((void) ((expr) ? 0 : = \ ^ ../../sourceware-mirror-binutils-gdb-edf0f28/gdb/remote.c: In member func= tion 'void remote_thread_info::set_resumed()': ../../sourceware-mirror-binutils-gdb-edf0f28/gdb/remote.c:1140:22: error:= 'resume_state' is not a class, namespace, or enumeration m_resume_state =3D resume_state::RESUMED; ^ --=20 embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.huber@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht M=C3=BCnchen Registernummer: HRB 157899 Vertretungsberechtigte Gesch=C3=A4ftsf=C3=BChrer: Peter Rasmussen, Thomas= D=C3=B6rfler Unsere Datenschutzerkl=C3=A4rung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/