From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127981 invoked by alias); 22 Oct 2018 20:54:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127945 invoked by uid 89); 22 Oct 2018 20:54:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=inferiors, inferior's X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 22 Oct 2018 20:54:56 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AE0B35F74C; Mon, 22 Oct 2018 20:54:55 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 014861895D; Mon, 22 Oct 2018 20:54:54 +0000 (UTC) Subject: Re: [PATCH 2/3] Pass inferior to terminal_inferior To: Simon Marchi , gdb-patches@sourceware.org References: <20181016033835.17594-1-simon.marchi@polymtl.ca> <20181016033835.17594-2-simon.marchi@polymtl.ca> From: Pedro Alves Message-ID: Date: Mon, 22 Oct 2018 20:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181016033835.17594-2-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-10/txt/msg00478.txt.bz2 On 10/16/2018 04:38 AM, Simon Marchi wrote: > diff --git a/gdb/target.h b/gdb/target.h > index c37405205a0a..310c942bbe5b 100644 > --- a/gdb/target.h > +++ b/gdb/target.h > @@ -581,7 +581,14 @@ struct target_ops > TARGET_DEFAULT_RETURN (false); > virtual void terminal_init () > TARGET_DEFAULT_IGNORE (); > - virtual void terminal_inferior () > + > + /* If INF shares a terminal with GDB, restore the saved terminal settings > + associated to INF (see terminal_save_inferior) to the current > + terminal. In a scenario where multiple inferiors share GDB's terminal, > + don't apply the settings of another inferior's settings are currently s/of/if/. > + applied (in other words, the first inferior's settings win and should not > + be overwritten). */ > + virtual void terminal_inferior (inferior *inf) > TARGET_DEFAULT_IGNORE (); > > /* If INF shares a terminal with GDB, save the current terminal settings > OK. Thanks, Pedro Alves