From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Q2y8HcarmGM5HgAAWB0awg (envelope-from ) for ; Tue, 13 Dec 2022 11:43:50 -0500 Received: by simark.ca (Postfix, from userid 112) id 6EEB61E126; Tue, 13 Dec 2022 11:43:50 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=Niinjx9n; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 240451E112 for ; Tue, 13 Dec 2022 11:43:50 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BCE4A383D8CA for ; Tue, 13 Dec 2022 16:43:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BCE4A383D8CA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1670949828; bh=kCONao73o3hEy7qUs9RPeFPGf/xw4beI6XH6rQ9ZWhw=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=Niinjx9nxsE8A0miGBZARvKoqoxD0u/9ktboAnb8EYFWQJghE6GYEXWaXbKr9wjZY JpTLBD0C1mV7Ni+6K477sh838hjwccoOZsYEHsFO/DcRuDxZ1/TU+KYDLE7727HADH aAxkHA6Fr1UMqhZ7NFZZDXVc3zgGObVxUOwxts0A= Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 435C1383C7DA for ; Tue, 13 Dec 2022 16:43:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 435C1383C7DA Received: from [172.16.0.64] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 13BA41E112; Tue, 13 Dec 2022 11:43:26 -0500 (EST) Message-ID: Date: Tue, 13 Dec 2022 11:43:26 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] gdb: fix command lookup in execute_command () To: Tom Tromey , Jan Vrany via Gdb-patches Cc: Jan Vrany , luis.machado@arm.com References: <1a96057b-afd6-1e90-15c9-ee106a2998c7@arm.com> <20221213112241.621889-1-jan.vrany@labware.com> <878rjbfinm.fsf@tromey.com> Content-Language: fr In-Reply-To: <878rjbfinm.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 12/13/22 10:05, Tom Tromey wrote: >>>>>> "Jan" == Jan Vrany via Gdb-patches writes: > > Jan> The below patch should fix this case - with it on my system > Jan> gdb.base/define.exp passes. > > Jan> Alternatively I may just revert the commit until better solution > Jan> is found. > > This patch looks ok to me, but could you say whether you ran all the > tests or just define.exp? Given the history I think a full regression > test is warranted. > > thanks, > Tom I'll run the patch through my CI job, where I am seeing the define.exp failures currently. Simon