From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30604 invoked by alias); 3 Oct 2017 15:15:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30589 invoked by uid 89); 3 Oct 2017 15:15:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=paths, our X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Oct 2017 15:15:00 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 098063DBE0; Tue, 3 Oct 2017 15:14:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 098063DBE0 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 370DD60E3A; Tue, 3 Oct 2017 15:14:56 +0000 (UTC) Subject: Re: [PATCH v5 1/3] Introduce gdb_tilde_expand To: Sergio Durigan Junior , GDB Patches References: <20170912042325.14927-1-sergiodj@redhat.com> <20170929225852.21872-1-sergiodj@redhat.com> <20170929225852.21872-2-sergiodj@redhat.com> Cc: Eli Zaretskii From: Pedro Alves Message-ID: Date: Tue, 03 Oct 2017 15:15:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170929225852.21872-2-sergiodj@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg00046.txt.bz2 On 09/29/2017 11:58 PM, Sergio Durigan Junior wrote: > Currently, whenever we want to handle paths provided by the user and > perform tilde expansion on GDB, we rely on "tilde_expand", which comes > from readline. This was enough for our use cases so far, but the > situation will change when we start dealing with paths on gdbserver as > well, which is what the next patches implement. > > Unfortunately it is not possible to use "tilde_expand" in this case > because gdbserver doesn't use readline. For that reason I decided to > implement a new "gdb_tilde_expand" function, which is basically a > wrapper for "glob" and its GNU extension, GLOB_TILDE_CHECK. With the > import of the "glob" module from gnulib, this is a no-brainer. > OK. Thanks, Pedro Alves