From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Lb+3LqvmEmAqdwAAWB0awg (envelope-from ) for ; Thu, 28 Jan 2021 11:30:35 -0500 Received: by simark.ca (Postfix, from userid 112) id ADE381EF80; Thu, 28 Jan 2021 11:30:35 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,RDNS_NONE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E88961E945 for ; Thu, 28 Jan 2021 11:30:34 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 630B2384B00F; Thu, 28 Jan 2021 16:30:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 630B2384B00F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1611851434; bh=ee+iBKWhJPTHC/lwJEyfnQ1dZVciAkeTSggx9Y8gaZQ=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=AqZpTs+HEgOQSA8W5mmKjmNFQFbqzV90zYTC8/X8MMu1hLwCH5N5WOOxJsRXdUX2d cJvjgqQByappLok9GY0WiXdzurf6+k6cKRrBdmunsL3xHCDnnqerb9d+OLqyHgSWiL fG5Kyh0l5kLmzbyDpbfk6Os0mMTJUFEqYs4a53Yk= Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2053.outbound.protection.outlook.com [40.107.243.53]) by sourceware.org (Postfix) with ESMTPS id 666E7386189F for ; Thu, 28 Jan 2021 16:30:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 666E7386189F ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AJEKe/xn1o9Iut3OMDwXLupzf1z6t7HHDZeONU/msap5vd3cnVKBi9U/JFM6Dp+g8u+BhIcPB7BAvIceJQbJrasyFQ3+4OlInyHez3bjqa4CGZ3eGh3ez3T+fDY1bKlLfObua/Ql9JtuDvGlSLp8UlriX8grMrZuVJEQYA+fUQrsyzu1oEmkMOkSQ9R/m5g5HhI0UKiIJy2WFJQtW28e0PZubbc/a8xSSeUOFmHdwn9Ro556jqmPYfsuDfmcHDu5km0IUe3kuak+77n1+i0YcqlpK8xWE7glFC0G/kXHx6AHkLJVPl3jjgX3b5IFJ/5+0JgEMj2CwqFGEvREvxwUEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ee+iBKWhJPTHC/lwJEyfnQ1dZVciAkeTSggx9Y8gaZQ=; b=F8KVOHxm3MFhG0r/qlN94oX3AQUEAzIv7iqMmJTjv+KxSRtRcRoMdY9VAcIAZXPeOZnQVzDkcrrF3zZ3bb6/X/p10O5Ls9AwXpFuCjpzUz45Mu3mU87nHm8Up/gFcK+k0lUrQgEunH1M3VZ5oQSKYCfb/9Gja8Iekow66P0o1astc7B5WjqL98U5nDUghgN5y56/Go9KZh/J29AK5X4IfZGd82saPkgnUdpDmdSPNKUyx9Rl9xOGZAxLIBEQvJ0ZNqPOe7I3t3OZLKplHRnTBEMtBcG1ItwdRZpSuc4w19G87Uou0JPIs6MpQR078RMDGph1h695kdyCa5Vd862cxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) by DM6PR12MB4561.namprd12.prod.outlook.com (2603:10b6:5:2ac::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.16; Thu, 28 Jan 2021 16:30:31 +0000 Received: from DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44]) by DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44%3]) with mapi id 15.20.3763.019; Thu, 28 Jan 2021 16:30:31 +0000 Subject: Re: [PATCH 09/13] gdb/testsuite: DWARF assembler: add context parameters to _location To: Simon Marchi , gdb-patches@sourceware.org References: <20210120053925.142862-1-simon.marchi@polymtl.ca> <20210120053925.142862-10-simon.marchi@polymtl.ca> Message-ID: Date: Thu, 28 Jan 2021 16:30:25 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 In-Reply-To: <20210120053925.142862-10-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [2a00:23c7:5a85:6801:cf:c92a:a445:6f68] X-ClientProxiedBy: AM9P192CA0011.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:21d::16) To DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2a00:23c7:5a85:6801:cf:c92a:a445:6f68] (2a00:23c7:5a85:6801:cf:c92a:a445:6f68) by AM9P192CA0011.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:21d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.17 via Frontend Transport; Thu, 28 Jan 2021 16:30:30 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b1a7d8a8-9d5a-436e-2dcd-08d8c3aa0773 X-MS-TrafficTypeDiagnostic: DM6PR12MB4561: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ELJ3/nj1As2822yNJ1OIQPrOeLlApo6Ng1s6xePlhFhm+J0BYGPDAvBLfJ6J6LwkYhx3XnfUJOtuPFbC0D4XK0yatxx9RV2snxdFe33gxaPRXMJpXl+ehUufuornWEaZDZY9cTF6SdcYHNHZT28e/3iytEVcBN+SKeHQwZZQaWGz96VQjREH2OrWbCwQd27rfCF1NohtGeJLnQ7lF8ZErFaabRivGlqbm5SpmW6Dhfu+g+rswUXNV4FQiAYWsipP8IBSxMQRHkQ4mW294fYLssbCA/ktkQZ88P02aLIrr/Bi4WP93k8N5aj8saoYIX5VbiPQ5TH4K/PWiOvl62+nJUTkgwyncRYV3BNNuFWf8UsMljs4kzeSGHSuAkF7EydlabQFsdvgylsWn1JVUFDTODCS9g7zhdKpLlgmXtUxzW3waAq6xl6iCJzZxJ3jMWunqEJcJc3x/+P0bhM5DlAN1rDSfzBzA5GCwCraJ+un4Hi8QYCVRObMQr1tcHn4KIUAfKG/TC+9KiKJpnw1lay3CRbIFbAg1gog4hdw1LIIH1RQfMyPpbaqgoppJ8R/B6MelIlL5rhQ6ayRsqNMDHbzwR6uZeCAPJfL5cO4e4EjyyE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2762.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(39860400002)(396003)(376002)(366004)(83380400001)(31696002)(86362001)(8676002)(52116002)(316002)(31686004)(478600001)(6666004)(36756003)(5660300002)(4744005)(2906002)(8936002)(66476007)(66556008)(4326008)(66946007)(2616005)(16526019)(186003)(6486002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Nk1aSkc1TFp2dnBWTzBnYUlIcGthYndhTlhWeXBJTDkzdDdPQjVMZU4yVXlI?= =?utf-8?B?aW41RWJ4ZlpJUEhPMTZTR0VaYUlmUHJEckxkRTd2dkk3NFF6Yi9EdXdLN1l4?= =?utf-8?B?TDNjd3kwSjlYdWhjT3RZdjl5TUJzaHZLS0NFdm5JcW1lTjFWNk1SVnl3ajVH?= =?utf-8?B?K0hGWXN0M2kzbjdQQVVJZVlUdEFXZnhpWE5kMHlHUFIveCtvNFpCUVk3NWlL?= =?utf-8?B?Z1VQS0pnaDg1ck9EUGE4OHl5NFBCSHJBNGNGZTRiVUp1YWQ5YzNhTDJZYlNw?= =?utf-8?B?dVFqRWgxVmZXZVVqRWNWeWJPbDFySFdkNmZTc2xDaklsT2kzZjN5TjRLZW5w?= =?utf-8?B?bzBTcnp1bzk1ekl2czlPdDZLdUR3eFc4QVYzbndoaXNGeGRueVJHUmpsM0hS?= =?utf-8?B?NFdmZWRkMDd0bU5HUW4vajhaY2ZxTy93NW5ZVDRkN2xyV2VRR1pMK3dQYjhX?= =?utf-8?B?UENhVnRtMDVhazZUQjVnUG5NNUcrTURwMld0M1d0THpwNEdBaVlTYWRFVUFU?= =?utf-8?B?R2drTU9kNlRCNlZjME5RMU9WNzF4RUZCenF2ZHFLTm5pQkFxNHNJY041WHdE?= =?utf-8?B?YmJlSVQvNjZnUC9OYStKMmJiR2VUaENrelQxYVozNTJxR0gybnZaa3RnWGFz?= =?utf-8?B?K3A2WTBYc2Z2N1BMYmZSeTJPYkk2Smc1VDZUQ0xMVFM5MnJwQzQ3SHF0QjJB?= =?utf-8?B?U1p5a2M0WThFemdVK3NsdU96RXBTWjlHU3VLMlFzRDNaOE85cjRUbkdnNHRw?= =?utf-8?B?eUQxUDB2TFJwOURNOEMwemNYd0Z1R1Z3cDg4Ynh0eHJiVXF0VnV5amd1YmlX?= =?utf-8?B?WjIyQi9sMHRzaEtlajR2QWZXVDVLUUdVRFJKN00ySHpyeWRtRUFUTlo2NjF0?= =?utf-8?B?Wlloc2ZpUUZ0MDViSDFTdXlVTWZxY0ppNXBPZkM2U25wSzkzMlI4T0lVcFdw?= =?utf-8?B?cDAxZ3pyUUFKMEh6R0c5L05JT21hU3RHb1pNNVBnQlREdnNoRVBZUS9XUEpT?= =?utf-8?B?V2hOQW5qM2VTRXVyTTVIQW9mcWlUZHQ0U21kM1QwZGNHSTl4Vm1LTmMzamlV?= =?utf-8?B?RlFLbnZIaGE0TDVrOEFuMUhIbFB4c0RLZ1BjMk5vN1B2R1BRZnNUOERKK0Zy?= =?utf-8?B?K1VGYmZMYXBMVU1TelB4cjI4Yyt5VlJGKzAyd0ZHOTBTNnlPYUEramZKYmoy?= =?utf-8?B?RnAxRldJWVhOMi9EbUlSUEJYWXFqQ2MwN0hzMTRUeStlRTBwY1crVnVNbVlF?= =?utf-8?B?bGY4YmJyNFNocGc5WHNKRjEvNkVhZUx0dEVlSUFldStjT3VZMktaZHBkSTNC?= =?utf-8?B?WitiR04vYnFTUVRtTWRBRUFZZjF3TTVmT0ZZWm1xMmtQeU11MW5hYVU4cHQ1?= =?utf-8?B?MTVxRk5mSnJuMmRUR2VTS09QQnY1c3B1aEQzV3oxcTdPSkxob1c5dDI0aVFO?= =?utf-8?B?N1RUc2FHTGxDbkZhZzlMNzNUQnNPRlpzeDE0ZFlWRGJaSWZGdUpONWtmZE1l?= =?utf-8?Q?4RW9r1HMSiMirBN1cdJ/RGPjjQF?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1a7d8a8-9d5a-436e-2dcd-08d8c3aa0773 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2762.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2021 16:30:31.2439 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IXq0E4nRos0CuSjLwRatKXR4dUOPfJb4FGDjNOV1JghpE5j67rFSe6Ig8PrX1ocA3DV9bVIQCPUwc7lGh6kXWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4561 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Zoran Zaric via Gdb-patches Reply-To: Zoran Zaric Cc: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > From: Simon Marchi > > The _location proc is used to assemble a location description. It needs > to know some contextual information: > > - size of an address > - size of an offset (into another DWARF section) > - DWARF version > > It currently get all this directly from global variables holding the > compilation unit information. This is fine because as of now, all > location descriptions are generated in the context of creating a > compilation unit. However, a subsequent patch will generate location > descriptions while generating a .debug_loclists section. _location > should therefore no longer rely on the current compilation unit's > properties. > > Change it to accept these values as parameters instead of accessing the > values for the CU. > > No functional changes intended. > Agreed. This seems like a necessary step for the new conditions that the DWARF 5 standard introduces. Zoran