From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id VpmpDLqjp2rUVwsAWB0awg (envelope-from ) for ; Mon, 14 Sep 2026 03:35:22 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=uuCzTSdr; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=8wZQOG2k; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=A0GZrAK6; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ZIIekptd; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1F9A81E051; Mon, 14 Sep 2026 03:35:22 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A4DD91E01F for ; Mon, 14 Sep 2026 03:35:21 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 33F2D4B99F5C for ; Mon, 14 Sep 2026 07:35:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 33F2D4B99F5C Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=uuCzTSdr; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=8wZQOG2k; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=A0GZrAK6; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ZIIekptd Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id C0FF34BA2E37 for ; Mon, 14 Sep 2026 07:34:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C0FF34BA2E37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C0FF34BA2E37 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789371290; cv=none; b=EIoB2cMPH80DxYmxW/tvlHseNUsQFc2qJfpiYbbbSmUwnSF8hGWmOvX5uPzkKBgmg6zp+p3n8nepuXH3SsmmuBwfWzI0gxZfXSjxSDR3m7L4Z+5S2+PhYlEqB422AWP/Hwp4/3Sii4jMBMeeafQ0TL9hhiumYHsZnspyGZSEy4k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789371290; c=relaxed/simple; bh=fBj5nOrrAWhRFarA0Kz9QbQ5UMqPmPv3uKfbYkHTSco=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=nuNNhsjWzjDSeZLM/eKBVyJUy7wa5BEdkRRfmRaOWGdjwMGQmm+y31GI8JJnmN5E0ZJqs2BqIheDJuURGdqDVNOGbhjV3OSskFBVWPvfy9Xo/7zb3l/Rm9Xv0qr8qtffM278XJmmZcuKK+nSSfe0bdM2/Yj/Iv1lCL2tEWgirSU= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=uuCzTSdr; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=8wZQOG2k; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=A0GZrAK6; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ZIIekptd DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C0FF34BA2E37 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7DA071F83A; Mon, 14 Sep 2026 07:34:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1789371285; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tvcQpp/VLZrlKjtRevbZ2nwwoMC7xtFOf161yEMQ0I0=; b=uuCzTSdreGyiUX5YcaNCiundnz6EzdNmKyeV95WZ5EJIMRiiYz/uS3n33Zhk5G6qodhcsP NxJL9hVi9hJZL2EhAagFjvCSOLIXxVlGwl6MZtLYHQON6GJcuZaLhsFWFaf+grI0DJJCmn sho0SqOftu5CbA+A3lUvTXgdaLixgw4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1789371285; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tvcQpp/VLZrlKjtRevbZ2nwwoMC7xtFOf161yEMQ0I0=; b=8wZQOG2keu5sU8xX//Liu2GLO9cviNvcbetKv67ga98sAMER6FRbSUzz/kJH5DQefwedhT zKFelZREjDK11NCA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=A0GZrAK6; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ZIIekptd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1789371281; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tvcQpp/VLZrlKjtRevbZ2nwwoMC7xtFOf161yEMQ0I0=; b=A0GZrAK6F9ZwZpTz/F3gCLFCXLQGJwYsP1Gm+g+B6bvlpaOGo4GPCvRtMn+qIRchn7LxaI Pv8UD2lnkFMpsUn9CT6YugnbtD65B+iSS439HTBdkrSvKq5RFUm7KsosyldpJ+mVYImpCN raZPdHR4ESLKx/1KrUuPmSk31A4dyFI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1789371281; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tvcQpp/VLZrlKjtRevbZ2nwwoMC7xtFOf161yEMQ0I0=; b=ZIIekptdDAR5v7lCicvWjXos1ss40ZxV4cuGP1eYICB+8QZq24aGIc5qBgJfEjOP7jn9yA l7bfgiK+/oKbnHCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4B40B13693; Mon, 14 Sep 2026 07:34:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id p7zBDJGjp2oUUAAAD6G6ig (envelope-from ); Mon, 14 Sep 2026 07:34:41 +0000 Message-ID: Date: Mon, 14 Sep 2026 09:34:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/7] [gdb] replace bsearch with std::lower_bound in find_pc_section To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260909094849.2745086-1-tdevries@suse.de> <20260909094849.2745086-5-tdevries@suse.de> <87tsnvy7jk.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87tsnvy7jk.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 7DA071F83A X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:dkim,suse.de:email,suse.de:mid]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/11/26 8:19 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> In find_pc_section, we use bsearch to find a matching section. This works > Tom> fine, but in case the pc matches a section hole, it returns nullptr, with no > Tom> information about where the section hole is. > > Tom> Instead, use std::lower_bound. > > Tom> + /* The std::lower_bound call returns the first section which is not ordered > Tom> + before pc. That section may or may not contain pc. */ > Tom> + if (it != data.cend () > Tom> + && (*it)->addr () <= pc && pc < (*it)->endaddr ()) > > Could this use (*it)->contains? Yes, that works. Thanks, - Tom > > Tom