From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64337 invoked by alias); 18 May 2018 21:18:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 64322 invoked by uid 89); 18 May 2018 21:18:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.2 spammy=sk:discard, Hx-languages-length:1668 X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 May 2018 21:18:40 +0000 Received: from ESESSHC017.ericsson.se (Unknown_Domain [153.88.183.69]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 60.84.01293.E234FFA5; Fri, 18 May 2018 23:18:38 +0200 (CEST) Received: from ESESSMB502.ericsson.se (153.88.183.163) by ESESSHC017.ericsson.se (153.88.183.69) with Microsoft SMTP Server (TLS) id 14.3.382.0; Fri, 18 May 2018 23:18:16 +0200 Received: from ESESSMB502.ericsson.se (153.88.183.163) by ESESSMB502.ericsson.se (153.88.183.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Fri, 18 May 2018 23:18:15 +0200 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB502.ericsson.se (153.88.183.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Fri, 18 May 2018 23:18:15 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.48.114] (192.75.88.130) by SN6PR15MB2400.namprd15.prod.outlook.com (2603:10b6:805:24::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.776.11; Fri, 18 May 2018 21:18:13 +0000 Subject: Re: [PATCH 07/10] remote: Move discard_pending_stop_replies call To: Pedro Alves , References: <20180516141830.16859-1-palves@redhat.com> <20180516141830.16859-8-palves@redhat.com> From: Simon Marchi Message-ID: Date: Fri, 18 May 2018 21:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180516141830.16859-8-palves@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN6PR1501CA0003.namprd15.prod.outlook.com (2603:10b6:805::16) To SN6PR15MB2400.namprd15.prod.outlook.com (2603:10b6:805:24::20) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:SN6PR15MB2400; X-Microsoft-Exchange-Diagnostics: 1;SN6PR15MB2400;3:viLTFPTtij502WfRU3omgvkBLnYWCTLlPfQF+IVUnuuZF8BZZZ7z01xNdlLJGzp3+GHRXF6Il3ia6/9XgIIgVGgu9ptz0Xvqt0KqnRxayDC5oAKoCKUO7UX5kAF5mUqi/uD7bHwfDN5v5qoIKjN1XjYQ9/OYJJtc1TY7YOdF5PIJPBvKbxr+MtRC5LETw/J9s9KCcSk6OvJjmzVZ+NBbFiGm2G3Z73qOE7ofsw16XmhhlTCz3VxiBa2ck8Wj9VV4;25:3Oxbq1FAlEogKcLI0Aqhg5Ljiztskp1mcZ5+2Y93x+Xm7rY+ux9C6GET6CWuIjkRMVJiON6nJ2gIOWIDiKT2Xe+b+NtJ2kmOQAgZqTtO30dj6gjF03eUmdEHoEMk5kIAz50XqmOXT5sfs5O5wU1Brkbv7fiWOrsfHVEa1pzhpyaA5OBn00CvNjaDY9iW4FIiv3nsBE06gbSyuYv1q7ZWNvWzYDYfATOSY+wUOZd3V16ssZA2wpmdfgZhVBY/Jl5Q8paNKBhH17invhRTkAlgBfty3eUvunN4Mu9bVI5KvW7RDyjROxUtX/KR/N0gFHQzK1SI2CDGNxQo7uF1jCSeJw==;31:knYtt/KkCTcNXtWR/ipCec5ENrME5AEmXlq2ZliwnZnhLmowyRNnRPSDUB65/FpWNP3mxi4q3mwHQRKYWIR4IB5eFvbl4XbFWQDLMZjIA7IsTrY0t7n+PyZTWYnCJ8DQCW1/b0XwDd9tL5jiVs3htlNTFAbimIq2qfLcHUuJcQGp3WdgUItXDlQw3Y6TchqAo8xO7r/yibdDAYPSuaE3mpnCXmPIUbUZjTWdQfCuvF8= X-MS-TrafficTypeDiagnostic: SN6PR15MB2400: X-Microsoft-Exchange-Diagnostics: 1;SN6PR15MB2400;20:/gnz/C+jvU9/U/yqTkFCUa+KeiQ8QYFzG5NePF44W0KAu2OQc1sbeJLCMxkT2h/uSUiMA0nL5f/NmzWTWyQWd0reYsHVUcIA5micUu3ofg4KfZmshbJxB2zF4N0QTqLonC4ydhW3B6+JxGA7BCxkuCYq+5AqvXDZ0vX7fU0/nrNaqO4F+OLTnOY9TM5xIhzRI1PdfHS25kZJDbuY9OVaRqF4etDnbAUnUtrTBUL6bOh+GBFARHvLjtmcWtzxWVLFec7d9CC3U0pSR58qYTdiq8vKc70nHAnKVM0QOAaG4DpLIRj3LOLDxkbNKXvQU0ZBcHMldOl50Yymj+ISIX08m2HwqGlcMdmKoBth6MTm/7OnneTJ7SldHWDlRGcdh/rGV1A79x3HJsQ8MIPqt4yKCuOzrEuOj5tTDa86sOJ8gNkrQJ1lTy6xyEASWJeT+v9CWD57LeTAlazAa02wl8sfFdVZzDMUJNpbAh3YdXPqIdSAsT07hmthcbOU6X/3Aihs;4:qEfwXJBHxRBN8+2AzPpk8JwZ6SJiSv2J5XoXbEFVY/DBXIXaErxv/I7NJ1AzFcO7QoHl5bZGtF/E2wVJIpqGmZnCbpxMsibDu2TjlfDKASs3oEVA4Y8GaH16+bX4U75AQpJLDxdEHduJsKFandFA/JoidTSltFfyYMHxRrwIUC2yX7SlNvFKMtOmB9C65PDG5WgfCP32mRjeNWZn8bMuAEH9kR7DDBbuhDTC5LcAM3vhsnV8aMOAWNGeyj+giFzRfDcjOcm+jDHCf5qBGQs5IQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(3231254)(944501410)(52105095)(10201501046)(149027)(150027)(6041310)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(6072148)(201708071742011)(7699016);SRVR:SN6PR15MB2400;BCL:0;PCL:0;RULEID:;SRVR:SN6PR15MB2400; X-Forefront-PRVS: 0676F530A9 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(39380400002)(376002)(39860400002)(366004)(346002)(396003)(199004)(189003)(377424004)(54534003)(81156014)(26005)(81166006)(8676002)(478600001)(8936002)(186003)(53936002)(16576012)(5660300001)(386003)(316002)(58126008)(64126003)(49976009)(6666003)(53546011)(52116002)(76176011)(23676004)(65826007)(229853002)(5890100001)(59450400001)(2486003)(106356001)(105586002)(52146003)(6246003)(50466002)(31686004)(6486002)(11346002)(47776003)(86362001)(2616005)(16526019)(446003)(956004)(68736007)(476003)(6116002)(66066001)(65956001)(97736004)(25786009)(31696002)(2906002)(305945005)(3846002)(486006)(7736002)(230700001)(36756003)(44832011)(65806001)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:SN6PR15MB2400;H:[142.133.48.114];FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjZQUjE1TUIyNDAwOzIzOmZMZzJLeTFjWkxleWNKVVoyZkRJbE83S3RF?= =?utf-8?B?MGU4eXlSRnkzNzFFRUh4ZWNucmlHZ2hiUGNRdk9iekgyOUJJQ1h6dDk0dEE3?= =?utf-8?B?ditXT1I4UmRISW9SVlZrekJKRkM5emNJeDJjUE9aQ1g3V3Q2TS93YWEzYXRj?= =?utf-8?B?Rys4QTVBT2M0akJCZjJQWkZOdHVUMUEwbHpkTGxudC9TL1IwUHVJVnB3czRO?= =?utf-8?B?bG5QTC9uTU9uL051dTFqSCtVUjdpOEw5emlXVEtpc3F2bmlCSkdPT0FpTE5n?= =?utf-8?B?VW1STTB1QUo0eHgyRi9UdDh1M2RvZlpIdGpGTDV6Ymx0NE9NRUNkUVFlQnJw?= =?utf-8?B?bERJME9oNDVOeExOeWxTVVozL05XaUlqU0FXVWhEdzdLK3NJRi92aWJLbmRI?= =?utf-8?B?WjhXdHVFMm1XZEpRM3ZxMXJ0Y2paSTBVdUZ5MG1obnR6RGlpTXFxQXNKVmpt?= =?utf-8?B?ZloxTW0veUIyQ0xRQ1d0d0ZnN2FJbDBRTkhTOE5UVGFmTGRNcjlHQ1dyVmpF?= =?utf-8?B?c0VSazloMDAwbFY3WWVGUWVnTHp1V0hDenYyNmI5bTR3YkJ2YktSSjBoWnJ1?= =?utf-8?B?VTduTWhMdGRJa0VsOWZGMGVCT0gxT29udU9CVFJmZTVlaWN6TEJjTHlXZzNw?= =?utf-8?B?aXU2ak0zcHU5TjJPMU1qWjRSMCtPSXZiOWdVVHdGSExacEpMVVd3N2owRDBn?= =?utf-8?B?VGFUNGFmTDhLM2pHYnFKbHR0UTdWQUxpWklhaVVnT0oxcW5rWCtsMDFEQ01D?= =?utf-8?B?a1l6QVJFMGpuRUcxdE1pT2JHdVRLQUZiaVBYZE04L3B1MGJjRkt6QmVDODBW?= =?utf-8?B?YTU1ZjZLSjR0MWt1VENKY0pCM01pVFV1dWhSVTRFQ1BwT0ZMeVRVZjNJdUxM?= =?utf-8?B?N0UyYzRGT0Q2WDRUa25ldzVRcStzY3FPMmpHdjAwdWx1VDZlKy9lRDlhZUg0?= =?utf-8?B?S3BldkpWTllJY2p1K2FtSXZwTkZ6S2dydmRiYUVvMXp3ZUhZVDl1VmVPNWds?= =?utf-8?B?Ny9iS3ZkeHZ4UU9DcWZqc3FSZkE0aVRod3RZSUEyNnZQMXA5RVA5aU9XTTVq?= =?utf-8?B?ek1GZzRkYklyVC84Q29UU1lNN2hBWUpiYUdBMCthbCtVQkh2b1VjK3BWajZB?= =?utf-8?B?RnErZ1cyQXNSb1FQcG9BVnk3M1kxZXJCcHFvTFpaRXpNLzVaM1ZqYStKUjRw?= =?utf-8?B?MVRILzFZU2g1SFRXYjZFcnJrOHRvNjd3V04yd096UlVZMzBhRDRWN3dkbmt0?= =?utf-8?B?aHJ3Z0NQREhiUzh0amhpMlJxOTRCVkJuRU5kQXIxUTVkTDlYME1yZzBWalkv?= =?utf-8?B?REptT1lDajJ5VGhGYUQzT1hKaDhrWEswWCsyZWJuS25iYUM1dGVtSEk2K0U1?= =?utf-8?B?M0R4WkJPQmlmN0NZaDZjUjFjY3RzbFZOaDRpc3NXUlRJZXF6TzNJZ1JmOVp6?= =?utf-8?B?aVd6SStObmtFMSswcGhDZlZuS2xjK1hEWHFVUmxuYWFoWjRhMlg3alpVUWFs?= =?utf-8?B?TjFxWUc2NFRrMVIrZ2JDbTVZcGk5UFNRaXg2QUJId25IVmdQa1hyUnFsd05M?= =?utf-8?B?UmhKRjVGdCtDT0dKNXFkeml5cWI3S2hobzdRNVNSMFBGSHU0cHJHdHBWNDBT?= =?utf-8?B?aXNUY2xkQjFwNXRTSVNWQVNUajJGUkRaVHllcVdUWHVxa2YxQ1kvTTNvSmE0?= =?utf-8?B?bUk0ZTY4UllINGNIS2piYmhzcUFZSEZyZnhweVVKYU1xZzNyOWs1eHQ3dXNK?= =?utf-8?B?ZlZVVE9GZzhRbXZWcTRtbXFwaitxaWltaEJVcFJYOEhKcmg5ZkV6SGVuOUpP?= =?utf-8?B?RU5nckk2bUorOTQ3QXJpbFZmeDJMc25hN3lyZVZMTzFBOW83ZjVPY2RXOHdu?= =?utf-8?B?R2xFUTVTaktXV21idnU0b09ZdElvcWdRbWNRMzFkVHNPNDd4ZFZYV05iaU9x?= =?utf-8?B?bmU0VG5Hb096RlFHWk1FUjgzY3pOU0o0NzNPSkl3cnljdXVOZTdjL2JDenBp?= =?utf-8?B?Mi9ZMXRtU0ZkWnp0dEtrWXh5YVM2dFE0My9OQzlsTmF6SXh5YTdEQTR3c3RP?= =?utf-8?Q?9MXsvUfi5CvWwChKvP3kMHz7J?= X-Microsoft-Antispam-Message-Info: setRESSac6Ifsn13AchOPY6zzMhjA7hJT4xQhIcPvp4SRK4/AyLnxfcxkb7AlUIm988knAgLXOkiPJXbV6KsVCnlnec5KssC4aRH9nKA7jXmCV19ezSoxIrsK8A4rM2O2q0uDZWtT7qaatPhU/LiI3FyH/ycgxrTfJO8kZ7DmyAtibkpboFGdZuK0Sxxv4ZY X-Microsoft-Exchange-Diagnostics: 1;SN6PR15MB2400;6:ufbLFQv6LMA5c4LiuBYYuQ98CKwp/90+NfW3mbTabqWYaR8g9v6PrsgcuoKSyqS9M/7G2hCYDXaP1jdM5772tfcZr0j7XcA9qFnpYW/ArT4/WLkgSJ6yAFXk2oQi53WMuVcdfX27o+ijd6DO3edQF7+OrsJrzGQH8AItg51d5Nvf5OphlmaWSYDgYFoo3/BJXs/ZFEHdoRDzxjLDkFjzbdxdn/5n0IWlDA0GmNUgdBRKLADoidYc/SlZgfefHgd34aFZ2xIHVuf4u/5nVWrin3kwoBjsq1KJ2d+kGWZDCvBRmsKbRQxRujIsjm1jKUuP+Hj/dDrhwP4EMs2FBC1B04Db8TIOgiCQPRZuWzoJLJ7ffaE/9g79znrEmzV0SqrQdvOAwTXMhMe1TlJ3FHKTN6hw8mXbdOhpo1HOEtABgPKtr/x4H1IP3fXf9jG82Lzwe1iJ1nudXVbiBnevTDlPmg==;5:PJG19uaS2MfLjEF4c20jBcLziNjMdQtfJUwQo4mFe3AXg0Hvwmw2dAsFQxzC5Jy3Zy2tP1Myj3+ZYreLdOB+FPUSO06NeY/9YVAStmy/u5yV50gPCnnDWeMVPoCS/ZSNw0hfpIi0LgJ18najrdKbVpO4MHrPReWbIKG+QVjqPTI=;24:i+UfUewI/VWBx2MQiSWRUE7jaZWwT2A14Ycrig8dwoBvHSevhBGaAEpE8ubBJ4vDA+S9QLfq4ZHC2aH56rgvHdF6qn+MXxY43M7+J13cK9E= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN6PR15MB2400;7:LhENy5yirMXo2KPPVbF8GtaPqrPW1kFTBhldNEs5gB173Xyts2HcIYtO5RdamE130Wc0GC1zh2fYreat/GM+ovw8bnggsbWcfi5bzCqVMkdi0FJyitdcLGkEiIDYew5cLHE7FTUZPBcj8FNSdtUBZDOr3UPRO+McHMsXMKsOlmlVXdDLipO/x9ue01d3hvbjPSFnLMJ7GkohGnByxe++uvZrmsEgcGP1+HDxZ2K90tdKhhtS3Y4RgiEEwOsV/CMW X-MS-Office365-Filtering-Correlation-Id: 23303cc2-9b48-49f2-d86c-08d5bd04ddc9 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2018 21:18:13.8804 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 23303cc2-9b48-49f2-d86c-08d5bd04ddc9 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR15MB2400 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00427.txt.bz2 On 2018-05-16 10:18 AM, Pedro Alves wrote: > This helps because discard_pending_stop_replies will later become a > method of remote_target. Otherwise, when we have multiple instances > of remote_target, we'd have to make discard_pending_stop_replies find > the inferior's target_ops, and upcast it to remote_target (if indeed a > remote) to find the pending stop replies queue to clear. > > gdb/ChangeLog: > yyyy-mm-dd Pedro Alves > > * remote.c (remote_target::mourn_inferior): Move > discard_pending_stop_replies call here from ... > (_initialize_remote): ... here. > --- > gdb/remote.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/gdb/remote.c b/gdb/remote.c > index ef15eafe2a..230288b727 100644 > --- a/gdb/remote.c > +++ b/gdb/remote.c > @@ -9666,6 +9666,10 @@ remote_target::mourn_inferior () > { > struct remote_state *rs = get_remote_state (); > > + /* We're no longer interested in notification events of an inferior > + that exited or was killed/detached. */ > + discard_pending_stop_replies (current_inferior ()); > + > /* In 'target remote' mode with one inferior, we close the connection. */ > if (!rs->extended && number_of_live_inferiors () <= 1) > { > @@ -14059,9 +14063,6 @@ _initialize_remote (void) > > /* Hook into new objfile notification. */ > gdb::observers::new_objfile.attach (remote_new_objfile); > - /* We're no longer interested in notification events of an inferior > - when it exits. */ > - gdb::observers::inferior_exit.attach (discard_pending_stop_replies); > > #if 0 > init_remote_threadtests (); > LGTM. Simon