From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id caXQCnUjtGqLvDgAWB0awg (envelope-from ) for ; Wed, 23 Sep 2026 15:07:33 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=DYspa0Ov; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=6r0ue9GV; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=gV494TC8; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qtIPNW8c; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 237B81E06B; Wed, 23 Sep 2026 15:07:33 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4E5F61E01F for ; Wed, 23 Sep 2026 15:07:32 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CC1114BB3BCA for ; Wed, 23 Sep 2026 19:07:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CC1114BB3BCA Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=DYspa0Ov; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=6r0ue9GV; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=gV494TC8; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qtIPNW8c Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id B54364BB3BBB for ; Wed, 23 Sep 2026 19:07:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B54364BB3BBB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B54364BB3BBB Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790190427; cv=none; b=FV5jxLaYpL/hzkMNhN9XVqr61EC6a9d+HklTdFs8dsRlfPx5bMlgO5skThN4jH0tQZo22tpSLR+m9oh2Ivku/ZzHuC5eNE7KoiTN08w33hKlOTxBeq3jvQJ8pFFOMoO5oE/DSv4lFydyMKWrjo/SaXzbOxloddmzssWQTZpUon8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790190427; c=relaxed/simple; bh=PSKfcAUdwWLWRlhb3FzFHOHUFER84nvM3rjo7356Sd4=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=QB0KkeDxTnyFvkCceeaPTMdepExQqiWdCpkvgwup73yeUm+lRBCEBd3P+1bCg/MYOjFwCNCQgzrK8d0X+7irOgQsRQfNM3n012pSvDZyYs5wOEin0aIOuA+Ro5vqdzXLU1jgID2BF755S/QUvaIt0yjDQfur3abAHE7DYrZ8s2Y= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=DYspa0Ov; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=6r0ue9GV; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=gV494TC8; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qtIPNW8c DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B54364BB3BBB Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8081321D1D; Wed, 23 Sep 2026 19:06:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790190422; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OmjLmS2eHFjQVDIEuOpwywhzZJZHNh3zRg4zIavpCoo=; b=DYspa0OvpCMlB/ygww4B1uaIrUXGWSluzOqdHKnFAwk4MGom4mRgW1f99zNf5sJM4Xuf5n 9WwYEFKFyxkz/laVdJAuNosKSHGGPotlzWoiHpz0HGoOM52AEywxfrIMVa1wZj0U+fzZqT CT/mZWJRyLEv18Pqqg6l0wJN+O3S2o4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790190422; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OmjLmS2eHFjQVDIEuOpwywhzZJZHNh3zRg4zIavpCoo=; b=6r0ue9GVaGDdzRvh74Cq+8Pj+c0aquppAt2xrb2dkPGKrpgjOdaxoto+z7Ed+SAKWrUajF WeseLhHH5A3iD3BQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=gV494TC8; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=qtIPNW8c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790190418; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OmjLmS2eHFjQVDIEuOpwywhzZJZHNh3zRg4zIavpCoo=; b=gV494TC8EPKJPYIGGTCllPlxqir4w5EVNLYko+rZjFOakAi/741cerL8j3wyR9bucRKpxd MySP8mHEbKzmFa5WbUzbra+yojAEucWkC3s+0hDcwK9gbi3NrhLgj4KlrHUo1Az9d9XTdj TKJT40VVO6YttrEDhl8Zw5059QnEDzM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790190418; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OmjLmS2eHFjQVDIEuOpwywhzZJZHNh3zRg4zIavpCoo=; b=qtIPNW8c6d5e39NesqyaYZF0JEp6oay8wNiTeAIqQx5Ey6NSAL2WjQWbrfXfUvYwOGNcsY OapgJrMFhIA3RxBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 48751134E8; Wed, 23 Sep 2026 19:06:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Vo9SBFIjtGrEFAAAD6G6ig (envelope-from ); Wed, 23 Sep 2026 19:06:58 +0000 Message-ID: Date: Wed, 23 Sep 2026 21:06:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/11] [gdb/testsuite] Refactor exception handling in with_stub_devices To: Keith Seitz , gdb-patches@sourceware.org References: <20260824135855.1195963-1-tdevries@suse.de> <20260824135855.1195963-12-tdevries@suse.de> <9da9e1c1-bf93-4bd0-9886-cc208962aca0@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <9da9e1c1-bf93-4bd0-9886-cc208962aca0@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 8081321D1D X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/1/26 6:10 PM, Keith Seitz wrote: > Hi, > > On 8/24/26 6:58 AM, Tom de Vries wrote: >> Use with_override and try/finally to simplify with_stub_devices. >> >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34552 >> --- >>   gdb/testsuite/gdb.rocm/hcc-amdgpu-targets.exp | 15 +++++++++------ >>   1 file changed, 9 insertions(+), 6 deletions(-) >> >> diff --git a/gdb/testsuite/gdb.rocm/hcc-amdgpu-targets.exp b/gdb/ >> testsuite/gdb.rocm/hcc-amdgpu-targets.exp >> index 8f04cca7981..7f90a112138 100644 >> --- a/gdb/testsuite/gdb.rocm/hcc-amdgpu-targets.exp >> +++ b/gdb/testsuite/gdb.rocm/hcc-amdgpu-targets.exp >> @@ -24,13 +24,16 @@ load_lib rocm.exp >>   # Run BODY with find_amdgpu_devices stubbed to return DEVICES, then >>   # restore the original proc. >>   proc with_stub_devices {devices body} { >> -    rename find_amdgpu_devices __saved_find_amdgpu_devices >>       # tclint-disable-next-line command-args >> -    proc find_amdgpu_devices {} [list return $devices] >> -    set code [catch {uplevel 1 $body} result] >> -    rename find_amdgpu_devices {} >> -    rename __saved_find_amdgpu_devices find_amdgpu_devices >> -    return -code $code $result >> +    proc with_stub_devices_find_amdgpu_devices {} [list return $devices] >> +    try { >> +    # tclint-disable-next-line command-args >> +    with_override \ >> +        find_amdgpu_devices with_stub_devices_find_amdgpu_devices \ >> +        $body >> +    } finally { >> +    rename with_stub_devices_find_amdgpu_devices {} >> +    } > > IIUC, this try block using with_override is effectively evaluating > "$body" in this context (with_stub_devices). Previously the > uplevel would cause this to run in the caller. > > Is this missing a call to transparent_uplevel? > It is, thanks for catching that. I'm about to push this, with a fix. Thanks, - Tom > Keith >