Re: [PATCH v2 3/7] Fortran: Accessing fields of inherited types via fully qualified name.

Richard Bunt
2019-01-16T11:11:07Z

I have no further comments on v2 and look forward to v3.

Many thanks,

Rich.

On 12/9/18 8:40 PM, Paweł Wódkowski wrote:
> On 06.12.2018 16:02, Richard Bunt wrote:
>> Hi Paweł,
>>
>> I was testing with gfortran 7.3.0 and ifort 18.2. On the latter I observe
>> 2 kfails relating to the missing extends in the ptype output. However, this
>> is because I do not have patch 4 applied. I will take a closer look at this
>> patch with ifort 18.2 since I can analyze the implementation in action.
>>
>
> Ok, will wait (perhaps Wednesday) with v3. Pls, let know if there is
> something more to change.
>
> btw, I have ifort 19.0.1.144 20181018
>
>
>> On 12/4/18 9:05 PM, Paweł Wódkowski wrote:
>>
>>>>> +gdb_test "whatis wp_vla" "type = <not allocated>"
>>
>> A small nit while I'm here:
>> GDB tests needs to be uniquely identifiable, see https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Make_sure_test_messages_are_unique
>>
>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: continue to breakpoint: ! After value assignment
>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: continue to breakpoint: ! Before vla allocation
>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: ptype wp%point%coo
>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: ptype wp_vla(1)%point%coo
>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp
>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp%point
>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp%point%coo
>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp_vla(1)
>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp_vla(1)%point
>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp_vla(1)%point%coo
>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: whatis wp
>> 2 (gdb) PASS: gdb.fortran/oop-extend-type.exp: whatis wp_vla
>>
>>
>
> Thx for the link. I will fix this.
>
> Pawel
>
>> Many thanks,
>>
>> Rich.
>>
>