From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QLRxKwmhl2Mr7SYAWB0awg (envelope-from ) for ; Mon, 12 Dec 2022 16:45:45 -0500 Received: by simark.ca (Postfix, from userid 112) id ADA301E124; Mon, 12 Dec 2022 16:45:45 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=LXuQLZo8; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_REPLYTO_END_DIGIT,MAILING_LIST_MULTI, NICE_REPLY_A,RCVD_IN_DNSWL_HI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 561571E112 for ; Mon, 12 Dec 2022 16:45:45 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AC2E8384E233 for ; Mon, 12 Dec 2022 21:45:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AC2E8384E233 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1670881544; bh=YTllMH4r3ij0zaon9H+oJoaze6sJonL8e7cXQJUL3fc=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=LXuQLZo89OQyviFJNZxUU6Pwy2HmXKL2g+61MPIkG/ahLKV6nyAFvbsczUEIGefzp O9W1AHedMnxGcPJXqfL5UyqCRhZFj7HQKLqQSnkqN3qYDTR254DYou/X5qXSJoGPpd PwK+1jaA0Y2hpj9xnZEVgip1NmR7JTg3+7EuQDj4= Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 5A9D23852A79 for ; Mon, 12 Dec 2022 21:44:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5A9D23852A79 Received: by mail-pl1-x62c.google.com with SMTP id t2so10505391ply.2 for ; Mon, 12 Dec 2022 13:44:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YTllMH4r3ij0zaon9H+oJoaze6sJonL8e7cXQJUL3fc=; b=KTXI6QvIOz3ZTpAj6QqlMq3kTHvQ47yQ2gSDLK0qxFxxuDX3IVR6hAEy2FCLn0O/1e c9/5n4mmO0s/eak/ENgo6toIoDD2RwiFEvdPXioH29BFm9uJFN1v9VrRMrzPaWVGoR5G BEFWgs9RJigJ9AfwVR0uvGTPpgZerNqpaW4dqa35q7tnS6pd1hBnNATSf8wkRHy61Se4 ZRmg5C5tybNspIBPwBVYsmvH3vPIm+1u/W2UJcxNoeDO02IPXhn5grSVAtvecYx/9uju rtGtk1e45dLwJeH2llviGY7TITLZ+Aoqk+Q40ygYR1m+3a1nCq/l8tYPG1ukTjs4rR7U ckvA== X-Gm-Message-State: ANoB5pmWiOP5E1Q4Ax/O+rsNAgl/FFSEVfJt86n5by1b2bbP835Kjckx ALGK9RzSH3H5j6nx5cm0WZQdPqLhqAAMWg== X-Google-Smtp-Source: AA0mqf4Kf+d52X2OYTW9WmjHCKUiGVUvuPg5se9z4rfhmIpLhLaXDlW1DbQs6Cnbs6wvElAeZFn7Nw== X-Received: by 2002:a17:903:4282:b0:189:5ca6:af59 with SMTP id ju2-20020a170903428200b001895ca6af59mr15928800plb.51.1670881493408; Mon, 12 Dec 2022 13:44:53 -0800 (PST) Received: from [192.168.117.117] (sd237023.ching-de.ab.nthu.edu.tw. [140.114.237.23]) by smtp.gmail.com with ESMTPSA id f4-20020a170902ce8400b001897bfc9800sm6893058plg.53.2022.12.12.13.44.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Dec 2022 13:44:53 -0800 (PST) Message-ID: Date: Tue, 13 Dec 2022 05:44:50 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PING^5] [PATCH v2] [gdb/python] Replace gdbpy_should_stop with gdbpy_breakpoint_cond_says_stop Content-Language: en-US To: BrunoLarsen , gdb-patches@sourceware.org References: <20220923060027.78902-1-j3.soon777@gmail.com> <20221020182456.2701-1-j3.soon777@gmail.com> <2e4ab20c-30f4-e6cd-69ec-729b1d74a921@gmail.com> <525832fc-7e9b-ab51-25b0-62df8a3b7c2d@gmail.com> In-Reply-To: <525832fc-7e9b-ab51-25b0-62df8a3b7c2d@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Johnson Sun via Gdb-patches Reply-To: Johnson Sun Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Ping for: . Johnson On 12/5/2022 12:45 AM, Johnson Sun wrote: > Ping for: > . > > Johnson > > On 11/25/2022 11:10 PM, Johnson Sun wrote: >> Ping for: >> . >> >> Johnson >> >> On 11/18/2022 8:14 PM, JohnsonSun wrote: >>> Ping for: >>> . >>> >>> Johnson >>> >>> On 10/21/2022 2:24 AM, Johnson Sun wrote: >>>> In 2014, the function `gdbpy_should_stop' has been replaced with >>>> `gdbpy_breakpoint_cond_says_stop' >>>> >>>> This replaces `gdbpy_should_stop' with >>>> `gdbpy_breakpoint_cond_says_stop' in the >>>> comments. >>>> >>>> Since `gdbpy_should_stop' has been renamed as noted in >>>> `gdb/ChangeLog-2014': >>>> >>>>     * python/py-breakpoint.c (gdbpy_breakpoint_cond_says_stop): >>>> Renamed >>>>     from gdbpy_should_stop.  Change result type to enum scr_bp_stop. >>>> --- >>>>   gdb/python/py-finishbreakpoint.c | 4 ++-- >>>>   1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/gdb/python/py-finishbreakpoint.c >>>> b/gdb/python/py-finishbreakpoint.c >>>> index c80096f6810..dcf86317779 100644 >>>> --- a/gdb/python/py-finishbreakpoint.c >>>> +++ b/gdb/python/py-finishbreakpoint.c >>>> @@ -90,7 +90,7 @@ bpfinishpy_dealloc (PyObject *self) >>>>     Py_TYPE (self)->tp_free (self); >>>>   } >>>>   -/* Triggered when gdbpy_should_stop is about to execute the >>>> `stop' callback >>>> +/* Triggered when gdbpy_breakpoint_cond_says_stop is about to >>>> execute the `stop' callback >>>>      of the gdb.FinishBreakpoint object BP_OBJ.  Will compute and >>>> cache the >>>>      `return_value', if possible.  */ >>>>   @@ -134,7 +134,7 @@ bpfinishpy_pre_stop_hook (struct >>>> gdbpy_breakpoint_object *bp_obj) >>>>       } >>>>   } >>>>   -/* Triggered when gdbpy_should_stop has triggered the `stop' >>>> callback >>>> +/* Triggered when gdbpy_breakpoint_cond_says_stop has triggered >>>> the `stop' callback >>>>      of the gdb.FinishBreakpoint object BP_OBJ.  */ >>>>     void >>>