From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id CCE26394BE1E for ; Fri, 28 Aug 2020 17:12:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CCE26394BE1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 738C41E599; Fri, 28 Aug 2020 13:12:45 -0400 (EDT) Subject: Re: [PATCH 10/13] Use gdb_bfd_sections in restore_command To: Tom Tromey , gdb-patches@sourceware.org References: <20200828162349.987-1-tom@tromey.com> <20200828162349.987-11-tom@tromey.com> From: Simon Marchi Message-ID: Date: Fri, 28 Aug 2020 13:12:43 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200828162349.987-11-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Aug 2020 17:12:46 -0000 On 2020-08-28 12:23 p.m., Tom Tromey wrote: > This changes restore_command to avoid bfd_map_over_sections, in favor > of iteration. A helper data structure can also be removed by this > patch. > > gdb/ChangeLog > 2020-08-28 Tom Tromey > > * cli/cli-dump.c (struct callback_data): Remove. > (restore_one_section): Rename from restore_section_callback. > Change parameters. > (restore_binary_file): Change parameters. > (restore_command): Use foreach. Warnings I got while applying: Applying: Use gdb_bfd_sections in restore_command .git/rebase-apply/patch:44: trailing whitespace. if (sec_end <= load_start .git/rebase-apply/patch:76: trailing whitespace. + sec_offset + load_offset), .git/rebase-apply/patch:86: trailing whitespace. ret = target_write_memory (sec_start + sec_offset + load_offset, .git/rebase-apply/patch:178: trailing whitespace. load_start = .git/rebase-apply/patch:198: trailing whitespace. (unsigned long) load_start, warning: 5 lines add whitespace errors. Simon