From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 0319B3858D34 for ; Fri, 26 Jun 2020 22:22:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0319B3858D34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Sandra_Loosemore@mentor.com IronPort-SDR: HGadQw0Yyfa95hOzC9y0o7mZV8+bJfoJAryLZ78DSwSsTa0NdFoCC8CVtz/HMlJKhOwCT9F569 pVggmMo0SMZ8lTO6Yd780jBLfC6fmeDQkVUTSYIJKnIFA/XHdGgMNjjddX7w2CwnXjaUmqwy3C paD4BfrdurZWL9jbbaa81KvDEPwwkWf8zzauzs0IcmuTYiTVhkaXc01ICeStqFYzNYgJtMLYbk xmDx7VUO2HAybowWt5enjCCrS4cSNRdAKSYPdipfAzi9MVNoVx/PxvIKCFQpYILKq4prOYSIf8 gHM= X-IronPort-AV: E=Sophos;i="5.75,285,1589270400"; d="scan'208";a="52384032" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 26 Jun 2020 14:22:50 -0800 IronPort-SDR: IbfUinP6wu9FMmHUZb+yoV9HHBUWptfK0zCXBKwkAwFmk+i+L7E/VCo4c4d9n5+Y3wSX8n31b4 5Bz/KlhaGnzeWdGo+mlVtEks+9YzdzY354MNK4OW1zCaLd5kBgQd5ak6r7sjt/TL+cpmOUSQaL +aRsYEbk8OSog9MfKsebWWAU/TAkPwLHEICdFFmuYorefNqeZPdyoqx/YdEH1a2ctDESw8p+sP aKLmY6Ukj7jEYkilWsDU3/A7jSPwSuPa7eVALRft2Clxjmgmzi6uT/xEhB3zoZmeEz/mZCQ/md Iy8= Subject: Re: [patch] gdb/testsuite: Fix POSIX-isms in gdb.base/shell.exp To: Eli Zaretskii CC: , References: <6bc2b01e-3807-77b9-7d1e-d7f6a7875e49@codesourcery.com> <83k0zvrpdk.fsf@gnu.org> <83eeq2s3ra.fsf@gnu.org> From: Sandra Loosemore Message-ID: Date: Fri, 26 Jun 2020 16:22:43 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <83eeq2s3ra.fsf@gnu.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-02.mgc.mentorg.com (147.34.90.202) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jun 2020 22:22:53 -0000 On 6/26/20 1:08 AM, Eli Zaretskii wrote: > [snip] > > Here's the patch I installed on the master branch: > > diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog > index 4b1a4c0..c591934 100644 > --- a/gdb/doc/ChangeLog > +++ b/gdb/doc/ChangeLog > @@ -1,3 +1,8 @@ > +2020-06-26 Eli Zaretskii > + > + * gdb.texinfo (Shell Commands): More accurate description of use > + of $SHELL. Reported by Sandra Loosemore . > + > 2020-06-23 Andrew Burgess > > * gdb.texinfo (Maintenance Commands): Document new 'maint print > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 7f8c77a..fbe9f85 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -1451,9 +1451,10 @@ > @itemx !@var{command-string} > Invoke a standard shell to execute @var{command-string}. > Note that no space is needed between @code{!} and @var{command-string}. > -If it exists, the environment variable @code{SHELL} determines which > -shell to run. Otherwise @value{GDBN} uses the default shell > -(@file{/bin/sh} on Unix systems, @file{COMMAND.COM} on MS-DOS, etc.). > +On GNU and Unix systems, the environment variable @code{SHELL}, if it > +exists, determines which shell to run. Otherwise @value{GDBN} uses > +the default shell (@file{/bin/sh} on GNU and Unix systems, > +@file{cmd.exe} on MS-Windows, @file{COMMAND.COM} on MS-DOS, etc.). > @end table > > The utility @code{make} is often needed in development environments. > This looks fine to me -- thanks. -Sandra